1. 02 Mar, 2010 3 commits
  2. 01 Mar, 2010 7 commits
  3. 28 Feb, 2010 5 commits
    • Tom Lane's avatar
      Fix up memory management problems in contrib/xml2. · 936c4af1
      Tom Lane authored
      Get rid of the code that attempted to funnel libxml2's memory allocations
      into palloc.   We already knew from experience with the core xml datatype
      that trying to do this is simply not reliable.  Unlike the core code, I
      did not bother adding a lot of PG_TRY/PG_CATCH logic to try to ensure that
      everything is cleaned up on error exit.  Hence, we might leak some memory
      if one of these functions fails partway through.  Given the deprecated
      status of this contrib module and the fact that errors partway through
      the functions shouldn't be too common, it doesn't seem worth worrying about.
      
      Also fix a separate bug in xpath_table, that it did the wrong things
      if given a result tuple descriptor with less than 2 columns.  While
      such a case isn't very useful in practice, we shouldn't fail or stomp
      memory when it occurs.
      
      Add some simple regression tests based on all the reported crash cases
      that I have on hand.
      
      This should be back-patched, but let's see if the buildfarm likes it first.
      936c4af1
    • Greg Stark's avatar
      Second try at fsyncing directories in CREATE DATABASE. Let's see what the... · 7d7db18a
      Greg Stark authored
      Second try at fsyncing directories in CREATE DATABASE. Let's see what the build farm says of opening directories read-only and ignoring EBADF from fsync of directories
      7d7db18a
    • Tom Lane's avatar
      Assorted code cleanup for contrib/xml2. No change in functionality, · a12333ee
      Tom Lane authored
      just make it a bit less ugly in places.
      a12333ee
    • Bruce Momjian's avatar
      bd7246f6
    • Bruce Momjian's avatar
      *** empty log message *** · 0ff1c3e5
      Bruce Momjian authored
      0ff1c3e5
  4. 27 Feb, 2010 10 commits
  5. 26 Feb, 2010 13 commits
  6. 25 Feb, 2010 2 commits
    • Bruce Momjian's avatar
      d98039d8
    • Tom Lane's avatar
      Allow predicate_refuted_by() to deduce that NOT A refutes A. · 99419d36
      Tom Lane authored
      We had originally made the stronger assumption that NOT A refutes any B
      if B implies A, but this fails in three-valued logic, because we need to
      prove B is false not just that it's not true.  However the logic does
      go through if B is equal to A.
      
      Recognizing this limited case is enough to handle examples that arise when
      we have simplified "bool_var = true" or "bool_var = false" to just "bool_var"
      or "NOT bool_var".  If we had not done that simplification then the
      btree-operator proof logic would have been able to prove that the expressions
      were contradictory, but only for identical expressions being compared to the
      constants; so handling identical A and B covers all the same cases.
      
      The motivation for doing this is to avoid unexpected asymmetrical behavior
      when a partitioned table uses a boolean partitioning column, as in today's
      gripe from Dominik Sander.
      
      Back-patch to 8.2, which is as far back as predicate_refuted_by attempts to
      do anything at all with NOTs.
      99419d36