- 15 Aug, 2006 2 commits
-
-
Michael Meskes authored
-
Michael Meskes authored
Fixed broken newline on Windows. Fixed a nasty buffer underrun that only occured when using Informix no_indicator NULL setting on timestamps and intervals.
-
- 14 Aug, 2006 7 commits
-
-
Tom Lane authored
requiring read permissions. Up till now there was no possible case in which the RTEs wouldn't already have ACL_SELECT set ... but now that you can say something like 'INSERT INTO foo ... RETURNING *' this is an essential step. With this commit, a RETURNING clause adds the requirement for SELECT permissions on the target table if and only if the clause actually reads the value of at least one target-table column.
-
Tom Lane authored
cannot assume that there's exactly one Query in the Portal, as we can for ONE_SELECT mode, because non-SELECT queries might have extra queries added during rule rewrites. Fix things up so that we'll use ONE_RETURNING mode when a Portal contains one primary (canSetTag) query and that query has a RETURNING list. This appears to be a second showstopper reason for running the Portal to completion before we start to hand anything back --- we want to be sure that the rule-added queries get run too.
-
Tom Lane authored
as per yesterday's proposal. Also make things a tad more orthogonal by adding the recent STRICT addition to EXECUTE INTO. Jonah Harris and Tom Lane
-
Tom Lane authored
_SPI_execute_plan's return code should reflect the type of the query that is marked canSetTag, not necessarily the last one in the list. This is arguably a bug fix, but I'm hesitant to back-patch it because it's the sort of subtle change that might break someone's code, and it's best not to do that kind of thing in point releases.
-
Tom Lane authored
a Coverity warning, these are risky since the hashtable isn't necessarily fully set up yet. They're unnecessary anyway: a deletable hashtable should be in a memory context that will be cleared following elog(ERROR). Per report from Martijn van Oosterhout.
-
Bruce Momjian authored
values, due to concern about the patch.
-
Tom Lane authored
and instead make the grammar production for the RETURN statement do the heavy lifting. The lookahead idea was copied from the main parser, but it does not work in plpgsql's parser because here gram.y looks explicitly at the scanner's yytext variable, which will be out of sync after a failed lookahead step. A minimal example is create or replace function foo() returns void language plpgsql as ' begin perform return foo bar; end'; which can be seen by testing to deliver "foo foo bar" to the main parser instead of the expected "return foo bar". This isn't a huge bug since RETURN is not found in the main grammar, but it could bite someone who tried to use "return" as an identifier. Back-patch to 8.1. Bug exists further back, but HEAD patch doesn't apply cleanly, and given the lack of field complaints it doesn't seem worth the effort to develop adjusted patches.
-
- 13 Aug, 2006 11 commits
-
-
Tom Lane authored
when what's being executed is a COMMIT or ROLLBACK. Per report from Sergey Koposov. Backpatch to 8.1; 8.0 and before don't have the bug due to lack of any logging at all here.
-
Tom Lane authored
for INSERT/UPDATE/DELETE RETURNING. Per discussion.
-
Tom Lane authored
so that it won't interfere with later trials. Per recent buildfarm experience. Anyone know how to do this on Windows?
-
Tom Lane authored
well as vacuum_cost_delay. Since datestyle is a string variable, this exercises memory allocation issues that might not appear when modifying an integer GUC variable. Also, we can observe the side effects of changing datestyle to check that assign hooks are called at the right times.
-
Tom Lane authored
nonunique join value, leading to plan-choice-dependent results ... and it seems some platforms will choose a different plan. Tweak the test so that it has well-defined results. Per report from Olivier Prenant.
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Michael Meskes authored
Merged dyntest.pgc and dyntest2.pgc. Hopefully fixed the last Coverity reports (finally)
-
Bruce Momjian authored
hash and array variables. (regression output updated)
-
Bruce Momjian authored
default values.
-
Bruce Momjian authored
-
- 12 Aug, 2006 8 commits
-
-
Tom Lane authored
merely a matter of fixing the error check, since the underlying Portal infrastructure already handles it. This in turn allows these statements to be used in some existing plpgsql and plperl contexts, such as a plpgsql FOR loop. Also, do some marginal code cleanup in places that were being sloppy about distinguishing SELECT from SELECT INTO.
-
Tom Lane authored
-
Bruce Momjian authored
hashes. Was causing regression failures.
-
Bruce Momjian authored
failures.
-
Bruce Momjian authored
default values. Was causing regression failures.
-
Bruce Momjian authored
< o Allow INSERT/UPDATE ... RETURNING new.col or old.col < < This is useful for returning the auto-generated key for an INSERT. < One complication is how to handle rules that run as part of < the insert. < http://archives.postgresql.org/pgsql-patches/2005-07/msg00568.php > o -Allow INSERT/UPDATE ... RETURNING new.col or old.col
-
Bruce Momjian authored
-
Tom Lane authored
plpgsql support to come later. Along the way, convert execMain's SELECT INTO support into a DestReceiver, in order to eliminate some ugly special cases. Jonah Harris and Tom Lane
-
- 11 Aug, 2006 11 commits
-
-
Bruce Momjian authored
Yoshiyuki Asaba
-
Bruce Momjian authored
< o %Allow commenting of variables in postgresql.conf to restore them > o -Allow commenting of variables in postgresql.conf to restore them
-
Bruce Momjian authored
-
Bruce Momjian authored
defaults. Zdenek Kotala
-
Bruce Momjian authored
The main reason for refactoring was that set_config_option() was too overloaded function and its behavior did not consistent. Old version of set_config_function hides some messages. For example if you type: tcp_port = 5432.1 then old implementation ignore this error without any message to log file in the signal context (configuration reload). Main problem was that semantic analysis of postgresql.conf is not perform in the ProcessConfigFile function, but in the set_config_options *after* context check. This skipped check for variables with PG_POSTMASTER context. There was request from Joachim Wieland to add more messages about ignored changes in the config file as well. Zdenek Kotala
-
Bruce Momjian authored
Allow conversion from perl to postgresql array in OUT parameters. Second, allow hash form output from procedures with one OUT argument. Pavel Stehule
-
Bruce Momjian authored
David Fetter
-
Bruce Momjian authored
-
Alvaro Herrera authored
-
Bruce Momjian authored
Ian Barwick
-
Bruce Momjian authored
< * Allow encoding on a per-column basis > * Allow encoding on a per-column basis optionally using the ICU library: > http://archives.postgresql.org/pgsql-patches/2005-08/msg00309.php > http://archives.postgresql.org/pgsql-patches/2006-03/msg00233.php
-
- 10 Aug, 2006 1 commit
-
-
Tom Lane authored
same data type and same typmod, we show that typmod as the output typmod, rather than generic -1. This responds to several complaints over the past few years about UNIONs unexpectedly dropping length or precision info.
-