1. 26 Jun, 2008 11 commits
  2. 24 Jun, 2008 3 commits
    • Tom Lane's avatar
      Reduce the alignment requirement of type "name" from int to char, and arrange · 5f6f840e
      Tom Lane authored
      to suppress zero-padding of "name" entries in indexes.
      
      The alignment change is unlikely to save any space, but it is really needed
      anyway to make the world safe for our widespread practice of passing plain
      old C strings to functions that are declared as taking Name.  In the previous
      coding, the C compiler was entitled to assume that a Name pointer was
      word-aligned; but we were failing to guarantee that.  I think the reason
      we'd not seen failures is that usually the only thing that gets done with
      such a pointer is strcmp(), which is hard to optimize in a way that exploits
      word-alignment.  Still, some enterprising compiler guy will probably think
      of a way eventually, or we might change our code in a way that exposes
      more-obvious optimization opportunities.
      
      The padding change is accomplished in one-liner fashion by declaring the
      "name" index opclasses to use storage type "cstring" in pg_opclass.h.
      Normally btree and hash don't allow a nondefault storage type, because they
      don't have any provisions for converting the input datum to another type.
      However, because name and cstring are effectively the same thing except for
      padding, no conversion is needed --- we only need index_form_tuple() to treat
      the datum as being cstring not name, and this is sufficient.  This seems to
      make for about a one-third reduction in the typical sizes of system catalog
      indexes that involve "name" columns, of which we have many.
      
      These two changes are only weakly related, but the alignment change makes
      me feel safer that the padding change won't introduce problems, so I'm
      committing them together.
      5f6f840e
    • Bruce Momjian's avatar
      TODO item done: · 3dc59bea
      Bruce Momjian authored
      < 	o Prevent pg_dump/pg_restore from being affected by
      > 	o -Prevent pg_dump/pg_restore from being affected by
      3dc59bea
    • Tom Lane's avatar
      Oops, make the MSVC build put fmgroids.h where it needs to be. · 320c7eb8
      Tom Lane authored
      Per buildfarm results.
      320c7eb8
  3. 23 Jun, 2008 9 commits
  4. 20 Jun, 2008 1 commit
    • Tom Lane's avatar
      Seems I was too optimistic in supposing that sinval's maxMsgNum could be · dab421d2
      Tom Lane authored
      read and written without a lock.  The value itself is atomic, sure, but on
      processors with weak memory ordering it's possible for a reader to see the
      value change before it sees the associated message written into the buffer
      array.  Fix by introducing a spinlock that's used just to read and write
      maxMsgNum.  (We could do this with less overhead if we recognized a concept
      of "memory access barrier"; is it worth introducing such a thing?  At the
      moment probably not --- I can't measure any clear slowdown from adding the
      spinlock, so this solution is probably fine.)  Per buildfarm results.
      dab421d2
  5. 19 Jun, 2008 4 commits
    • Tom Lane's avatar
      Rewrite the sinval messaging mechanism to reduce contention and avoid · fad153ec
      Tom Lane authored
      unnecessary cache resets.  The major changes are:
      
      * When the queue overflows, we only issue a cache reset to the specific
      backend or backends that still haven't read the oldest message, rather
      than resetting everyone as in the original coding.
      
      * When we observe backend(s) falling well behind, we signal SIGUSR1
      to only one backend, the one that is furthest behind and doesn't already
      have a signal outstanding for it.  When it finishes catching up, it will
      in turn signal SIGUSR1 to the next-furthest-back guy, if there is one that
      is far enough behind to justify a signal.  The PMSIGNAL_WAKEN_CHILDREN
      mechanism is removed.
      
      * We don't attempt to clean out dead messages after every message-receipt
      operation; rather, we do it on the insertion side, and only when the queue
      fullness passes certain thresholds.
      
      * Split SInvalLock into SInvalReadLock and SInvalWriteLock so that readers
      don't block writers nor vice versa (except during the infrequent queue
      cleanout operations).
      
      * Transfer multiple sinval messages for each acquisition of a read or
      write lock.
      fad153ec
    • Tom Lane's avatar
      Fix a few places that were non-multibyte-safe in tsearch configuration file · 30dc388a
      Tom Lane authored
      parsing.  Per bug #4253 from Giorgio Valoti.
      30dc388a
    • Bruce Momjian's avatar
      Add URL for: · e3ae2789
      Bruce Momjian authored
              o Allow pg_hba.conf to specify host names along with IP addresses
      > 	  http://archives.postgresql.org/pgsql-hackers/2008-06/msg00569.php
      e3ae2789
    • Alvaro Herrera's avatar
      Improve our #include situation by moving pointer types away from the · a3540b0f
      Alvaro Herrera authored
      corresponding struct definitions.  This allows other headers to avoid including
      certain highly-loaded headers such as rel.h and relscan.h, instead using just
      relcache.h, heapam.h or genam.h, which are more lightweight and thus cause less
      unnecessary dependencies.
      a3540b0f
  6. 18 Jun, 2008 4 commits
  7. 17 Jun, 2008 6 commits
    • Tom Lane's avatar
      Remove freeBackends counter from the sinval shared memory area. We used to · 86fdb32b
      Tom Lane authored
      use it to help enforce superuser_reserved_backends, but since 8.1 it's
      just been dead weight.
      86fdb32b
    • Tom Lane's avatar
      Clean up some problems with redundant cross-type arithmetic operators. Add · b163baa8
      Tom Lane authored
      int2-and-int8 implementations of the basic arithmetic operators +, -, *, /.
      This doesn't really add any new functionality, but it avoids "operator is not
      unique" failures that formerly occurred in these cases because the parser
      couldn't decide whether to promote the int2 to int4 or int8.  We could
      alternatively have removed the existing cross-type operators, but
      experimentation shows that the cost of an additional type coercion expression
      node is noticeable compared to such cheap operators; so let's not give up any
      performance here.  On the other hand, I removed the int2-and-int4 modulo (%)
      operators since they didn't seem as important from a performance standpoint.
      Per a complaint last January from ykhuang.
      b163baa8
    • Bruce Momjian's avatar
      4274726d
    • Bruce Momjian's avatar
      Move USE_WIDE_UPPER_LOWER define to c.h, and remove TS_USE_WIDE and use · dc69c036
      Bruce Momjian authored
      USE_WIDE_UPPER_LOWER instead.
      dc69c036
    • Tom Lane's avatar
      Fix the code that adds regclass constants to a plan's list of relation OIDs · 2e835a49
      Tom Lane authored
      that it depends on for replan-forcing purposes.  We need to consider plain OID
      constants too, because eval_const_expressions folds a RelabelType atop a Const
      to just a Const.  This change could result in OID values that aren't really
      for tables getting added to the dependency list, but the worst-case
      consequence would be occasional useless replans.  Per report from Gabriele
      Messineo.
      2e835a49
    • Tom Lane's avatar
      Clean up a number of bogosities around pltcl's handling of the Tcl "result": · 19a6bace
      Tom Lane authored
      1. Directly reading interp->result is deprecated in Tcl 8.0 and later;
      you're supposed to use Tcl_GetStringResult.  This code finally broke with
      Tcl 8.5, because Tcl_GetVar can now have side-effects on interp->result even
      though it preserves the logical state of the result.  (There's arguably a
      Tcl issue here, because Tcl_GetVar could invalidate the pointer result of a
      just-preceding Tcl_GetStringResult, but I doubt the Tcl guys will see it as
      a bug.)
      
      2. We were being sloppy about the encoding of the result: some places would
      push database-encoding data into the Tcl result, which should not happen,
      and we were assuming that any error result coming back from Tcl was in the
      database encoding, which is not a good assumption.
      
      3. There were a lot of calls of Tcl_SetResult that uselessly specified
      TCL_VOLATILE for constant strings.  This is only a minor performance issue,
      but I fixed it in passing since I had to look at all the calls anyway.
      
      #2 is a live bug regardless of which Tcl version you are interested in,
      so back-patch even to branches that are unlikely to be used with Tcl 8.5.
      I went back as far as 8.0, which is as far as the patch applied easily;
      7.4 was using a different error processing scheme that has got its own
      problems :-(
      19a6bace
  8. 16 Jun, 2008 1 commit
  9. 15 Jun, 2008 1 commit