1. 24 Jun, 2008 2 commits
  2. 23 Jun, 2008 9 commits
  3. 20 Jun, 2008 1 commit
    • Tom Lane's avatar
      Seems I was too optimistic in supposing that sinval's maxMsgNum could be · dab421d2
      Tom Lane authored
      read and written without a lock.  The value itself is atomic, sure, but on
      processors with weak memory ordering it's possible for a reader to see the
      value change before it sees the associated message written into the buffer
      array.  Fix by introducing a spinlock that's used just to read and write
      maxMsgNum.  (We could do this with less overhead if we recognized a concept
      of "memory access barrier"; is it worth introducing such a thing?  At the
      moment probably not --- I can't measure any clear slowdown from adding the
      spinlock, so this solution is probably fine.)  Per buildfarm results.
      dab421d2
  4. 19 Jun, 2008 4 commits
    • Tom Lane's avatar
      Rewrite the sinval messaging mechanism to reduce contention and avoid · fad153ec
      Tom Lane authored
      unnecessary cache resets.  The major changes are:
      
      * When the queue overflows, we only issue a cache reset to the specific
      backend or backends that still haven't read the oldest message, rather
      than resetting everyone as in the original coding.
      
      * When we observe backend(s) falling well behind, we signal SIGUSR1
      to only one backend, the one that is furthest behind and doesn't already
      have a signal outstanding for it.  When it finishes catching up, it will
      in turn signal SIGUSR1 to the next-furthest-back guy, if there is one that
      is far enough behind to justify a signal.  The PMSIGNAL_WAKEN_CHILDREN
      mechanism is removed.
      
      * We don't attempt to clean out dead messages after every message-receipt
      operation; rather, we do it on the insertion side, and only when the queue
      fullness passes certain thresholds.
      
      * Split SInvalLock into SInvalReadLock and SInvalWriteLock so that readers
      don't block writers nor vice versa (except during the infrequent queue
      cleanout operations).
      
      * Transfer multiple sinval messages for each acquisition of a read or
      write lock.
      fad153ec
    • Tom Lane's avatar
      Fix a few places that were non-multibyte-safe in tsearch configuration file · 30dc388a
      Tom Lane authored
      parsing.  Per bug #4253 from Giorgio Valoti.
      30dc388a
    • Bruce Momjian's avatar
      Add URL for: · e3ae2789
      Bruce Momjian authored
              o Allow pg_hba.conf to specify host names along with IP addresses
      > 	  http://archives.postgresql.org/pgsql-hackers/2008-06/msg00569.php
      e3ae2789
    • Alvaro Herrera's avatar
      Improve our #include situation by moving pointer types away from the · a3540b0f
      Alvaro Herrera authored
      corresponding struct definitions.  This allows other headers to avoid including
      certain highly-loaded headers such as rel.h and relscan.h, instead using just
      relcache.h, heapam.h or genam.h, which are more lightweight and thus cause less
      unnecessary dependencies.
      a3540b0f
  5. 18 Jun, 2008 4 commits
  6. 17 Jun, 2008 6 commits
    • Tom Lane's avatar
      Remove freeBackends counter from the sinval shared memory area. We used to · 86fdb32b
      Tom Lane authored
      use it to help enforce superuser_reserved_backends, but since 8.1 it's
      just been dead weight.
      86fdb32b
    • Tom Lane's avatar
      Clean up some problems with redundant cross-type arithmetic operators. Add · b163baa8
      Tom Lane authored
      int2-and-int8 implementations of the basic arithmetic operators +, -, *, /.
      This doesn't really add any new functionality, but it avoids "operator is not
      unique" failures that formerly occurred in these cases because the parser
      couldn't decide whether to promote the int2 to int4 or int8.  We could
      alternatively have removed the existing cross-type operators, but
      experimentation shows that the cost of an additional type coercion expression
      node is noticeable compared to such cheap operators; so let's not give up any
      performance here.  On the other hand, I removed the int2-and-int4 modulo (%)
      operators since they didn't seem as important from a performance standpoint.
      Per a complaint last January from ykhuang.
      b163baa8
    • Bruce Momjian's avatar
      4274726d
    • Bruce Momjian's avatar
      Move USE_WIDE_UPPER_LOWER define to c.h, and remove TS_USE_WIDE and use · dc69c036
      Bruce Momjian authored
      USE_WIDE_UPPER_LOWER instead.
      dc69c036
    • Tom Lane's avatar
      Fix the code that adds regclass constants to a plan's list of relation OIDs · 2e835a49
      Tom Lane authored
      that it depends on for replan-forcing purposes.  We need to consider plain OID
      constants too, because eval_const_expressions folds a RelabelType atop a Const
      to just a Const.  This change could result in OID values that aren't really
      for tables getting added to the dependency list, but the worst-case
      consequence would be occasional useless replans.  Per report from Gabriele
      Messineo.
      2e835a49
    • Tom Lane's avatar
      Clean up a number of bogosities around pltcl's handling of the Tcl "result": · 19a6bace
      Tom Lane authored
      1. Directly reading interp->result is deprecated in Tcl 8.0 and later;
      you're supposed to use Tcl_GetStringResult.  This code finally broke with
      Tcl 8.5, because Tcl_GetVar can now have side-effects on interp->result even
      though it preserves the logical state of the result.  (There's arguably a
      Tcl issue here, because Tcl_GetVar could invalidate the pointer result of a
      just-preceding Tcl_GetStringResult, but I doubt the Tcl guys will see it as
      a bug.)
      
      2. We were being sloppy about the encoding of the result: some places would
      push database-encoding data into the Tcl result, which should not happen,
      and we were assuming that any error result coming back from Tcl was in the
      database encoding, which is not a good assumption.
      
      3. There were a lot of calls of Tcl_SetResult that uselessly specified
      TCL_VOLATILE for constant strings.  This is only a minor performance issue,
      but I fixed it in passing since I had to look at all the calls anyway.
      
      #2 is a live bug regardless of which Tcl version you are interested in,
      so back-patch even to branches that are unlikely to be used with Tcl 8.5.
      I went back as far as 8.0, which is as far as the patch applied easily;
      7.4 was using a different error processing scheme that has got its own
      problems :-(
      19a6bace
  7. 16 Jun, 2008 1 commit
  8. 15 Jun, 2008 5 commits
    • Andrew Dunstan's avatar
      Prevent CVS from mangling script · 2ac64dba
      Andrew Dunstan authored
      2ac64dba
    • Andrew Dunstan's avatar
      Add script to find .c and .h files that are missing CVS PostgreSQL markers · 3f850cbd
      Andrew Dunstan authored
      and add them. Avoids third party files or those that would cause regression
      failures.
      3f850cbd
    • Tom Lane's avatar
      Make DROP INDEX lock the parent table before locking the index. This behavior · 906f27dd
      Tom Lane authored
      is necessary to avoid deadlock against ordinary queries, but we'd broken it
      with recent changes that made the DROP machinery lock the index before
      arriving at index_drop.  Per intermittent buildfarm failures.
      906f27dd
    • Tom Lane's avatar
      Fix 64-bit problem in recent patch. · 71ff461a
      Tom Lane authored
      71ff461a
    • Tom Lane's avatar
      Rearrange ALTER TABLE syntax processing as per my recent proposal: the · a0b012a1
      Tom Lane authored
      grammar allows ALTER TABLE/INDEX/SEQUENCE/VIEW interchangeably for all
      subforms of those commands, and then we sort out what's really legal
      at execution time.  This allows the ALTER SEQUENCE/VIEW reference pages
      to fully document all the ALTER forms available for sequences and views
      respectively, and eliminates a longstanding cause of confusion for users.
      
      The net effect is that the following forms are allowed that weren't before:
      	ALTER SEQUENCE OWNER TO
      	ALTER VIEW ALTER COLUMN SET/DROP DEFAULT
      	ALTER VIEW OWNER TO
      	ALTER VIEW SET SCHEMA
      (There's no actual functionality gain here, but formerly you had to say
      ALTER TABLE instead.)
      
      Interestingly, the grammar tables actually get smaller, probably because
      there are fewer special cases to keep track of.
      
      I did not disallow using ALTER TABLE for these operations.  Perhaps we
      should, but there's a backwards-compatibility issue if we do; in fact
      it would break existing pg_dump scripts.  I did however tighten up
      ALTER SEQUENCE and ALTER VIEW to reject non-sequences and non-views
      in the new cases as well as a couple of cases where they didn't before.
      
      The patch doesn't change pg_dump to use the new syntaxes, either.
      a0b012a1
  9. 14 Jun, 2008 2 commits
  10. 13 Jun, 2008 2 commits
    • Bruce Momjian's avatar
      Modify TODO entry to be a function: · 95ce4ee9
      Bruce Momjian authored
      > 	o Add functions to syntax check configuration files
      >
      < * Add pg_ctl option to do a syntax check of postgresql.conf
      95ce4ee9
    • Tom Lane's avatar
      Improve the various elog messages in tuptoaster.c to report which TOAST table · 55a56845
      Tom Lane authored
      the problem happened in.  These are all supposedly can't-happen cases, but
      when they do happen it's useful to know where.
      
      Back-patch to 8.3, but not further because the patch doesn't apply cleanly
      further back.  Given the lack of response to my proposal of this, there
      doesn't seem to be enough interest to justify much back-porting effort.
      55a56845
  11. 12 Jun, 2008 3 commits
  12. 11 Jun, 2008 1 commit