- 19 Apr, 2008 3 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Bruce Momjian authored
archives. We have been using URLs for a while for new items.
-
- 18 Apr, 2008 6 commits
-
-
Alvaro Herrera authored
conventions. I also changed seg_in and seg_out, which was probably unnecessary, but it can't harm.
-
Tom Lane authored
-
Alvaro Herrera authored
uses of the long-deprecated float32 in contrib/seg; the definitions themselves are still there, but no longer used. fmgr/README updated to match. I added a CREATE FUNCTION to account for existing seg_center() code in seg.c too, and some tests for it and the neighbor functions. At the same time, remove checks for NULL which are not needed (because the functions are declared STRICT). I had to do some adjustments to contrib's btree_gist too. The choices for representation there are not ideal for changing the underlying types :-( Original patch by Zoltan Boszormenyi, with some adjustments by me.
-
Tom Lane authored
file; the idea is that we should clean up as much as we can, even if there's some problem removing one file. Make the error messages a bit less misleading, too. In passing, const-ify function arguments.
-
Heikki Linnakangas authored
place to prevent reusing relation OIDs before next checkpoint, and DROP DATABASE. First, if a database was dropped, bgwriter would still try to unlink the files that the rmtree() call by the DROP DATABASE command has already deleted, or is just about to delete. Second, if a database is dropped, and another database is created with the same OID, bgwriter would in the worst case delete a relation in the new database that happened to get the same OID as a dropped relation in the old database. To fix these race conditions: - make rmtree() ignore ENOENT errors. This fixes the 1st race condition. - make ForgetDatabaseFsyncRequests forget unlink requests as well. - force checkpoint on in dropdb on all platforms Since ForgetDatabaseFsyncRequests() is asynchronous, the 2nd change isn't enough on its own to fix the problem of dropping and creating a database with same OID, but forcing a checkpoint on DROP DATABASE makes it sufficient. Per Tom Lane's bug report and proposal. Backpatch to 8.3.
-
Tom Lane authored
of each plan node, instead of its former behavior of dumping the internal representation of the plan tree. The latter display is still available for those who really want it (see debug_print_plan), but uses for it are certainly few and and far between. Per discussion. This patch also removes the explain_pretty_print GUC, which is obsoleted by the change.
-
- 17 Apr, 2008 5 commits
-
-
Alvaro Herrera authored
versa) without going through DatumGetPointer. Gavin Sherry, with Feng Tian.
-
Tom Lane authored
we had several code paths where a physical tlist could be used for the input to a Sort node, which is a dumb idea because any unneeded table columns will increase the volume of data the sort has to push around. (Unfortunately the easy-looking fix of calling disuse_physical_tlist during make_sort_xxx doesn't work because in most cases we're already committed to the current input tlist --- it's been marked with sort column numbers, or we've built grouping column numbers using it, etc. The tlist has to be selected properly at the calling level before we start constructing sort-col information. This is easy enough to do, we were just failing to take the point into consideration.) Back-patch to 8.3. I believe the problem probably exists clear back to 7.4 when the physical tlist optimization was added, but I'm afraid to back-patch further than 8.3 without a great deal more study than I want to put into it. The code in this area has drifted a lot over time. The real-world importance of these code paths is uncertain anyway --- I think in many cases we'd probably prefer hash-based methods.
-
Bruce Momjian authored
> * -Allow administrators to safely terminate individual sessions
-
Bruce Momjian authored
needed.
-
Tom Lane authored
of each plan node. For the moment this is debug support only and is not enabled unless EXPLAIN_PRINT_TLISTS is defined at build time. Later I'll see about the idea of letting EXPLAIN VERBOSE do it.
-
- 16 Apr, 2008 9 commits
-
-
Tom Lane authored
corrupted. (Neither is very important if SIGTERM is used to shut down the whole database cluster together, but there's a problem if someone tries to SIGTERM individual backends.) To do this, introduce new infrastructure macros PG_ENSURE_ERROR_CLEANUP/PG_END_ENSURE_ERROR_CLEANUP that take care of transiently pushing an on_shmem_exit cleanup hook. Also use this method for createdb cleanup --- that wasn't a shared-memory-corruption problem, but SIGTERM abort of createdb could leave orphaned files lying around. Backpatch as far as 8.2. The shmem corruption cases don't exist in 8.1, and the createdb usage doesn't seem important enough to risk backpatching further.
-
Andrew Dunstan authored
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Tom Lane authored
it is trying to build a relcache entry for. This is an oversight in my 8.2 patch that tried to ensure we always took a lock on a relation before trying to build its relcache entry. The implication is that if someone committed a reindex of a critical system index at about the same time that some other backend were starting up without a valid pg_internal.init file, the second one might PANIC due to not seeing any valid version of the index's pg_class row. Improbable case, but definitely not impossible.
-
Bruce Momjian authored
Bryce Nesbitt
-
Bruce Momjian authored
-
Bruce Momjian authored
> * Implement the non-threaded Avahi service discovery protocol > http://archives.postgresql.org/pgsql-hackers/2008-02/msg00939.php > http://archives.postgresql.org/pgsql-patches/2008-02/msg00097.php > http://archives.postgresql.org/pgsql-hackers/2008-03/msg01211.php > http://archives.postgresql.org/pgsql-patches/2008-04/msg00001.php
-
Andrew Dunstan authored
-
- 15 Apr, 2008 9 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Andrew Dunstan authored
-
Bruce Momjian authored
< * Allow NOTIFY in rules involving conditionals > > o Allow NOTIFY in rules involving conditionals > o Improve LISTEN concurrency > > http://archives.postgresql.org/pgsql-hackers/2008-02/msg01106.php
-
Bruce Momjian authored
-
Bruce Momjian authored
> * Allow XML to accept more liberal DOCTYPE specifications > > http://archives.postgresql.org/pgsql-general/2008-02/msg00347.php
-
Bruce Momjian authored
> * -Allow administrators to safely terminate individual sessions either
-
Bruce Momjian authored
-
Andrew Dunstan authored
-
- 14 Apr, 2008 3 commits
-
-
Tom Lane authored
"consistent" functions, and remove pg_amop.opreqcheck, as per recent discussion. The main immediate benefit of this is that we no longer need 8.3's ugly hack of requiring @@@ rather than @@ to test weight-using tsquery searches on GIN indexes. In future it should be possible to optimize some other queries better than is done now, by detecting at runtime whether the index match is exact or not. Tom Lane, after an idea of Heikki's, and with some help from Teodor.
-
Alvaro Herrera authored
-
Bruce Momjian authored
* Consider automatic caching of statements at various levels: > http://archives.postgresql.org/pgsql-hackers/2008-04/msg00823.php
-
- 13 Apr, 2008 3 commits
-
-
Tom Lane authored
no particular need to do get_op_opfamily_properties() while building an indexscan plan. Postpone that lookup until executor start. This simplifies createplan.c a lot more than it complicates nodeIndexscan.c, and makes things more uniform since we already had to do it that way for RowCompare expressions. Should be a bit faster too, at least for plans that aren't re-used many times, since we avoid palloc'ing and perhaps copying the intermediate list data structure.
-
Tom Lane authored
instead of plan time. Extend the amgettuple API so that the index AM returns a boolean indicating whether the indexquals need to be rechecked, and make that rechecking happen in nodeIndexscan.c (currently the only place where it's expected to be needed; other callers of index_getnext are just erroring out for now). For the moment, GIN and GIST have stub logic that just always sets the recheck flag to TRUE --- I'm hoping to get Teodor to handle pushing that control down to the opclass consistent() functions. The planner no longer pays any attention to amopreqcheck, and that catalog column will go away in due course.
-
Tom Lane authored
the server version check is now always enforced. Relax the version check to allow a server that is of pg_dump's own major version but a later minor version; this is the only case that -i was at all safe to use in. pg_restore already enforced only a very weak version check, so this is really just a documentation change for it. Per discussion.
-
- 12 Apr, 2008 2 commits
-
-
Tom Lane authored
going through DatumGetPointer or some other "official" conversion macro. Not actually a bug, since Datum the same size as pointer is the only supported case at the moment, but good cleanup for the future. Gavin Sherry
-
Tom Lane authored
systable_endscan_ordered that have API similar to systable_beginscan etc (in particular, the passed-in scankeys have heap not index attnums), but guarantee ordered output, unlike the existing functions. For the moment these are just very thin wrappers around index_beginscan/index_getnext/etc. Someday they might need to get smarter; but for now this is just a code refactoring exercise to reduce the number of direct callers of index_getnext, in preparation for changing that function's API. In passing, remove index_getnext_indexitem, which has been dead code for quite some time, and will have even less use than that in the presence of run-time-lossy indexes.
-