- 10 Sep, 2008 1 commit
- 
- 
Tom Lane authored'syntax error' message, rather than something that might draw one's attention to a missing or wrong-type variable declaration. Per recent gripe. 
 
- 
- 09 Sep, 2008 2 commits
- 
- 
Tom Lane authoredwhen user-defined functions used in a plan are modified. Also invalidate plans when schemas, operators, or operator classes are modified; but for these cases we just invalidate everything rather than tracking exact dependencies, since these types of objects seldom change in a production database. Tom Lane; loosely based on a patch by Martin Pihlak. 
- 
Alvaro Herrera authoredVolkan YAZICI 
 
- 
- 08 Sep, 2008 4 commits
- 
- 
Tom Lane authoredfor pg_stop_backup. First, it is possible that the history file name is not alphabetically later than the last WAL file name, so we should explicitly check that both have been archived. Second, the previous coding would wait forever if a checkpoint had managed to remove the WAL file before we look for it. Simon Riggs, plus some code cleanup by me. 
- 
Tom Lane authoredreferenced tables are dumped before the referencing tables. This avoids failures when the data is loaded with the FK constraints already active. If no such ordering is possible because of circular or self-referential constraints, print a NOTICE to warn the user about it. 
- 
Tom Lane authoredalways owner-only. The TRUNCATE privilege works identically to the DELETE privilege so far as interactions with the rest of the system go. Robert Haas 
- 
Tom Lane authorednodes. This is a pretty ugly feature but since we don't yet have a plausible substitute, we'd better support it everywhere. Per gripe from Jeff Davis. 
 
- 
- 07 Sep, 2008 4 commits
- 
- 
Tom Lane authored
- 
Tom Lane authoredsearching instead of naive matching. In the worst case this has the same O(M*N) complexity as the naive method, but the worst case is hard to hit, and the average case is very fast, especially with longer patterns. David Rowley 
- 
Tom Lane authoredThis isn't exhaustive but it covers some of the more common layout mistakes I've seen in submitted patches. 
- 
Bruce Momjian authoredSimon Riggs 
 
- 
- 06 Sep, 2008 2 commits
- 
- 
Tom Lane authoredfor editing if no function name is specified. This seems a much cleaner way to offer that functionality than the original patch had. In passing, de-clutter the error displays that are given for a bogus function-name argument, and standardize on "$function$" as the default delimiter for the function body. (The original coding would use the shortest possible dollar-quote delimiter, which seems to create unnecessarily high risk of later conflicts with the user-modified function body.) 
- 
Tom Lane authoredIn support of that, create a backend function pg_get_functiondef(). The psql command is functional but maybe a bit rough around the edges... Abhijit Menon-Sen 
 
- 
- 05 Sep, 2008 7 commits
- 
- 
Bruce Momjian authored
- 
Tom Lane authoredinserting a materialize node above an inner-side sort node, when the sort is expected to spill to disk. (The materialize protects the sort from having to support mark/restore, allowing it to do its final merge pass on-the-fly.) We neglected to teach cost_mergejoin about that hack, so it was failing to include the materialize's costs in the estimated cost of the mergejoin. The materialize's costs are generally going to be pretty negligible in comparison to the sort's, so this is only a small error and probably not worth back-patching; but it's still wrong. In the similar case where a materialize is inserted to protect an inner-side node that can't do mark/restore at all, it's still true that the materialize should not spill to disk, and so we should cost it cheaply rather than expensively. Noted while thinking about a question from Tom Raney. 
- 
Peter Eisentraut authored
- 
Tom Lane authoredDavid Wheeler 
- 
Bruce Momjian authoredAdd missing descriptions for aggregates, functions and conversions. Bernd Helmle 
- 
Peter Eisentraut authoredchapter. Author: Michelle Caisse <Michelle.Caisse@Sun.COM> 
- 
Peter Eisentraut authored
 
- 
- 04 Sep, 2008 1 commit
- 
- 
Teodor Sigaev authoredto initializaion of scanEntry. 
 
- 
- 03 Sep, 2008 1 commit
- 
- 
Tom Lane authoredexactly what they are in the complaint message. Marko Kreen, some editorialization by me. 
 
- 
- 02 Sep, 2008 1 commit
- 
- 
Tom Lane authoredduring parsing. Formerly the parser's stack was allocated with malloc and so wouldn't be reclaimed; this patch makes it use palloc instead, so that flushing the current context will reclaim the memory. Per Marko Kreen. 
 
- 
- 01 Sep, 2008 6 commits
- 
- 
Tom Lane authoredwhenever possible, as per bug report from Oleg Serov. While at it, reorder the operations in the RECORD case to avoid possible palloc failure while the variable update is only partly complete. Back-patch as far as 8.1. Although the code of the particular function is similar in 8.0, 8.0's support for composite fields in rows is sufficiently broken elsewhere that it doesn't seem worth fixing this. 
- 
Tom Lane authored
- 
Tom Lane authoredoutput that is seen when a checkpoint occurs at just the right time during the test. Per my report of 2008-08-31. This could be back-patched but I'm not sure it's worth the trouble. 
- 
Tom Lane authoredThere are still some weak spots around JOIN USING and relation alias lists, but most errors reported within backend/parser/ now have locations. 
- 
Heikki Linnakangas authoredcommand id is the cmin, when it can in fact be a combo cid. That made rows incorrectly invisible to a transaction where a tuple was deleted by multiple aborted subtransactions. Report and patch Karl Schnaitter. Back-patch to 8.3, where combo cids was introduced. 
- 
Peter Eisentraut authoredsomewhat by adding CFLAGS where the compiler is used and Makefile.shlib already used CFLAGS. 
 
- 
- 30 Aug, 2008 2 commits
- 29 Aug, 2008 5 commits
- 
- 
Tom Lane authoredsyntax to avoid a useless store into a global variable. Per experimentation, this works better than my original thought of trying to push the code into an out-of-line subroutine. 
- 
Alvaro Herrera authoredDavid Gould 
- 
Tom Lane authoredclear to me why I'd not seen this message before --- on F-9 it seems to only happen if Asserts are disabled, which ought to be irrelevant. Maybe that affects a decision whether to inline get_ten(), which would be needed to expose the warning condition to the compiler? Anyway, the fix is clear. 
- 
Alvaro Herrera authored
- 
Peter Eisentraut authoredchange build system to use only Bison. Simplify build rules, make file names uniform. Don't build the token table header file where it is not needed. 
 
- 
- 28 Aug, 2008 1 commit
- 
- 
Tom Lane authoredmost node types used in expression trees (both before and after parse analysis). This allows us to place an error cursor in many situations where we formerly could not, because the information wasn't available beyond the very first level of parse analysis. There's a fair amount of work still to be done to persuade individual ereport() calls to actually include an error location, but this gets the initdb-forcing part of the work out of the way; and the situation is already markedly better than before for complaints about unimplementable implicit casts, such as CASE and UNION constructs with incompatible alternative data types. Per my proposal of a few days ago. 
 
- 
- 26 Aug, 2008 2 commits
- 
- 
Tom Lane authoredwhen its input is constant and the element coercion function is immutable (or nonexistent, ie, binary-coercible case). This is an oversight in the 8.3 implementation of ArrayCoerceExpr, and its result is that certain cases involving IN or NOT IN with constants don't get optimized as they should be. Per experimentation with an example from Ow Mun Heng. 
- 
Tom Lane authoredFix pg_dump docs to acknowledge that you can use -Z with plain text output. Pointed out by Daniel Migowski. 
 
- 
- 25 Aug, 2008 1 commit
- 
- 
Tom Lane authoredwarnings. Peter did this for core awhile ago but evidently missed contrib. 
 
-