1. 04 Dec, 2008 5 commits
  2. 03 Dec, 2008 6 commits
  3. 02 Dec, 2008 4 commits
  4. 01 Dec, 2008 9 commits
    • Tom Lane's avatar
      Fix an oversight in the code that makes transitive-equality deductions from · a1feb90e
      Tom Lane authored
      outer join clauses.  Given, say,
      	... from a left join b on a.a1 = b.b1 where a.a1 = 42;
      we'll deduce a clause b.b1 = 42 and then mark the original join clause
      redundant (we can't remove it completely for reasons I don't feel like
      squeezing into this log entry).  However the original implementation of
      that wasn't bulletproof, because clause_selectivity() wouldn't honor
      this_selec if given nonzero varRelid --- which in practice meant that
      it worked as desired *except* when considering index scan quals.  Which
      resulted in bogus underestimation of the size of the indexscan result for
      an inner indexscan in an outer join, and consequently a possibly bad
      choice of indexscan vs. bitmap scan.  Fix by introducing an explicit test
      into clause_selectivity().  Also, to make sure we don't trigger that test
      in corner cases, change the convention to be that this_selec > 1, not
      this_selec = 1, means it's been marked redundant.  Per trouble report from
      Scara Maccai.
      
      Back-patch to 8.2, where the problem was introduced.
      a1feb90e
    • Heikki Linnakangas's avatar
      Modify the new to_timestamp implementation so that end-of-format-string · 7fb27531
      Heikki Linnakangas authored
      is treated like a non-digit separator. This fixes the inconsistency in
      examples like:
      
      to_timestamp('2008-01-2', 'YYYY-MM-DD') -- didn't work
      
      and
      
      to_timestamp('2008-1-02', 'YYYY-MM-DD') -- did work
      7fb27531
    • Tom Lane's avatar
      Ensure that the contents of a holdable cursor don't depend on out-of-line · ec543db7
      Tom Lane authored
      toasted values, since those could get dropped once the cursor's transaction
      is over.  Per bug #4553 from Andrew Gierth.
      
      Back-patch as far as 8.1.  The bug actually exists back to 7.4 when holdable
      cursors were introduced, but this patch won't work before 8.1 without
      significant adjustments.  Given the lack of field complaints, it doesn't seem
      worth the work (and risk of introducing new bugs) to try to make a patch for
      the older branches.
      ec543db7
    • Tom Lane's avatar
      Remove the last traces of --temp-port. · 3191ab5d
      Tom Lane authored
      3191ab5d
    • Michael Meskes's avatar
      Removed port testing. · ac03efbb
      Michael Meskes authored
      ac03efbb
    • Peter Eisentraut's avatar
      Add braces to clarify syntax synopsis · 6355e69d
      Peter Eisentraut authored
      6355e69d
    • Peter Eisentraut's avatar
      Small correction · e3764aa1
      Peter Eisentraut authored
      e3764aa1
    • Peter Eisentraut's avatar
      typo · d653d47f
      Peter Eisentraut authored
      d653d47f
    • Tom Lane's avatar
      Refactor crosstab() to build and return a tuplestore instead of using · cf407f16
      Tom Lane authored
      value-per-call mode.  This should be more efficient in normal usage,
      but the real problem with the prior coding was that it returned with
      a SPI call still active.  That could cause problems if execution was
      interleaved with anything else that might use SPI.
      cf407f16
  5. 30 Nov, 2008 4 commits
    • Tom Lane's avatar
      Fix dblink and tablefunc to not return with the wrong CurrentMemoryContext. · 76cc2fe6
      Tom Lane authored
      Per buildfarm results.
      76cc2fe6
    • Tom Lane's avatar
      Clean up the API for DestReceiver objects by eliminating the assumption · c1f30733
      Tom Lane authored
      that a Portal is a useful and sufficient additional argument for
      CreateDestReceiver --- it just isn't, in most cases.  Instead formalize
      the approach of passing any needed parameters to the receiver separately.
      
      One unexpected benefit of this change is that we can declare typedef Portal
      in a less surprising location.
      
      This patch is just code rearrangement and doesn't change any functionality.
      I'll tackle the HOLD-cursor-vs-toast problem in a follow-on patch.
      c1f30733
    • Tom Lane's avatar
      Add a "LIKE = typename" clause to CREATE TYPE for base types. This allows · 3f936aac
      Tom Lane authored
      the basic representational details (typlen, typalign, typbyval, typstorage)
      to be copied from an existing type rather than listed explicitly in the
      CREATE TYPE command.  The immediate reason for this is to provide a simple
      solution for add-on modules that want to define types represented as int8,
      float4, or float8: as of 8.4 the appropriate PASSEDBYVALUE setting is
      platform-specific and so it's hard for a SQL script to know what to do.
      
      This patch fixes the contrib/isn breakage reported by Rushabh Lathia.
      3f936aac
    • Tom Lane's avatar
      Remove inappropriate memory context switch in shutdown_MultiFuncCall(). · 0ddede58
      Tom Lane authored
      This was a thinko introduced in a patch from last February; it results
      in memory leakage if an SRF is shut down before the actual end of query,
      because subsequent code will be running in a longer-lived context than
      it's expecting to be.
      0ddede58
  6. 29 Nov, 2008 2 commits
  7. 28 Nov, 2008 6 commits
  8. 27 Nov, 2008 4 commits