1. 24 May, 2012 3 commits
    • Tom Lane's avatar
      Fix array overrun in regex code. · 2a4c46e0
      Tom Lane authored
      zaptreesubs() was coded to unconditionally reset a capture subre's
      corresponding pmatch[] entry.  However, in regexes without backrefs, that
      array is caller-supplied and might not have as many entries as the regex
      has capturing parens.  So check the array length and do nothing if there
      is no corresponding entry, much as subset() does.  Failure to check this
      resulted in a stack clobber in the case reported by Marko Kreen.
      
      This bug appears to have been latent in the regex library from the
      beginning.  It was not exposed because find() called dissect() not
      cdissect(), and the dissect() code path didn't ever call zaptreesubs()
      (formerly zapmem()).  When I unified dissect() and cdissect() in commit
      4dd78bf3, the problem was exposed.
      
      Now that I've seen this, I'm rather suspicious that we might need to
      back-patch it; but will refrain for now, for lack of evidence that
      the case can be hit in the previous coding.
      2a4c46e0
    • Peter Eisentraut's avatar
      Update SQL key word list to SQL:2011 · ace397e9
      Peter Eisentraut authored
      For space reasons, drop SQL:1999 and SQL:2003.  Only keep the latest
      two and SQL-92 for historical comparison.
      ace397e9
    • Bruce Momjian's avatar
      Adjust pg_upgrade to output a separate log file for pg_ctl output on · 476291be
      Bruce Momjian authored
      Windows, to avoid opening a file by multiple processes.
      476291be
  2. 23 May, 2012 5 commits
  3. 22 May, 2012 12 commits
  4. 21 May, 2012 4 commits
  5. 19 May, 2012 5 commits
  6. 18 May, 2012 2 commits
    • Peter Eisentraut's avatar
    • Heikki Linnakangas's avatar
      Fix bug in gistRelocateBuildBuffersOnSplit(). · 1d27dcf5
      Heikki Linnakangas authored
      When we create a temporary copy of the old node buffer, in stack, we mustn't
      leak that into any of the long-lived data structures. Before this patch,
      when we called gistPopItupFromNodeBuffer(), it got added to the array of
      "loaded buffers". After gistRelocateBuildBuffersOnSplit() exits, the
      pointer added to the loaded buffers array points to garbage. Often that goes
      unnotied, because when we go through the array of loaded buffers to unload
      them, buffers with a NULL pageBuffer are ignored, which can often happen by
      accident even if the pointer points to garbage.
      
      This patch fixes that by marking the temporary copy in stack explicitly as
      temporary, and refrain from adding buffers marked as temporary to the array
      of loaded buffers.
      
      While we're at it, initialize nodeBuffer->pageBlocknum to InvalidBlockNumber
      and improve comments a bit. This isn't strictly necessary, but makes
      debugging easier.
      1d27dcf5
  7. 17 May, 2012 3 commits
  8. 16 May, 2012 3 commits
  9. 15 May, 2012 3 commits