1. 14 May, 2020 12 commits
  2. 13 May, 2020 5 commits
    • Alvaro Herrera's avatar
      Dial back -Wimplicit-fallthrough to level 3 · 17cc133f
      Alvaro Herrera authored
      The additional pain from level 4 is excessive for the gain.
      
      Also revert all the source annotation changes to their original
      wordings, to avoid back-patching pain.
      
      Discussion: https://postgr.es/m/31166.1589378554@sss.pgh.pa.us
      17cc133f
    • Tom Lane's avatar
      Improve management of SLRU statistics collection. · 81ca8686
      Tom Lane authored
      Instead of re-identifying which statistics bucket to use for a given
      SLRU on every counter increment, do it once during shmem initialization.
      This saves a fair number of cycles, and there's no real cost because
      we could not have a bucket assignment that varies over time or across
      backends anyway.
      
      Also, get rid of the ill-considered decision to let pgstat.c pry
      directly into SLRU's shared state; it's cleaner just to have slru.c
      pass the stats bucket number.
      
      In consequence of these changes, there's no longer any need to store
      an SLRU's LWLock tranche info in shared memory, so get rid of that,
      making this a net reduction in shmem consumption.  (That partly
      reverts fe702a7b.)
      
      This is basically code review for 28cac71b, so I also cleaned up
      some comments, removed a dangling extern declaration, fixed some
      things that should be static and/or const, etc.
      
      Discussion: https://postgr.es/m/3618.1589313035@sss.pgh.pa.us
      81ca8686
    • Alvaro Herrera's avatar
      Adjust walsender usage of xlogreader, simplify APIs · 850196b6
      Alvaro Herrera authored
      * Have both physical and logical walsender share a 'xlogreader' state
        struct for tracking state.  This replaces the existing globals sendSeg
        and sendCxt.
      
      * Change WALRead not to receive XLogReaderState->seg and ->segcxt as
        separate arguments anymore; just use the ones from 'state'.  This is
        made possible by the above change.
      
      * have the XLogReader segment_open contract require the callbacks to
        install the file descriptor in the state struct themselves instead of
        returning it.  xlogreader was already ignoring any possible failed
        return from the callbacks, relying solely on them never returning.
      
        (This point is not altogether excellent, as it means the callbacks
        have to know more of XLogReaderState; but to really improve on that
        we would have to pass back error info from the callbacks to
        xlogreader.  And the complexity would not be saved but instead just
        transferred to the callers of WALRead, which would have to learn how
        to throw errors from the open_segment callback in addition of, as
        currently, from pg_pread.)
      
      * segment_open no longer receives the 'segcxt' as a separate argument,
        since it's part of the XLogReaderState argument.
      
      Per comments from Kyotaro Horiguchi.
      
      Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
      Discussion: https://postgr.es/m/20200511203336.GA9913@alvherre.pgsql
      850196b6
    • Fujii Masao's avatar
      Use proper GetDatum function in pg_stat_get_slru(). · 043e3e04
      Fujii Masao authored
      This commit changes pg_stat_get_slru() so that it uses
      TimestampTzGetDatum() for stats_reset field because that field
      stores the timestamp with time zone value. Previously
      Int64GetDatum() was used.
      
      Author: Fujii Masao
      Reviewed-by: Tomas Vondra
      Discussion: https://postgr.es/m/b8784fe6-1401-ab35-aa14-d57b5bb8e312@oss.nttdata.com
      043e3e04
    • Fujii Masao's avatar
      Initialize SLRU stats entries to zero. · f3d23d83
      Fujii Masao authored
      Previously since SLRUStats was not initialized, SLRU stats counters
      could begin with non-zero value. Which could lead to incorrect results
      in pg_stat_slru view.
      
      Author: Fujii Masao
      Reviewed-by: Tomas Vondra
      Discussion: https://postgr.es/m/976bbb73-a112-de3c-c488-b34b64609793@oss.nttdata.com
      f3d23d83
  3. 12 May, 2020 14 commits
  4. 11 May, 2020 4 commits
    • Tom Lane's avatar
      Doc: fix "Unresolved ID reference" warnings, clean up man page cross-refs. · 60c90c16
      Tom Lane authored
      Use xreflabel attributes instead of endterm attributes to control the
      appearance of links to subsections of SQL command reference pages.
      This is simpler, it matches what we do elsewhere (e.g. for GUC variables),
      and it doesn't draw "Unresolved ID reference" warnings from the PDF
      toolchain.
      
      Fix some places where the text was absolutely dependent on an <xref>
      rendering exactly so, by using a <link> around the required text
      instead.  At least one of those spots had already been turned into
      bad grammar by subsequent changes, and the whole idea is just too
      fragile for my taste.  <xref> does NOT have fixed output, don't write
      as if it does.
      
      Consistently include a page-level link in cross-man-page references,
      because otherwise they are useless/nonsensical in man-page output.
      Likewise, be consistent about mentioning "below" or "above" in same-page
      references; we were doing that in about 90% of the cases, but now it's
      100%.
      
      Also get rid of another nonfunctional-in-PDF idea, of making
      cross-references to functions by sticking ID tags on <row> constructs.
      We can put the IDs on <indexterm>s instead --- which is probably not any
      more sensible in abstract terms, but it works where the other doesn't.
      (There is talk of attaching cross-reference IDs to most or all of
      the docs' function descriptions, but for now I just fixed the two
      that exist.)
      
      Discussion: https://postgr.es/m/14480.1589154358@sss.pgh.pa.us
      60c90c16
    • Peter Geoghegan's avatar
      Adjust "root of to-be-deleted subtree" function. · 624686ab
      Peter Geoghegan authored
      Restructure the function that locates the root of the to-be-deleted
      subtree during nbtree page deletion.  Handle the conditions that make
      page deletion unsafe in a slightly more uniform way, and acknowledge the
      fact that the behavior with incomplete splits on internal pages is
      different (as pointed out in the nbtree README as of commit 35bc0ec7).
      Also invent new terminology that avoids ambiguity around which pages are
      about to be deleted.  Consistently use the term "to-be-deleted subtree",
      not the ambiguous term "branch".
      
      We were calling the subtree parent page the "top parent page", but that
      was quite misleading.  The top parent page usually refers to a page
      unlinked from its siblings and marked deleted (during the second stage
      of page deletion).  There was one kind of top parent page that we merely
      removed a downlink from, and another kind of top parent page that we
      actually marked deleted.  Eliminate the ambiguity by inventing a new
      term ("subtree parent page") that refers to the former kind of page
      only.
      624686ab
    • Alvaro Herrera's avatar
      Fix obsolete references to "XLogRead" · a8be5364
      Alvaro Herrera authored
      The one in xlogreader.h was pointed out by Antonin Houska; I (Álvaro) noticed the
      others by grepping.
      
      Author: Antonin Houska <ah@cybertec.at>
      Discussion: https://postgr.es/m/28250.1589186654@antos
      a8be5364
    • Peter Eisentraut's avatar
      Translation updates · 7a9c9ce6
      Peter Eisentraut authored
      Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git
      Source-Git-Hash: 80d8f54b3c5533ec036404bd3c3b24ff4825d037
      7a9c9ce6
  5. 10 May, 2020 2 commits
    • Tom Lane's avatar
      Doc: marginal hacking to remove some PDF build warnings. · 336aa51b
      Tom Lane authored
      This patch eliminates a few more "exceed the available area" warnings
      whose causes aren't particularly connected to anything else.
      
      The only one really worthy of comment is that I increased the space
      allowed for an <orderedlist>'s numbers, because the default of 1em
      doesn't quite work for more than one digit.  The rest are one-off
      insertions of &zwsp; and suchlike tweaks, in places where they
      shouldn't do any damage to the material.  (In particular, although
      I split some long identifiers with zwsp's, there are other nearby
      occurrences of each one; so those changes shouldn't hurt greppability
      of the document sources.)
      336aa51b
    • Michael Paquier's avatar
      Remove smgrdounlink() in smgr.c from the code tree · e111c9f9
      Michael Paquier authored
      The last caller of this routine was removed in b4166911, and as a wise
      man said one day, dead code tends to silently break.
      
      Per discussion between Fujii Masao, Peter Geoghegan, Vignesh C and me.
      
      Reported-by: Peter Geoghegan
      Discussion: https://postgr.es/m/CAH2-Wz=sg5H8-vG4d5UmAofdcRMpeTDt2K-NUWp4GSfhenRGAQ@mail.gmail.com
      e111c9f9
  6. 09 May, 2020 3 commits