1. 08 Oct, 2012 7 commits
    • Tom Lane's avatar
      Code review for 64-bit-large-object patch. · 26fe5648
      Tom Lane authored
      Fix broken-on-bigendian-machines byte-swapping functions, add missed update
      of alternate regression expected file, improve error reporting, remove some
      unnecessary code, sync testlo64.c with current testlo.c (it seems to have
      been cloned from a very old copy of that), assorted cosmetic improvements.
      26fe5648
    • Alvaro Herrera's avatar
      Fix thinko in previous commit · 878daf2e
      Alvaro Herrera authored
      Since postgres.h includes palloc.h, definitions that affect the latter
      must be present before the former is included.
      
      Per buildfarm results
      878daf2e
    • Alvaro Herrera's avatar
      Add support for easily declaring static inline functions · 976fa10d
      Alvaro Herrera authored
      We already had those, but they forced modules to spell out the function
      bodies twice.  Eliminate some duplicates we had already grown.
      
      Extracted from a somewhat larger patch from Andres Freund.
      976fa10d
    • Robert Haas's avatar
      Add #define for UUIDOID. · 08c8058c
      Robert Haas authored
      Phil Sorber and Thom Brown. Reviewed by Albe Laurenz.
      08c8058c
    • Heikki Linnakangas's avatar
      b28cc92d
    • Heikki Linnakangas's avatar
      Fix walsender handling of postmaster shutdown, to not go into endless loop. · 9c0e2b91
      Heikki Linnakangas authored
      This bug was introduced by my patch to use the regular die/quickdie signal
      handlers in walsender processes. I tried to make walsender exit at next
      CHECK_FOR_INTERRUPTS() by setting ProcDiePending, but that's not enough, you
      need to set InterruptPending too. On second thoght, it was not a very good
      way to make walsender exit anyway, so use proc_exit(0) instead.
      
      Also, send a CommandComplete message before exiting; that's what we did
      before, and you get a nicer error message in the standby that way.
      
      Reported by Thom Brown.
      9c0e2b91
    • Tom Lane's avatar
      Autoconfiscate selection of 64-bit int type for 64-bit large object API. · 95d035e6
      Tom Lane authored
      Get rid of the fundamentally indefensible assumption that "long long int"
      exists and is exactly 64 bits wide on every platform Postgres runs on.
      Instead let the configure script select the type to use for "pg_int64".
      
      This is a bit of a pain in the rear since we do not want to pollute client
      namespace with all the random symbols that pg_config.h defines; instead
      we have to create a separate generated header file, "pg_config_ext.h".
      But now that the infrastructure is there, we might have the ability to
      add some other stuff that's long been wanting in this area.
      95d035e6
  2. 07 Oct, 2012 5 commits
  3. 06 Oct, 2012 2 commits
    • Tatsuo Ishii's avatar
      Add API for 64-bit large object access. Now users can access up to · 461ef73f
      Tatsuo Ishii authored
      4TB large objects (standard 8KB BLCKSZ case).  For this purpose new
      libpq API lo_lseek64, lo_tell64 and lo_truncate64 are added.  Also
      corresponding new backend functions lo_lseek64, lo_tell64 and
      lo_truncate64 are added. inv_api.c is changed to handle 64-bit
      offsets.
      
      Patch contributed by Nozomi Anzai (backend side) and Yugo Nagata
      (frontend side, docs, regression tests and example program). Reviewed
      by Kohei Kaigai. Committed by Tatsuo Ishii with minor editings.
      461ef73f
    • Peter Eisentraut's avatar
      Improve LDAP authentication documentation · ae835c7d
      Peter Eisentraut authored
      Use the terms "simple bind" and "search+bind" consistently do
      distinguish the two modes (better than first mode and second mode in
      any case).  They were already used in some places, now it's just more
      prominent.
      
      Split up the list of options into one for common options and one for
      each mode, for clarity.
      
      Add configuration examples for either mode.
      ae835c7d
  4. 05 Oct, 2012 6 commits
  5. 04 Oct, 2012 4 commits
    • Tom Lane's avatar
      Make CREATE AGGREGATE complain if the initcond is invalid for the datatype. · e1e60694
      Tom Lane authored
      The initial transition value is stored as a text string and not fed to the
      transition type's input function until runtime (so that values such as
      "now" don't get frozen at creation time).  Previously, CREATE AGGREGATE
      didn't do anything with it but that, which meant that even erroneous values
      would be accepted and not complained of until the aggregate is used.  This
      seems unhelpful, and it's confused at least one user, as in Rhys Stewart's
      recent report.  It seems worth taking a few more cycles to invoke the input
      function and verify that the value is acceptable.  We can't do this if the
      transition type is polymorphic, but in normal aggregates we know the actual
      transition type so we can call the right input function.
      e1e60694
    • Tom Lane's avatar
      Fix parse location tracking for lists that can be empty. · 70726354
      Tom Lane authored
      The previous coding of the YYLLOC_DEFAULT macro behaved strangely for empty
      productions, assigning the previous nonterminal's location as the parse
      location of the result.  The usefulness of that was (at best) debatable
      already, but the real problem is that in list-generating nonterminals like
      	OptFooList: /* EMPTY */ { ... } | OptFooList Foo { ... } ;
      the initially-identified location would get copied up, so that even a
      nonempty list would be given a bogus parse location.  Document how to work
      around that, and do so for OptSchemaEltList, so that the error condition
      just added for CREATE SCHEMA IF NOT EXISTS produces a sane error cursor.
      So far as I can tell, there are currently no other cases where the
      situation arises, so we don't need other instances of this coding yet.
      70726354
    • Tom Lane's avatar
      Fix permissions explanations in CREATE DATABASE and CREATE SCHEMA docs. · 7e389f73
      Tom Lane authored
      These reference pages still claimed that you have to be superuser to create
      a database or schema owned by a different role.  That was true before 8.1,
      but it was changed in commits aa111062 and
      f91370cd to allow assignment of ownership
      to any role you are a member of.  However, at the time we were thinking of
      that primarily as a change to the ALTER OWNER rules, so the need to touch
      these two CREATE ref pages got missed.
      7e389f73
    • Heikki Linnakangas's avatar
  6. 03 Oct, 2012 9 commits
    • Tom Lane's avatar
      Support CREATE SCHEMA IF NOT EXISTS. · fb34e94d
      Tom Lane authored
      Per discussion, schema-element subcommands are not allowed together with
      this option, since it's not very obvious what should happen to the element
      objects.
      
      Fabrízio de Royes Mello
      fb34e94d
    • Alvaro Herrera's avatar
      refactor ALTER some-obj SET OWNER implementation · 994c36e0
      Alvaro Herrera authored
      Remove duplicate implementation of catalog munging and miscellaneous
      privilege and consistency checks.  Instead rely on already existing data
      in objectaddress.c to do the work.
      
      Author: KaiGai Kohei
      Tweaked by me
      Reviewed by Robert Haas
      994c36e0
    • Tom Lane's avatar
      Avoid planner crash/Assert failure with joins to unflattened subqueries. · 1f91c8ca
      Tom Lane authored
      examine_simple_variable supposed that any RTE_SUBQUERY rel it gets pointed
      at must have been planned already.  However, this isn't a safe assumption
      because we must do selectivity estimation while generating indexscan paths,
      and that code might look at join clauses involving a rel that the loop in
      set_base_rel_sizes() hasn't reached yet.  The simplest fix is to play dumb
      in such a situation, that is give up trying to extract any stats for the
      Var.  This could possibly be improved by making a separate pass over the
      RTE list to plan each unflattened subquery before we start the main
      planning work --- but that would be pretty invasive and it doesn't seem
      worth it, for now at least.  (We couldn't just break set_base_rel_sizes()
      into two loops: the prescan would need to handle all subquery rels in the
      query, not only those in the current join subproblem.)
      
      This bug was introduced in commit 1cb108ef,
      although I think that subsequent changes may have exposed it more than it
      was originally.  Per bug #7580 from Maxim Boguk.
      1f91c8ca
    • Alvaro Herrera's avatar
      REASSIGN OWNED: consider grants on tablespaces, too · fe3b5eb0
      Alvaro Herrera authored
      Apparently this was considered in the original code (see commit
      cec3b0a9) but I failed to notice that such entries would always be
      skipped by the database check at the start of the loop.
      
      Per bugs #7578 by Nikolay, #6116 by tushar.qa@gmail.com.
      fe3b5eb0
    • Heikki Linnakangas's avatar
      Add --sampling-rate option to pgbench. · e1be1df5
      Heikki Linnakangas authored
      This allows logging only some fraction of transactions, greatly reducing
      the amount of log generated.
      
      Tomas Vondra, reviewed by Robert Haas and Jeff Janes.
      e1be1df5
    • Heikki Linnakangas's avatar
      Return the number of rows processed when COPY is executed through SPI. · 7ae18159
      Heikki Linnakangas authored
      You can now get the number of rows processed by a COPY statement in a
      PL/pgSQL function with "GET DIAGNOSTICS x = ROW_COUNT".
      
      Pavel Stehule, reviewed by Amit Kapila, with some editing by me.
      7ae18159
    • Heikki Linnakangas's avatar
      Fix two bugs introduced in the xlog.c split. · bc1229c8
      Heikki Linnakangas authored
      The comment explaining the naming of timeline history files was wrong, and
      the history file was not being arhived.
      
      Pointed out by Fujii Masao.
      bc1229c8
    • Peter Eisentraut's avatar
      6bd17609
    • Bruce Momjian's avatar
      In pg_upgrade, use full path name for analyze_new_cluster.sh script. · ce754579
      Bruce Momjian authored
      Backpatch to 9.2.
      ce754579
  7. 02 Oct, 2012 7 commits
    • Tom Lane's avatar
      Work around unportable behavior of malloc(0) and realloc(NULL, 0). · 09ac603c
      Tom Lane authored
      On some platforms these functions return NULL, rather than the more common
      practice of returning a pointer to a zero-sized block of memory.  Hack our
      various wrapper functions to hide the difference by substituting a size
      request of 1.  This is probably not so important for the callers, who
      should never touch the block anyway if they asked for size 0 --- but it's
      important for the wrapper functions themselves, which mistakenly treated
      the NULL result as an out-of-memory failure.  This broke at least pg_dump
      for the case of no user-defined aggregates, as per report from
      Matthew Carrington.
      
      Back-patch to 9.2 to fix the pg_dump issue.  Given the lack of previous
      complaints, it seems likely that there is no live bug in previous releases,
      even though some of these functions were in place before that.
      09ac603c
    • Alvaro Herrera's avatar
      Refactor "ALTER some-obj SET SCHEMA" implementation · 2164f9a1
      Alvaro Herrera authored
      Instead of having each object type implement the catalog munging
      independently, centralize knowledge about how to do it and expand the
      existing table in objectaddress.c with enough data about each object
      type to support this operation.
      
      Author: KaiGai Kohei
      Tweaks by me
      Reviewed by Robert Haas
      2164f9a1
    • Tom Lane's avatar
      Standardize naming of malloc/realloc/strdup wrapper functions. · a563d941
      Tom Lane authored
      We had a number of variants on the theme of "malloc or die", with the
      majority named like "pg_malloc", but by no means all.  Standardize on the
      names pg_malloc, pg_malloc0, pg_realloc, pg_strdup.  Get rid of pg_calloc
      entirely in favor of using pg_malloc0.
      
      This is an essentially cosmetic change, so no back-patch.  (I did find
      a couple of places where psql and pg_dump were using plain malloc or
      strdup instead of the pg_ versions, but they don't look significant
      enough to bother back-patching.)
      a563d941
    • Heikki Linnakangas's avatar
      Fix typo in previous warning-silencing patch. · 779f80b7
      Heikki Linnakangas authored
      Fujii Masao
      779f80b7
    • Bruce Momjian's avatar
      In pg_upgrade, improve error reporting when the number of relation · 8a759809
      Bruce Momjian authored
      objects does not match between the old and new clusters.
      
      Backpatch to 9.2.
      8a759809
    • Bruce Momjian's avatar
      Adjust pg_upgrade query so toast tables related to system catalog schema · ac96b851
      Bruce Momjian authored
      entries are not dumped.   This fixes an error caused by
      droping/recreating the information_schema, but other failures were also
      possible.
      
      Backpatch to 9.2.
      ac96b851
    • Bruce Momjian's avatar
      In pg_upgrade, try to convert the locale names to canonical form before · b61837a4
      Bruce Momjian authored
      comparison;  also report the old/new values if they don't match.
      
      Backpatch to 9.2.
      b61837a4