- 23 Aug, 2012 3 commits
-
-
Peter Eisentraut authored
-
Peter Eisentraut authored
Just to check that they actually work.
-
Tom Lane authored
As of 9.2, constraint exclusion should work okay with prepared statements: the planner will try custom plans with actual values of the parameters, and observe that they are a lot cheaper than the generic plan, and thus never fall back to using the generic plan. Noted by Tatsuhito Kasahara.
-
- 22 Aug, 2012 8 commits
-
-
Tom Lane authored
This is open to debate of course, but it's past time we had *something* here.
-
Tom Lane authored
A very large number of small improvements ...
-
Tom Lane authored
The docs claimed that this mode only waits for the standby to receive WAL data, but actually it waits for the data to be written out to the standby's OS; which is a pretty significant difference because it removes the risk of crash of the walreceiver process.
-
Bruce Momjian authored
-
Bruce Momjian authored
configuration file.
-
Peter Eisentraut authored
There was a hack put into install-sh to call strip with the correct options on Mac OS X. But that never worked, because configure disabled stripping on that platform altogether. So remove that dead code, and while we're at it, update install-sh to the latest upstream source (from Automake). Instead, set up the right strip options in programs.m4, so this now actually works the way it was originally intended.
-
Peter Eisentraut authored
This avoids a warning from clang 3.2 about an uninitialized variable 'dtype' in date_in().
-
Tom Lane authored
I was unable to entirely resist the temptation to copy-edit related entries, but will save most of that for a separate pass.
-
- 21 Aug, 2012 6 commits
-
-
Tom Lane authored
This improves on commit 51fed14d by eliminating the assumption that we can form <some pointer value> + <some offset> without overflow. The entire point of those tests is that we don't trust the offset value, so coding them in a way that could wrap around if the buffer happens to be near the top of memory doesn't seem sound. Instead, track the remaining space as a size_t variable and compare offsets against that. Also, improve comment about why we need the extra early check on xl_tot_len.
-
Tom Lane authored
If a view has circular dependencies, pg_dump splits it into a CREATE TABLE and a CREATE RULE command to break the dependency loop. However, if the view has reloptions, those options cannot be applied in the CREATE TABLE command, because views and tables have different allowed reloptions so CREATE TABLE would reject them. Instead apply the reloptions after the CREATE RULE, using ALTER VIEW SET.
-
Robert Haas authored
Move discussion of why our algorithm for taking snapshots in recovery to a more appropriate location in the function, and delete incorrect mention of taking a lock.
-
Robert Haas authored
Craig Ringer, slightly edited by me.
-
Peter Eisentraut authored
When elevel >= ERROR, we add an abort() call to the ereport() macro to give the compiler a hint that the ereport() expansion will not return, but the abort() isn't actually reached because the longjmp happens in errfinish(). Because the effect of ereport() varies with the elevel, we cannot use standard compiler attributes such as noreturn for this.
-
Peter Eisentraut authored
-
- 20 Aug, 2012 5 commits
-
-
Robert Haas authored
Jeff Janes
-
Robert Haas authored
Jeff Janes
-
Tom Lane authored
Extraction of trigrams did not process LIKE escape sequences properly, leading to possible misidentification of trigrams near escapes, resulting in incorrect index search results. Fujii Masao
-
Heikki Linnakangas authored
If a WAL record header was split across pages, but xl_tot_len was 0, we would get confused and conclude that we had already read the whole record, and proceed to CRC check it. That can lead to a crash in RecordIsValid(), which isn't careful to not read beyond end-of-record, as defined by xl_tot_len. Add an explicit sanity check for xl_tot_len <= SizeOfXlogRecord. Also, make RecordIsValid() more robust by checking in each step that it doesn't try to access memory beyond end of record, even if a length field in the record's or a backup block's header is bogus. Per report and analysis by Tom Lane.
-
Tom Lane authored
-
- 19 Aug, 2012 2 commits
- 18 Aug, 2012 2 commits
-
-
Tom Lane authored
It said "XXX: The following could be improved if we had LATERAL" ... so let's do that. No catversion bump since either version of the view works fine.
-
Tom Lane authored
Formerly, subquery pullup had no need to examine other entries in the range table, since they could not contain any references to the subquery being pulled up. That's no longer true with LATERAL, so now we need to be able to visit rangetable subexpressions to replace Vars referencing the pulled-up subquery. Also, this means that extract_lateral_references must be unsurprised at encountering lateral PlaceHolderVars, since such might be created when pulling up a subquery that's underneath an outer join with respect to the lateral reference.
-
- 17 Aug, 2012 3 commits
-
-
Tom Lane authored
Fix grammar, put back some removed information, rearrange for clarity.
-
Tom Lane authored
We had put a test for libxml2's xmlStructuredErrorContext variable in configure, but of course that doesn't work on Windows builds. The next best alternative seems to be to test the LIBXML_VERSION symbol provided by xmlversion.h. Per report from Talha Bin Rizwan, though this fixes it in a different way than his proposed patch.
-
Bruce Momjian authored
from Dmitriy Igrishin
-
- 16 Aug, 2012 11 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Tom Lane authored
In the initial cut at the "parameterized paths" feature, I'd simplified create_index_paths() to the point where it would only generate a single parameterized bitmap path per relation. Experimentation with an example supplied by Josh Berkus convinces me that that's not good enough: we really need to consider a bitmap path for each possible outer relation. Otherwise we have regressions relative to pre-9.2 versions, in which the planner picks a plain indexscan where it should have used a bitmap scan in queries involving three or more tables. Indeed, after fixing this, several queries in the regression tests show improved plans as a result of using bitmap not plain indexscans.
-
Tom Lane authored
-
Bruce Momjian authored
-
Bruce Momjian authored
the partition.
-
Bruce Momjian authored
"unimportant". Per request from Heikki
-
Bruce Momjian authored
keywords and concepts, based on suggestions by Florian Pflug.
-
Bruce Momjian authored
-