- 28 Aug, 2012 14 commits
-
-
Alvaro Herrera authored
The heapam XLog functions are used by other modules, not all of which are interested in the rest of the heapam API. With this, we let them get just the XLog stuff in which they are interested and not pollute them with unrelated includes. Also, since heapam.h no longer requires xlog.h, many files that do include heapam.h no longer get xlog.h automatically, including a few headers. This is useful because heapam.h is getting pulled in by execnodes.h, which is in turn included by a lot of files.
-
Alvaro Herrera authored
Instead, place a forward struct declaration for struct catclist in syscache.h. This reduces header proliferation somewhat.
-
Alvaro Herrera authored
This lets files that are mere users of ResourceOwner not automatically include the headers for stuff that is managed by the resowner mechanism.
-
Alvaro Herrera authored
-
Tom Lane authored
Per Peter Geoghegan.
-
Tom Lane authored
Since we're not installing this file anymore, it has no reason to exist, other than as historical reference; but we have an SCM for that.
-
Bruce Momjian authored
percentage column before count column. Docs updated.
-
Bruce Momjian authored
has no space before it. Report by Erik Rijkers
-
Bruce Momjian authored
Lane's correction.
-
Alvaro Herrera authored
-
Peter Eisentraut authored
-
Bruce Momjian authored
David E. Wheeler
-
Tom Lane authored
Clarify the compatibility notes about EXTRACT() and about statistics timing columns.
-
Tom Lane authored
This is so that these sections will have stable HTML tags that one can link to, rather than things like "AEN1902". Perhaps we should mount a campaign to do this everywhere, but I've found myself pointing at syntax.sgml subsections often enough to be sure it's useful here.
-
- 27 Aug, 2012 10 commits
-
-
Bruce Momjian authored
pg_restore.
-
Alvaro Herrera authored
The previous signature made it very easy to pass something other than the printf-format specifier in the corresponding position, without any warning from the compiler. While at it, move some of the escaping, redirecting and quoting responsibilities from the callers into exec_prog() itself. This makes the callsites cleaner.
-
Alvaro Herrera authored
It was confusing symlinks with hard links.
-
Alvaro Herrera authored
-
Bruce Momjian authored
has been created by adding #include <stdlib.h> to parse.c. per request from Kevin Grittner.
-
Heikki Linnakangas authored
This enables selectivity estimation of the <<, >>, &<, &> and && operators, as well as the normal inequality operators: <, <=, >=, >. "range @> element" is also supported, but the range-variant @> and <@ operators are not, because they cannot be sensibly estimated with lower and upper bound histograms alone. We would need to make some assumption about the lengths of the ranges for that. Alexander's patch included a separate histogram of lengths for that, but I left that out of the patch for simplicity. Hopefully that will be added as a followup patch. The fraction of empty ranges is also calculated and used in estimation. Alexander Korotkov, heavily modified by me.
-
Peter Eisentraut authored
It still thought that the --xlog-method option argument could be empty, as in a previous version of this feature.
-
Bruce Momjian authored
Brad Davis
-
Tom Lane authored
This patch takes care of a number of problems having to do with failure to choose valid join orders and incorrect handling of lateral references pulled up from subqueries. Notable changes: * Add a LateralJoinInfo data structure similar to SpecialJoinInfo, to represent join ordering constraints created by lateral references. (I first considered extending the SpecialJoinInfo structure, but the semantics are different enough that a separate data structure seems better.) Extend join_is_legal() and related functions to prevent trying to form unworkable joins, and to ensure that we will consider joins that satisfy lateral references even if the joins would be clauseless. * Fill in the infrastructure needed for the last few types of relation scan paths to support parameterization. We'd have wanted this eventually anyway, but it is necessary now because a relation that gets pulled up out of a UNION ALL subquery may acquire a reltargetlist containing lateral references, meaning that its paths *have* to be parameterized whether or not we have any code that can push join quals down into the scan. * Compute data about lateral references early in query_planner(), and save in RelOptInfo nodes, to avoid repetitive calculations later. * Assorted corner-case bug fixes. There's probably still some bugs left, but this is a lot closer to being real than it was before.
-
- 26 Aug, 2012 2 commits
-
-
Bruce Momjian authored
for CREATE TABLE LIKE ... INCLUDING INDEXES. Per report from david.sahagian@emc.com
-
Bruce Momjian authored
-
- 25 Aug, 2012 4 commits
-
-
Bruce Momjian authored
the same as \copy.
-
Bruce Momjian authored
ISO "T" timestamptz format.
-
Peter Eisentraut authored
-
Peter Eisentraut authored
-
- 24 Aug, 2012 3 commits
-
-
Tom Lane authored
The GUC check hooks for transaction_read_only and transaction_isolation tried to check RecoveryInProgress(), so as to disallow setting read/write mode or serializable isolation level (respectively) in hot standby sessions. However, GUC check hooks can be called in many situations where we're not connected to shared memory at all, resulting in a crash in RecoveryInProgress(). Among other cases, this results in EXEC_BACKEND builds crashing during child process start if default_transaction_isolation is serializable, as reported by Heikki Linnakangas. Protect those calls by silently allowing any setting when not inside a transaction; which is okay anyway since these GUCs are always reset at start of transaction. Also, add a check to GetSerializableTransactionSnapshot() to complain if we are in hot standby. We need that check despite the one in check_XactIsoLevel() because default_transaction_isolation could be serializable. We don't want to complain any sooner than this in such cases, since that would prevent running transactions at all in such a state; but a transaction can be run, if SET TRANSACTION ISOLATION is done before setting a snapshot. Per report some months ago from Robert Haas. Back-patch to 9.1, since these problems were introduced by the SSI patch. Kevin Grittner and Tom Lane, with ideas from Heikki Linnakangas
-
Peter Eisentraut authored
-
Peter Eisentraut authored
When an invalid query parameter is reported, some memory leaks. found by Coverity
-
- 23 Aug, 2012 5 commits
-
-
Tom Lane authored
If we revoke a grant option from some role X, but X still holds the option via another grant, we should not recursively revoke the privilege from role(s) Y that X had granted it to. This was supposedly fixed as one aspect of commit 4b2dafcc, but I must not have tested it, because in fact that code never worked: it forgot to shift the grant-option bits back over when masking the bits being revoked. Per bug #6728 from Daniel German. Back-patch to all active branches, since this has been wrong since 8.0.
-
Heikki Linnakangas authored
-
Peter Eisentraut authored
-
Peter Eisentraut authored
Just to check that they actually work.
-
Tom Lane authored
As of 9.2, constraint exclusion should work okay with prepared statements: the planner will try custom plans with actual values of the parameters, and observe that they are a lot cheaper than the generic plan, and thus never fall back to using the generic plan. Noted by Tatsuhito Kasahara.
-
- 22 Aug, 2012 2 commits