- 04 Jun, 2009 3 commits
-
-
Tom Lane authored
Seems silly to ask translators to expend work on these, especially in pluralized variants.
-
Tom Lane authored
by extending the ereport() API to cater for pluralization directly. This is better than the original method of calling ngettext outside the elog.c code because (1) it avoids double translation, which wastes cycles and in the worst case could give a wrong result; and (2) it avoids having to use a different coding method in PL code than in the core backend. The client-side uses of ngettext are not touched since neither of these concerns is very pressing in the client environment. Per my proposal of yesterday.
-
Andrew Dunstan authored
-
- 03 Jun, 2009 7 commits
-
-
Bruce Momjian authored
-
Tom Lane authored
__attribute__() marker so that gcc can validate the format string against the actual arguments, get rid of overcomplicated and unsafe usage in base_yyerror().
-
Tom Lane authored
Tatsuo Ishii.
-
Tom Lane authored
cosmetic --- I'm wondering if geteuid could have side effects on errno, thus possibly resulting in a misleading error message after failure of getpwuid.
-
Tom Lane authored
-
Bruce Momjian authored
-
Bruce Momjian authored
-
- 02 Jun, 2009 3 commits
-
-
Tom Lane authored
instead just pointing out that a larger value may trigger use of GEQO. Per Robert Haas. In passing, do a bit of wordsmithing on the Genetic Query Optimizer section.
-
Heikki Linnakangas authored
symbolic links with the -l option, and as Fujii Masao pointed out we ended up overwriting files in the archive directory before this patch. Patch by Aidan Van Dyk, Fujii Masao and me. Backpatch to 8.3, where pg_standby was introduced.
-
Joe Conway authored
while we're at it per request by Tom Lane. Specifically, don't try to perform dblink_send_query() via dblink_record_internal() -- it was inappropriate and ugly.
-
- 01 Jun, 2009 2 commits
-
-
Tom Lane authored
grounds that they don't fit into the specified interval qualifier (typmod). This behavior, while of long standing, is clearly wrong per spec --- for example the value INTERVAL '999' SECOND means 999 seconds and should not be reduced to less than 60 seconds. In some cases there could be grounds to raise an error if higher-order field values are not given as zero; for example '1 year 1 month'::INTERVAL MONTH should arguably be taken as an error rather than equivalent to 13 months. However our internal representation doesn't allow us to do that in a fashion that would consistently reject all and only the cases that a strict reading of the spec would suggest. Also, seeing that for example INTERVAL '13' MONTH will print out as '1 year 1 mon', we have to be careful not to create a situation where valid data will fail to dump and reload. The present patch therefore takes the attitude of not throwing an error in any such case. We might want to revisit that in future but it would take more redesign than seems prudent in late beta. Per a complaint from Sebastien Flaesch and subsequent discussion. While at other times we might have just postponed such an issue to the next development cycle, 8.4 already has changed the parsing of interval literals quite a bit in an effort to accept all spec-compliant cases correctly. This seems like a change that should be part of that rather than coming along later.
-
Tom Lane authored
YEAR, DECADE, CENTURY, or MILLENIUM fields, just as it always has done for other types of fields. The previous behavior seems to have been a hack to avoid defining bit-positions for all these field types in DTK_M() masks, rather than something that was really considered to be desired behavior. But there is room in the masks for these, and we really need to tighten up at least the behavior of DAY and YEAR fields to avoid unexpected behavior associated with the 8.4 changes to interpret ambiguous fields based on the interval qualifier (typmod) value. Per my example and proposed patch.
-
- 31 May, 2009 1 commit
-
-
Tom Lane authored
queries frequently took no lock at all on individual indexes. That's not true any more, but we still need lock on the parent table to make it safe to use cached lists of index OIDs.
-
- 29 May, 2009 1 commit
-
-
Michael Meskes authored
-
- 28 May, 2009 2 commits
-
-
Bruce Momjian authored
advised.
-
Heikki Linnakangas authored
all transactions are archived. Original patch by Guillaume Smet.
-
- 27 May, 2009 8 commits
-
-
Tom Lane authored
default usernames versus Kerberos tickets. Per confusion about what bug #4824 was really about.
-
Magnus Hagander authored
this, the username was in practice never matched against the kerberos principal used to log in.
-
Peter Eisentraut authored
Zdenek Kotala
-
Tom Lane authored
throwing an error as 8.4 had been doing. The error interfered with porting old database definitions (particularly for pg_migrator) without really buying any safety. Per bug #4817 and subsequent discussion.
-
Peter Eisentraut authored
"tsquery_op.c", line 193: warning: syntax error: empty declaration Zdenek Kotala
-
Michael Meskes authored
-
Bruce Momjian authored
-
Tom Lane authored
visibility effects in a couple of places where people are likely to look for it. Per discussion of recent question from Karl Nack.
-
- 26 May, 2009 4 commits
-
-
Tom Lane authored
an expression that's not supposed to contain variables. Per discussion with Gevik Babakhani, this eliminates the need for an ugly kluge (namely, specifying some unrelated relation name). Remove one such kluge from pg_dump.
-
Tom Lane authored
EncodeTimeOnly, EncodeDateTime, EncodeInterval. These don't have any good reason to fail, and their callers were mostly not checking anyway.
-
Tom Lane authored
-
Tom Lane authored
of time values that would not be accepted via textual input. Per gripe from Andrew McNamara. This is potentially a back-patchable bug fix, but for the moment it doesn't seem sufficiently high impact to justify doing that.
-
- 24 May, 2009 2 commits
-
-
Tom Lane authored
relopt_kind value in add_reloption_kind(). Per Zdenek Kotala.
-
Tom Lane authored
this case is worth a special code path, but a special code path that gets the boundary condition wrong is definitely no good. Per bug #4821 from Andrew Gierth. In passing, clean up some minor code formatting issues (excess parentheses and blank lines in odd places). Back-patch to 8.3, where the bug was introduced.
-
- 21 May, 2009 3 commits
-
-
Teodor Sigaev authored
Basically, it's needed to support binary dump from 8.3 because ordering rule was changed. Per discussion with Bruce.
-
Michael Meskes authored
-
Peter Eisentraut authored
Author: Euler Taveira de Oliveira <euler@timbira.com>
-
- 20 May, 2009 4 commits
-
-
Peter Eisentraut authored
-
Michael Meskes authored
-
Michael Meskes authored
-
Michael Meskes authored
-