Skip to content

P
Postgres FD Implementation
Switch branch/tag
  1. 03 Jun, 2019 2 commits
  3. 02 Jun, 2019 5 commits
    • Tom Lane's avatar
      Make cpluspluscheck more portable. · f4755a2c
      Tom Lane authored 
      Teach it to scrape -I and -D switches from CPPFLAGS in Makefile.global.
This is useful for testing on, eg, FreeBSD, where you won't get far
without "-I/usr/local/include".

Also, expand the set of blacklisted-for-unportability atomics headers,
based on noting that arch-x86.h fails to compile on an ARM box.  The
other ones I'd omitted seem to compile all right on architectures they
don't belong to, but that's surely too shaky to rely on.  Let's do
like we did for the src/include/port/ headers, and ignore all except
the variant that's pulled in by the arch-independent header.
      f4755a2c
    • Tom Lane's avatar
      Clean up PL/Perl's handling of the _() macro. · 032627ee
      Tom Lane authored 
      Perl likes to redefine the _() macro:

#ifdef CAN_PROTOTYPE
#define	_(args) args
#else ...

There was lots not to like about the way we dealt with this before:

1. Instead of taking care of the conflict centrally in plperl.h, we
expected every one of its ever-growing number of includers to do so.
This is duplicative and error-prone in itself, plus it means that
plperl.h fails to meet the expectation of being compilable standalone,
resulting in macro-redefinition warnings in cpluspluscheck.

2. We left _() with its Perl definition, meaning that if someone tried
to use it in any Perl-related extension, it would silently fail to
provide run-time translation.  I don't see any live bugs of this ilk,
but it's clearly a hard-to-notice bug waiting to happen.

So fix that by centralizing the cleanup logic, making it match what
we're already doing for other macro conflicts with Perl.  Since we only
expect plperl.h to be included by extensions not core code, we should
redefine _() as dgettext() not gettext().
      032627ee
    • Tom Lane's avatar
      worker_spi needs a .gitignore file now. · 135063e6
      Tom Lane authored
      135063e6
    • Tom Lane's avatar
      Un-break ecpg tests for Windows. · 10a53cae
      Tom Lane authored 
      Declaring a function "inline" still doesn't work with Windows compilers
(C99? what's that?), unless the macro provided by pg_config.h is
in-scope, which it is not in our ECPG test programs.  So the workaround
I tried to use in commit 7640f931 doesn't work for Windows.  Revert
the change in printf_hack.h, and instead just blacklist that file
in cpluspluscheck --- since it's a not-installed test file, we don't
really need to verify its C++ cleanliness anyway.
      10a53cae
    • Alvaro Herrera's avatar
      Increase test coverage for worker_spi by ∞% · 4b3f1dd7
      Alvaro Herrera authored 
      This test module was not getting invoked, other than at compile time,
limiting its usefulness -- and keeping its coverage at 0%.  Add a
minimal regression test to ensure it runs on make check-world; this
makes it 92% covered (line-wise), which seems sufficient.

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: default avatarTom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20190529193256.GA17603@alvherre.pgsql
      4b3f1dd7
  5. 01 Jun, 2019 1 commit
  7. 31 May, 2019 9 commits
  9. 30 May, 2019 3 commits
  11. 29 May, 2019 3 commits
  13. 28 May, 2019 7 commits
  15. 27 May, 2019 1 commit
  17. 26 May, 2019 4 commits
  19. 25 May, 2019 1 commit
  21. 24 May, 2019 3 commits
  23. 23 May, 2019 1 commit
    • Andres Freund's avatar
      tableam: Rename wrapper functions to match callback names. · 73b8c3bd
      Andres Freund authored 
      Some of the wrapper functions didn't match the callback names. Many of
them due to staying "consistent" with historic naming of the wrapped
functionality. We decided that for most cases it's more important to
be for tableam to be consistent going forward, than with the past.

The one exception is beginscan/endscan/...  because it'd have looked
odd to have systable_beginscan/endscan/... with a different naming
scheme, and changing the systable_* APIs would have caused way too
much churn (including breaking a lot of external users).

Author: Ashwin Agrawal, with some small additions by Andres Freund
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/CALfoeiugyrXZfX7n0ORCa4L-m834dzmaE8eFdbNR6PMpetU4Ww@mail.gmail.com
      73b8c3bd