- 07 Feb, 2010 2 commits
-
-
Tom Lane authored
platforms. Per buildfarm.
-
Tom Lane authored
of shared or nailed system catalogs. This has two key benefits: * The new CLUSTER-based VACUUM FULL can be applied safely to all catalogs. * We no longer have to use an unsafe reindex-in-place approach for reindexing shared catalogs. CLUSTER on nailed catalogs now works too, although I left it disabled on shared catalogs because the resulting pg_index.indisclustered update would only be visible in one database. Since reindexing shared system catalogs is now fully transactional and crash-safe, the former special cases in REINDEX behavior have been removed; shared catalogs are treated the same as non-shared. This commit does not do anything about the recently-discussed problem of deadlocks between VACUUM FULL/CLUSTER on a system catalog and other concurrent queries; will address that in a separate patch. As a stopgap, parallel_schedule has been tweaked to run vacuum.sql by itself, to avoid such failures during the regression tests.
-
- 06 Feb, 2010 1 commit
-
-
Tom Lane authored
-
- 05 Feb, 2010 12 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
checkpoint has happened, and recommend adjusting checkpoint_timeout to reduce the impact of this.
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Bruce Momjian authored
Alexey Klyukin
-
Bruce Momjian authored
-
Bruce Momjian authored
author's permission.
-
Bruce Momjian authored
Nathan Wagner Function is simpler too.
-
Joe Conway authored
If expand_dbname is non-zero and dbname contains an = sign, it is taken as a conninfo string in exactly the same way as if it had been passed to PQconnectdb. This is equivalent to the way PQsetdbLogin() works, allowing PQconnectdbParams() to be a complete alternative. Also improve the way the new function is called from psql and replace a previously missed call to PQsetdbLogin() in psql. Additionally use PQconnectdbParams() for pg_dump and friends, and the bin/scripts command line utilities such as vacuumdb, createdb, etc. Finally, update the documentation for the new parameter, as well as the nuances of precedence in cases where key words are repeated or duplicated in the conninfo string.
-
Bruce Momjian authored
-
- 04 Feb, 2010 4 commits
-
-
Michael Meskes authored
-
Michael Meskes authored
Streamlined array handling code in libecpg a little bit, in the process fixing yet another incorrect log output.
-
Tom Lane authored
-
Tom Lane authored
of old and new toast tables can be done either at the logical level (by swapping the heaps' reltoastrelid links) or at the physical level (by swapping the relfilenodes of the toast tables and their indexes). This is necessary infrastructure for upcoming changes to support CLUSTER/VAC FULL on shared system catalogs, where we cannot change reltoastrelid. The physical swap saves a few catalog updates too. We unfortunately have to keep the logical-level swap logic because in some cases we will be adding or deleting a toast table, so there's no possibility of a physical swap. However, that only happens as a consequence of schema changes in the table, which we do not need to support for system catalogs, so such cases aren't an obstacle for that. In passing, refactor the cluster support functions a little bit to eliminate unnecessarily-duplicated code; and fix the problem that while CLUSTER had been taught to rename the final toast table at need, ALTER TABLE had not.
-
- 03 Feb, 2010 10 commits
-
-
Joe Conway authored
exceed the total number of non-dropped source table fields for dblink_build_sql_*(). Addresses bug report from Rushabh Lathia. Backpatch all the way to the 7.3 branch.
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Michael Meskes authored
Fixed some typos in ECPG regression test suite that resulted in regression test failures on some architectures. By Zoltán Böszörményi.
-
Heikki Linnakangas authored
heap_sync() to the callers, because heap_sync() is sometimes called even if the operation itself is WAL-logged. This eliminates the bogus unlogged records from CLUSTER that Simon Riggs reported, patch by Fujii Masao.
-
Heikki Linnakangas authored
to standby in streaming replication. While we only have one message type at the moment, adding a message type header makes this easier to extend.
-
Tom Lane authored
for the lifespan of the CreateStmt. Per buildfarm member jaguar.
-
Tom Lane authored
machines are all rejecting isinf() calls in this file.
-
Tom Lane authored
DROP USER at the end of the cluster.sql test could fail, if the temp table created in the previous session hadn't finished getting dropped. Unluckily, I didn't see this in several repetitions of the parallel regression tests, but it's popping up on quite a few buildfarm machines.
-
Tom Lane authored
the relfilenode of currently-not-relocatable system catalogs. 1. Get rid of inval.c's dependency on relfilenode, by not having it emit smgr invalidations as a result of relcache flushes. Instead, smgr sinval messages are sent directly from smgr.c when an actual relation delete or truncate is done. This makes considerably more structural sense and allows elimination of a large number of useless smgr inval messages that were formerly sent even in cases where nothing was changing at the physical-relation level. Note that this reintroduces the concept of nontransactional inval messages, but that's okay --- because the messages are sent by smgr.c, they will be sent in Hot Standby slaves, just from a lower logical level than before. 2. Move setNewRelfilenode out of catalog/index.c, where it never logically belonged, into relcache.c; which is a somewhat debatable choice as well but better than before. (I considered catalog/storage.c, but that seemed too low level.) Rename to RelationSetNewRelfilenode. 3. Cosmetic cleanups of some other relfilenode manipulations.
-
- 02 Feb, 2010 7 commits
-
-
Tom Lane authored
OIDs, avoid random line breaks in strings somebody might grep for.
-
Tom Lane authored
relations (they don't live in pg_toast). This caused an Assert failure in assert-enabled builds. So far as I can see, in a non-assert build it would only have messed up the checks for conflicting names, so a failure would be quite improbable but perhaps not impossible.
-
Magnus Hagander authored
the server. Gets rid of a fairly ugly hack for Solaris, and also provides hostname and IPV6 support.
-
Robert Haas authored
All callers of FindConversionByName() already do suitable permissions checking already apart from this function, but this is not just dead code removal: the unnecessary permissions check can actually lead to spurious failures - there's no reason why inability to execute the underlying function should prohibit renaming the conversion, for example. (The error messages in these cases were also rather poor: FindConversion would return InvalidOid, eventually leading to a complaint that the conversion "did not exist", which was not correct.) KaiGai Kohei
-
Bruce Momjian authored
Backpatch to 8.4.X.
-
Tom Lane authored
prone to sort differently in different locales, as seen in buildfarm results. Let's cast to name not text to avoid that.
-
Michael Meskes authored
Patch done by Zoltán Böszörményi.
-
- 01 Feb, 2010 4 commits
-
-
Robert Haas authored
When a column is renamed, we recursively rename the same column in all descendent tables. But if one of those tables also inherits that column from a table outside the inheritance hierarchy rooted at the named table, we must throw an error. The previous coding correctly prohibited the rename when the parent had inherited the column from elsewhere, but overlooked the case where the parent was OK but a child table also inherited the same column from a second, unrelated parent. For now, not backpatched due to lack of complaints from the field. KaiGai Kohei, with further changes by me. Reviewed by Bernd Helme and Tom Lane.
-
Bruce Momjian authored
-
Robert Haas authored
We show the number of buckets, the number of batches (and also the original number if it has changed), and the peak space used by the hash table. Minor executor changes to track peak space used.
-
Robert Haas authored
-