1. 03 Jul, 2015 4 commits
    • Heikki Linnakangas's avatar
      Remove thread-emulation support from pgbench. · 1bc90f7a
      Heikki Linnakangas authored
      You can no longer use pgbench with multiple threads when compiled without
      --enable-thread-safety. That's an acceptable limitation these days; it
      still works fine with -j1, and all modern platforms support threads anyway.
      This makes future maintenance and development of the code easier.
      
      Fabien Coelho
      1bc90f7a
    • Heikki Linnakangas's avatar
      Fix pgbench progress report behaviour when pgbench or a query gets stuck. · 9031ff91
      Heikki Linnakangas authored
      There were two issues here. First, if a query got stuck so that it took
      e.g. 5 seconds, and progress interval was 1 second, no progress reports were
      printed until the query returned. Fix so that we wake up specifically to
      print the progress report. Secondly, if pgbench got stuck so that it would
      nevertheless not print a progress report on time, and enough time passes
      that it's already time to print the next progress report, just skip the one
      that was missed. Before this patch, it would print the missed one with 0 TPS
      immediately after the previous one.
      
      Fabien Coelho. Backpatch to 9.4, where progress reports were added.
      9031ff91
    • Heikki Linnakangas's avatar
      ba3deeef
    • Fujii Masao's avatar
      Make WAL-related utilities handle .partial WAL files properly. · 8650d161
      Fujii Masao authored
      Commit de768844 changed an archive recovery so that the last WAL
      segment with old timeline was renamed with suffix .partial. It should
      have updated WAL-related utilities so that they can handle such
      .paritial WAL files, but we forgot that.
      
      This patch changes pg_archivecleanup so that it can clean up even
      archived WAL files with .partial suffix. Also it allows us to specify
      .partial WAL file name as the command-line argument "oldestkeptwalfile".
      
      This patch also changes pg_resetxlog so that it can remove .partial
      WAL files in pg_xlog directory.
      
      pg_xlogdump cannot handle .partial WAL files. Per discussion,
      we decided only to document that limitation instead of adding the fix.
      Because a user can easily work around the limitation (i.e., just remove
      .partial suffix from the file name) and the fix seems complicated for
      very narrow use case.
      
      Back-patch to 9.5 where the problem existed.
      
      Review by Michael Paquier.
      Discussion: http://www.postgresql.org/message-id/CAHGQGwGxMKnVHGgTfiig2Bt_2djec0in3-DLJmtg7+nEiidFdQ@mail.gmail.com
      8650d161
  2. 02 Jul, 2015 15 commits
  3. 01 Jul, 2015 3 commits
    • Tom Lane's avatar
      Don't leave pg_hba and pg_ident data lying around in running backends. · 1e24cf64
      Tom Lane authored
      Free the contexts holding this data after we're done using it, by the
      expedient of attaching them to the PostmasterContext which we were
      already taking care to delete (and where, indeed, this data used to live
      before commits e5e2fc84 and 7c45e3a3).  This saves a
      probably-usually-negligible amount of space per running backend.  It also
      avoids leaving potentially-security-sensitive data lying around in memory
      in processes that don't need it.  You'd have to be unusually paranoid to
      think that that amounts to a live security bug, so I've not gone so far as
      to forcibly zero the memory; but there surely isn't a good reason to keep
      this data around.
      
      Arguably this is a memory management bug in the aforementioned commits,
      but it doesn't seem important enough to back-patch.
      1e24cf64
    • Tom Lane's avatar
      Make sampler_random_fract() actually obey its API contract. · d7c19d68
      Tom Lane authored
      This function is documented to return a value in the range (0,1),
      which is what its predecessor anl_random_fract() did.  However, the
      new version depends on pg_erand48() which returns a value in [0,1).
      The possibility of returning zero creates hazards of division by zero
      or trying to compute log(0) at some call sites, and it might well
      break third-party modules using anl_random_fract() too.  So let's
      change it to never return zero.  Spotted by Coverity.
      
      Michael Paquier, cosmetically adjusted by me
      d7c19d68
    • Fujii Masao's avatar
      Make XLogFileCopy() look the same as in 9.4. · 82173708
      Fujii Masao authored
      XLogFileCopy() was changed heavily in commit de768844. However it was
      partially reverted in commit 7abc6859 and most of those changes to
      XLogFileCopy() were no longer needed. Then commit 7cbee7c0 removed
      those unnecessary code, but XLogFileCopy() looked different in master
      and 9.4 though the contents are almost the same.
      
      This patch makes XLogFileCopy() look the same in master and back-branches,
      which makes back-patching easier, per discussion on pgsql-hackers.
      Back-patch to 9.5.
      
      Discussion: 55760844.7090703@iki.fi
      
      Michael Paquier
      82173708
  4. 30 Jun, 2015 10 commits
  5. 29 Jun, 2015 7 commits
    • Heikki Linnakangas's avatar
      Initialize GIN metapage correctly when replaying metapage-update WAL record. · 47fe4d25
      Heikki Linnakangas authored
      I broke this with my WAL format refactoring patch. Before that, the metapage
      was read from disk, and modified in-place regardless of the LSN. That was
      always a bit silly, as there's no need to read the old page version from
      disk disk when we're overwriting it anyway. So that was changed in 9.5, but
      I failed to add a GinInitPage call to initialize the page-headers correctly.
      Usually you wouldn't notice, because the metapage is already in the page
      cache and is not zeroed.
      
      One way to reproduce this is to perform a VACUUM on an already vacuumed
      table (so that the vacuum has no real work to do), immediately after a
      checkpoint, and then perform an immediate shutdown. After recovery, the
      page headers of the metapage will be incorrectly all-zeroes.
      
      Reported by Jeff Janes
      47fe4d25
    • Tom Lane's avatar
      Stamp 9.5alpha1. · f78329d5
      Tom Lane authored
      f78329d5
    • Tom Lane's avatar
      Desultory review of 9.5 release notes. · 85c25fdb
      Tom Lane authored
      Minor corrections and clarifications.  Notably, for stuff that got moved
      out of contrib, make sure it's documented somewhere other than "Additional
      Modules".
      
      I'm sure these need more work, but that's all I have time for today.
      85c25fdb
    • Tom Lane's avatar
      Code + docs review for escaping of option values (commit 11a020eb). · cbc8d656
      Tom Lane authored
      Avoid memory leak from incorrect choice of how to free a StringInfo
      (resetStringInfo doesn't do it).  Now that pg_split_opts doesn't scribble
      on the optstr, mark that as "const" for clarity.  Attach the commentary in
      protocol.sgml to the right place, and add documentation about the
      user-visible effects of this change on postgres' -o option and libpq's
      PGOPTIONS option.
      cbc8d656
    • Andres Freund's avatar
      Replace ia64 S_UNLOCK compiler barrier with a full memory barrier. · 07cb8b02
      Andres Freund authored
      _Asm_sched_fence() is just a compiler barrier, not a memory barrier. But
      spinlock release on IA64 needs, at the very least, release
      semantics. Use a full barrier instead.
      
      This might be the cause for the occasional failures on buildfarm member
      anole.
      
      Discussion: 20150629101108.GB17640@alap3.anarazel.de
      07cb8b02
    • Peter Eisentraut's avatar
      Translation updates · c5e5d444
      Peter Eisentraut authored
      Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
      Source-Git-Hash: fb7e72f46cfafa1b5bfe4564d9686d63a1e6383f
      c5e5d444
    • Tom Lane's avatar
      Run the C portions of guc-file.l through pgindent. · 2bdc51a2
      Tom Lane authored
      Yeah, I know, pretty anal-retentive of me.  But we oughta find some
      way to automate this for the .y and .l files.
      2bdc51a2
  6. 28 Jun, 2015 1 commit
    • Tom Lane's avatar
      Improve design and implementation of pg_file_settings view. · 62d16c7f
      Tom Lane authored
      As first committed, this view reported on the file contents as they were
      at the last SIGHUP event.  That's not as useful as reporting on the current
      contents, and what's more, it didn't work right on Windows unless the
      current session had serviced at least one SIGHUP.  Therefore, arrange to
      re-read the files when pg_show_all_settings() is called.  This requires
      only minor refactoring so that we can pass changeVal = false to
      set_config_option() so that it won't actually apply any changes locally.
      
      In addition, add error reporting so that errors that would prevent the
      configuration files from being loaded, or would prevent individual settings
      from being applied, are visible directly in the view.  This makes the view
      usable for pre-testing whether edits made in the config files will have the
      desired effect, before one actually issues a SIGHUP.
      
      I also added an "applied" column so that it's easy to identify entries that
      are superseded by later entries; this was the main use-case for the original
      design, but it seemed unnecessarily hard to use for that.
      
      Also fix a 9.4.1 regression that allowed multiple entries for a
      PGC_POSTMASTER variable to cause bogus complaints in the postmaster log.
      (The issue here was that commit bf007a27 unintentionally reverted
      3e3f6597, which suppressed any duplicate entries within
      ParseConfigFp.  However, since the original coding of the pg_file_settings
      view depended on such suppression *not* happening, we couldn't have fixed
      this issue now without first doing something with pg_file_settings.
      Now we suppress duplicates by marking them "ignored" within
      ProcessConfigFileInternal, which doesn't hide them in the view.)
      
      Lesser changes include:
      
      Drive the view directly off the ConfigVariable list, instead of making a
      basically-equivalent second copy of the data.  There's no longer any need
      to hang onto the data permanently, anyway.
      
      Convert show_all_file_settings() to do its work in one call and return a
      tuplestore; this avoids risks associated with assuming that the GUC state
      will hold still over the course of query execution.  (I think there were
      probably latent bugs here, though you might need something like a cursor
      on the view to expose them.)
      
      Arrange to run SIGHUP processing in a short-lived memory context, to
      forestall process-lifespan memory leaks.  (There is one known leak in this
      code, in ProcessConfigDirectory; it seems minor enough to not be worth
      back-patching a specific fix for.)
      
      Remove mistaken assignment to ConfigFileLineno that caused line counting
      after an include_dir directive to be completely wrong.
      
      Add missed failure check in AlterSystemSetConfigFile().  We don't really
      expect ParseConfigFp() to fail, but that's not an excuse for not checking.
      62d16c7f