1. 29 Jan, 2014 2 commits
    • Heikki Linnakangas's avatar
      Allow using huge TLB pages on Linux (MAP_HUGETLB) · 1a3458b6
      Heikki Linnakangas authored
      This patch adds an option, huge_tlb_pages, which allows requesting the
      shared memory segment to be allocated using huge pages, by using the
      MAP_HUGETLB flag in mmap(). This can improve performance.
      
      The default is 'try', which means that we will attempt using huge pages,
      and fall back to non-huge pages if it doesn't work. Currently, only Linux
      has MAP_HUGETLB. On other platforms, the default 'try' behaves the same as
      'off'.
      
      In the passing, don't try to round the mmap() size to a multiple of
      pagesize. mmap() doesn't require that, and there's no particular reason for
      PostgreSQL to do that either. When using MAP_HUGETLB, however, round the
      request size up to nearest 2MB boundary. This is to work around a bug in
      some Linux kernel versions, but also to avoid wasting memory, because the
      kernel will round the size up anyway.
      
      Many people were involved in writing this patch, including Christian Kruse,
      Richard Poole, Abhijit Menon-Sen, reviewed by Peter Geoghegan, Andres Freund
      and me.
      1a3458b6
    • Robert Haas's avatar
      Fix compiler warning in EXEC_BACKEND builds. · b7643b19
      Robert Haas authored
      Per a report by Rajeev Rastogi.
      b7643b19
  2. 28 Jan, 2014 9 commits
    • Andrew Dunstan's avatar
      Minor docs fixes for new json functions. · c2099751
      Andrew Dunstan authored
      Thom Brown.
      c2099751
    • Andrew Dunstan's avatar
      Add new make targets check-tests and installcheck-tests. · 7043ac71
      Andrew Dunstan authored
      These do not run any specific schedule of tests, but only those
      specified as part of the invocation, e.g.:
      
          make check-tests TESTS="json jsonb"
      7043ac71
    • Andrew Dunstan's avatar
      New json functions. · 10563990
      Andrew Dunstan authored
      json_build_array() and json_build_object allow for the construction of
      arbitrarily complex json trees. json_object() turns a one or two
      dimensional array, or two separate arrays, into a json_object of
      name/value pairs, similarly to the hstore() function.
      json_object_agg() aggregates its two arguments into a single json object
      as name value pairs.
      
      Catalog version bumped.
      
      Andrew Dunstan, reviewed by Marko Tiikkaja.
      10563990
    • Fujii Masao's avatar
      Add pg_stat_archiver statistics view. · 9132b189
      Fujii Masao authored
      This view shows the statistics about the WAL archiver process's activity.
      
      Gabriele Bartolini, reviewed by Michael Paquier, refactored a bit by me.
      9132b189
    • Tom Lane's avatar
      Update comment. · 98d62c28
      Tom Lane authored
      generate_normalized_query() no longer needs to truncate text, but this
      one comment didn't get the memo.  Per Peter Geoghegan.
      98d62c28
    • Bruce Momjian's avatar
      Revert C comment change in slot_attisnull() · c871e8f5
      Bruce Momjian authored
      Revert 89774b58
      c871e8f5
    • Bruce Momjian's avatar
      Remove orphaned prototype · 051b3341
      Bruce Momjian authored
      Rajeev rastogi
      051b3341
    • Stephen Frost's avatar
      Revert dup2() checking in syslogger.c · aef61bf4
      Stephen Frost authored
      Per the expanded comment-
      
      As we're just trying to reset these to go to DEVNULL, there's not
      much point in checking for failure from the close/dup2 calls here,
      if they fail then presumably the file descriptors are closed and
      any writes will go into the bitbucket anyway.
      
      Pointed out by Tom.
      aef61bf4
    • Tom Lane's avatar
      Log a detail message for auth failures due to missing or expired password. · 64e43c59
      Tom Lane authored
      It's worth distinguishing these cases from run-of-the-mill wrong-password
      problems, since users have been known to waste lots of time pursuing the
      wrong theory about what's failing.  Now, our longstanding policy about how
      to report authentication failures is that we don't really want to tell the
      *client* such things, since that might be giving information to a bad guy.
      But there's nothing wrong with reporting the details to the postmaster log,
      and indeed the comments in this area of the code contemplate that
      interesting details should be so reported.  We just weren't handling these
      particular interesting cases usefully.
      
      To fix, add infrastructure allowing subroutines of ClientAuthentication()
      to return a string to be added to the errdetail_log field of the main
      authentication-failed error report.  We might later want to use this to
      report other subcases of authentication failure the same way, but for the
      moment I just dealt with password cases.
      
      Per discussion of a patch from Josh Drake, though this is not what
      he proposed.
      64e43c59
  3. 27 Jan, 2014 6 commits
    • Tom Lane's avatar
      Keep pg_stat_statements' query texts in a file, not in shared memory. · f0d6f202
      Tom Lane authored
      This change allows us to eliminate the previous limit on stored query
      length, and it makes the shared-memory hash table very much smaller,
      allowing more statements to be tracked.  (The default value of
      pg_stat_statements.max is therefore increased from 1000 to 5000.)
      In typical scenarios, the hash table can be large enough to hold all the
      statements commonly issued by an application, so that there is little
      "churn" in the set of tracked statements, and thus little need to do I/O
      to the file.
      
      To further reduce the need for I/O to the query-texts file, add a way
      to retrieve all the columns of the pg_stat_statements view except for
      the query text column.  This is probably not of much interest for human
      use but it could be exploited by programs, which will prefer using the
      queryid anyway.
      
      Ordinarily, we'd need to bump the extension version number for the latter
      change.  But since we already advanced pg_stat_statements' version number
      from 1.1 to 1.2 in the 9.4 development cycle, it seems all right to just
      redefine what 1.2 means.
      
      Peter Geoghegan, reviewed by Pavel Stehule
      f0d6f202
    • Robert Haas's avatar
      Relax the requirement that all lwlocks be stored in a single array. · ea9df812
      Robert Haas authored
      This makes it possible to store lwlocks as part of some other data
      structure in the main shared memory segment, or in a dynamic shared
      memory segment.  There is still a main LWLock array and this patch does
      not move anything out of it, but it provides necessary infrastructure
      for doing that in the future.
      
      This change is likely to increase the size of LWLockPadded on some
      platforms, especially 32-bit platforms where it was previously only
      16 bytes.
      
      Patch by me.  Review by Andres Freund and KaiGai Kohei.
      ea9df812
    • Heikki Linnakangas's avatar
      Fix typo in README · f62eba20
      Heikki Linnakangas authored
      Amit Langote
      f62eba20
    • Tom Lane's avatar
      Code review for auto-tuned effective_cache_size. · 28508969
      Tom Lane authored
      Fix integer overflow issue noted by Magnus Hagander, as well as a bunch
      of other infelicities in commit ee1e5662
      and its unreasonably large number of followups.
      28508969
    • Fujii Masao's avatar
      Change the suffix of auto conf temporary file from "temp" to "tmp". · dd515d40
      Fujii Masao authored
      Michael Paquier
      dd515d40
    • Fujii Masao's avatar
      Fix typos in comments for ALTER SYSTEM. · 7c619be6
      Fujii Masao authored
      Michael Paquier
      7c619be6
  4. 26 Jan, 2014 7 commits
  5. 25 Jan, 2014 6 commits
  6. 24 Jan, 2014 6 commits
    • Stephen Frost's avatar
      Avoid minor leak in parallel pg_dump · 6794a9f9
      Stephen Frost authored
      During parallel pg_dump, a worker process closing the connection caused
      a minor memory leak (particularly minor as we are likely about to exit
      anyway).  Instead, free the memory in this case prior to returning NULL
      to indicate connection closed.
      
      Spotting by the Coverity scanner.
      
      Back patch to 9.3 where this was introduced.
      6794a9f9
    • Heikki Linnakangas's avatar
      Reset unused fields in GIN data leaf page footer. · d150ff57
      Heikki Linnakangas authored
      The maxoff field is not used in the new, compressed page format. Let's
      reset it when converting an old-format page to the new format. The code
      won't care either way, but this makes it possible to use the field for
      something else in the future.
      d150ff57
    • Heikki Linnakangas's avatar
      Fix off-by-one in newly-introdcued GIN assertion. · a8f37484
      Heikki Linnakangas authored
      Spotted by Alexander Korotkov
      a8f37484
    • Heikki Linnakangas's avatar
      In GIN recompression code, use mmemove rather than memcpy, for vacuum. · 398cf255
      Heikki Linnakangas authored
      When vacuuming a data leaf page, any compressed posting lists that are not
      modified, are copied back to the buffer from a later location in the same
      buffer rather than from  a palloc'd copy. IOW, they are just moved
      downwards in the same buffer. Because the source and destination addresses
      can overlap, we must use memmove rather than memcpy.
      
      Report and fix by Alexander Korotkov.
      398cf255
    • Stephen Frost's avatar
      ALTER TABLESPACE ... MOVE ... OWNED BY · fbe19ee3
      Stephen Frost authored
      Add the ability to specify the objects to move by who those objects are
      owned by (as relowner) and change ALL to mean ALL objects.  This
      makes the command always operate against a well-defined set of objects
      and not have the objects-to-be-moved based on the role of the user
      running the command.
      
      Per discussion with Simon and Tom.
      fbe19ee3
    • Fujii Masao's avatar
      3ee74df2
  7. 23 Jan, 2014 4 commits
    • Tom Lane's avatar
      Allow use of "z" flag in our printf calls, and use it where appropriate. · ac4ef637
      Tom Lane authored
      Since C99, it's been standard for printf and friends to accept a "z" size
      modifier, meaning "whatever size size_t has".  Up to now we've generally
      dealt with printing size_t values by explicitly casting them to unsigned
      long and using the "l" modifier; but this is really the wrong thing on
      platforms where pointers are wider than longs (such as Win64).  So let's
      start using "z" instead.  To ensure we can do that on all platforms, teach
      src/port/snprintf.c to understand "z", and add a configure test to force
      use of that implementation when the platform's version doesn't handle "z".
      
      Having done that, modify a bunch of places that were using the
      unsigned-long hack to use "z" instead.  This patch doesn't pretend to have
      gotten everyplace that could benefit, but it catches many of them.  I made
      an effort in particular to ensure that all uses of the same error message
      text were updated together, so as not to increase the number of
      translatable strings.
      
      It's possible that this change will result in format-string warnings from
      pre-C99 compilers.  We might have to reconsider if there are any popular
      compilers that will warn about this; but let's start by seeing what the
      buildfarm thinks.
      
      Andres Freund, with a little additional work by me
      ac4ef637
    • Heikki Linnakangas's avatar
      Fix alignment of GIN in-line posting lists stored in entry tuples. · ec8f692c
      Heikki Linnakangas authored
      The Sparc machines in the buildfarm are crashing because of misaligned
      access to posting lists stored in entry tuples.
      
      I accidentally removed a critical SHORTALIGN() from ginFormTuple, as part
      of the packed posting lists patch. Perhaps I thought it was unnecessary,
      because the index_form_tuple() call above the SHORTALIGN already aligned
      the size, missing the fact that the null-category byte makes it misaligned
      again (I think the SHORTALIGN is indeed unnecessary if there's no null-
      category byte, but let's just play it safe...)
      ec8f692c
    • Heikki Linnakangas's avatar
      Silence compiler warning. · 0fdb2f7d
      Heikki Linnakangas authored
      Not all compilers understand that elog(ERROR, ...) never returns.
      0fdb2f7d
    • Alvaro Herrera's avatar
      Make DROP IF EXISTS more consistently not fail · b152c6cd
      Alvaro Herrera authored
      Some cases were still reporting errors and aborting, instead of a NOTICE
      that the object was being skipped.  This makes it more difficult to
      cleanly handle pg_dump --clean, so change that to instead skip missing
      objects properly.
      
      Per bug #7873 reported by Dave Rolsky; apparently this affects a large
      number of users.
      
      Authors: Pavel Stehule and Dean Rasheed.  Some tweaks by Álvaro Herrera
      b152c6cd