1. 05 Oct, 2012 3 commits
  2. 04 Oct, 2012 4 commits
    • Tom Lane's avatar
      Make CREATE AGGREGATE complain if the initcond is invalid for the datatype. · e1e60694
      Tom Lane authored
      The initial transition value is stored as a text string and not fed to the
      transition type's input function until runtime (so that values such as
      "now" don't get frozen at creation time).  Previously, CREATE AGGREGATE
      didn't do anything with it but that, which meant that even erroneous values
      would be accepted and not complained of until the aggregate is used.  This
      seems unhelpful, and it's confused at least one user, as in Rhys Stewart's
      recent report.  It seems worth taking a few more cycles to invoke the input
      function and verify that the value is acceptable.  We can't do this if the
      transition type is polymorphic, but in normal aggregates we know the actual
      transition type so we can call the right input function.
      e1e60694
    • Tom Lane's avatar
      Fix parse location tracking for lists that can be empty. · 70726354
      Tom Lane authored
      The previous coding of the YYLLOC_DEFAULT macro behaved strangely for empty
      productions, assigning the previous nonterminal's location as the parse
      location of the result.  The usefulness of that was (at best) debatable
      already, but the real problem is that in list-generating nonterminals like
      	OptFooList: /* EMPTY */ { ... } | OptFooList Foo { ... } ;
      the initially-identified location would get copied up, so that even a
      nonempty list would be given a bogus parse location.  Document how to work
      around that, and do so for OptSchemaEltList, so that the error condition
      just added for CREATE SCHEMA IF NOT EXISTS produces a sane error cursor.
      So far as I can tell, there are currently no other cases where the
      situation arises, so we don't need other instances of this coding yet.
      70726354
    • Tom Lane's avatar
      Fix permissions explanations in CREATE DATABASE and CREATE SCHEMA docs. · 7e389f73
      Tom Lane authored
      These reference pages still claimed that you have to be superuser to create
      a database or schema owned by a different role.  That was true before 8.1,
      but it was changed in commits aa111062 and
      f91370cd to allow assignment of ownership
      to any role you are a member of.  However, at the time we were thinking of
      that primarily as a change to the ALTER OWNER rules, so the need to touch
      these two CREATE ref pages got missed.
      7e389f73
    • Heikki Linnakangas's avatar
  3. 03 Oct, 2012 9 commits
    • Tom Lane's avatar
      Support CREATE SCHEMA IF NOT EXISTS. · fb34e94d
      Tom Lane authored
      Per discussion, schema-element subcommands are not allowed together with
      this option, since it's not very obvious what should happen to the element
      objects.
      
      Fabrízio de Royes Mello
      fb34e94d
    • Alvaro Herrera's avatar
      refactor ALTER some-obj SET OWNER implementation · 994c36e0
      Alvaro Herrera authored
      Remove duplicate implementation of catalog munging and miscellaneous
      privilege and consistency checks.  Instead rely on already existing data
      in objectaddress.c to do the work.
      
      Author: KaiGai Kohei
      Tweaked by me
      Reviewed by Robert Haas
      994c36e0
    • Tom Lane's avatar
      Avoid planner crash/Assert failure with joins to unflattened subqueries. · 1f91c8ca
      Tom Lane authored
      examine_simple_variable supposed that any RTE_SUBQUERY rel it gets pointed
      at must have been planned already.  However, this isn't a safe assumption
      because we must do selectivity estimation while generating indexscan paths,
      and that code might look at join clauses involving a rel that the loop in
      set_base_rel_sizes() hasn't reached yet.  The simplest fix is to play dumb
      in such a situation, that is give up trying to extract any stats for the
      Var.  This could possibly be improved by making a separate pass over the
      RTE list to plan each unflattened subquery before we start the main
      planning work --- but that would be pretty invasive and it doesn't seem
      worth it, for now at least.  (We couldn't just break set_base_rel_sizes()
      into two loops: the prescan would need to handle all subquery rels in the
      query, not only those in the current join subproblem.)
      
      This bug was introduced in commit 1cb108ef,
      although I think that subsequent changes may have exposed it more than it
      was originally.  Per bug #7580 from Maxim Boguk.
      1f91c8ca
    • Alvaro Herrera's avatar
      REASSIGN OWNED: consider grants on tablespaces, too · fe3b5eb0
      Alvaro Herrera authored
      Apparently this was considered in the original code (see commit
      cec3b0a9) but I failed to notice that such entries would always be
      skipped by the database check at the start of the loop.
      
      Per bugs #7578 by Nikolay, #6116 by tushar.qa@gmail.com.
      fe3b5eb0
    • Heikki Linnakangas's avatar
      Add --sampling-rate option to pgbench. · e1be1df5
      Heikki Linnakangas authored
      This allows logging only some fraction of transactions, greatly reducing
      the amount of log generated.
      
      Tomas Vondra, reviewed by Robert Haas and Jeff Janes.
      e1be1df5
    • Heikki Linnakangas's avatar
      Return the number of rows processed when COPY is executed through SPI. · 7ae18159
      Heikki Linnakangas authored
      You can now get the number of rows processed by a COPY statement in a
      PL/pgSQL function with "GET DIAGNOSTICS x = ROW_COUNT".
      
      Pavel Stehule, reviewed by Amit Kapila, with some editing by me.
      7ae18159
    • Heikki Linnakangas's avatar
      Fix two bugs introduced in the xlog.c split. · bc1229c8
      Heikki Linnakangas authored
      The comment explaining the naming of timeline history files was wrong, and
      the history file was not being arhived.
      
      Pointed out by Fujii Masao.
      bc1229c8
    • Peter Eisentraut's avatar
      6bd17609
    • Bruce Momjian's avatar
      In pg_upgrade, use full path name for analyze_new_cluster.sh script. · ce754579
      Bruce Momjian authored
      Backpatch to 9.2.
      ce754579
  4. 02 Oct, 2012 12 commits
  5. 01 Oct, 2012 4 commits
    • Bruce Momjian's avatar
      Add C comment that IsBackendPid() is called by external modules, so we · dbdb2172
      Bruce Momjian authored
      don't accidentally remove it.
      dbdb2172
    • Alvaro Herrera's avatar
      Remove collations from generic ALTER test · ece26987
      Alvaro Herrera authored
      The error messages they generate are not portable enough.
      
      Also, since the only point of the alter_generic_1 expected file was to
      cover platforms with no collation support, it's now useless, so remove
      it.
      ece26987
    • Heikki Linnakangas's avatar
    • Tom Lane's avatar
      Provide some static-assertion functionality on all compilers. · 0d0aa5d2
      Tom Lane authored
      On reflection (especially after noticing how many buildfarm critters have
      __builtin_types_compatible_p but not _Static_assert), it seems like we
      ought to try a bit harder to make these macros do something everywhere.
      The initial cut at it would have been no help to code that is compiled only
      on platforms without _Static_assert, for instance; and in any case not all
      our contributors do their initial coding on the latest gcc version.
      
      Some googling about static assertions turns up quite a bit of prior art
      for making it work in compilers that lack _Static_assert.  The method
      that seems closest to our needs involves defining a struct with a bit-field
      that has negative width if the assertion condition fails.  There seems no
      reliable way to get the error message string to be output, but throwing a
      compile error with a confusing message is better than missing the problem
      altogether.
      
      In the same spirit, if we don't have __builtin_types_compatible_p we can at
      least insist that the variable have the same width as the type.  This won't
      catch errors such as "wrong pointer type", but it's far better than
      nothing.
      
      In addition to changing the macro definitions, adjust a
      compile-time-constant Assert in contrib/hstore to use StaticAssertStmt,
      so we can get some buildfarm coverage on whether that macro behaves sanely
      or not.  There's surely more places that could be converted, but this is
      the first one I came across.
      0d0aa5d2
  6. 30 Sep, 2012 3 commits
  7. 29 Sep, 2012 5 commits
    • Tom Lane's avatar
      Fix bugs in "restore.sql" script emitted in pg_dump tar output. · ff75219e
      Tom Lane authored
      The tar output module did some very ugly and ultimately incorrect hacking
      on COPY commands to try to get them to work in the context of restoring a
      deconstructed tar archive.  In particular, it would fail altogether for
      table names containing any upper-case characters, since it smashed the
      command string to lower-case before modifying it (and, just to add insult
      to injury, did that in a way that would fail in multibyte encodings).
      I don't see any particular value in being flexible about the case of the
      command keywords, since the string will just have been created by
      dumpTableData, so let's get rid of the whole case-folding thing.
      
      Also, it doesn't seem to meet the POLA for the script to restore data only
      in COPY mode, so add \i commands to make it have comparable behavior in
      --inserts mode.
      
      Noted while looking at the tar-output code in connection with Brian
      Weaver's patch.
      ff75219e
    • Peter Eisentraut's avatar
      Add _FORTIFY_SOURCE to default compiler options for linux template · 997fa75d
      Peter Eisentraut authored
      Many distributors use this, so we might as well see the warnings as
      well.
      997fa75d
    • Peter Eisentraut's avatar
      PL/Python: Remove workaround for returning booleans in Python <2.3 · be0dfbad
      Peter Eisentraut authored
      Since Python 2.2 is no longer supported, we can now use Py_RETURN_TRUE
      and Py_RETURN_FALSE instead of the old workaround.
      be0dfbad
    • Peter Eisentraut's avatar
      PL/Python: Convert oid to long/int · db0af74a
      Peter Eisentraut authored
      oid is a numeric type, so transform it to the appropriate Python
      numeric type like the other ones.
      db0af74a
    • Alvaro Herrera's avatar
      Add alternative expected output for alter_generic · 811ca130
      Alvaro Herrera authored
      The original only expected file failed to consider machines without
      non-default collation support.  Per buildfarm.
      
      Also, move the test to another parallel group; the one it was originally
      put in is already full according to comments in the schedule file.  Per
      note from Tom Lane.
      811ca130