1. 14 Jan, 2008 4 commits
  2. 13 Jan, 2008 3 commits
  3. 12 Jan, 2008 5 commits
  4. 11 Jan, 2008 6 commits
    • Tom Lane's avatar
      The original implementation of polymorphic aggregates didn't really get the · 89c0a87f
      Tom Lane authored
      checking of argument compatibility right; although the problem is only exposed
      with multiple-input aggregates in which some arguments are polymorphic and
      some are not.  Per bug #3852 from Sokolov Yura.
      89c0a87f
    • Tom Lane's avatar
      Fix an old error in clause_selectivity: the default selectivity estimate · df62977d
      Tom Lane authored
      for unhandled clause types ought to be 0.5, not 1.0.  I fear I introduced
      this silliness due to misreading the intent of the very-poorly-structured
      code that was there when we inherited the file from Berkeley.  The lack
      of sanity in this behavior was exposed by an example from Sim Zacks.
      (Arguably this is a bug fix and should be back-patched, but I'm a bit
      hesitant to introduce a possible planner behavior change in the back
      branches; it might detune queries that worked acceptably in the past.)
      
      While at it, make estimation for DistinctExpr do something marginally
      realistic, rather than just defaulting.
      df62977d
    • Bruce Momjian's avatar
      Add: · f3e3f2e1
      Bruce Momjian authored
      > * Add ability to trigger on TRUNCATE
      >
      >   http://archives.postgresql.org/pgsql-sql/2008-01/msg00050.php
      f3e3f2e1
    • Michael Meskes's avatar
      Fixed lexer to correctly parse C quotes. · da758c26
      Michael Meskes authored
      da758c26
    • Tom Lane's avatar
      Fix a conceptual error in my patch of 2007-10-26 that avoided considering · 59fc64ac
      Tom Lane authored
      clauseless joins of relations that have unexploited join clauses.  Rather
      than looking at every other base relation in the query, the correct thing is
      to examine the other relations in the "initial_rels" list of the current
      make_rel_from_joinlist() invocation, because those are what we actually have
      the ability to join against.  This might be a subset of the whole query in
      cases where join_collapse_limit or from_collapse_limit or full joins have
      prevented merging the whole query into a single join problem.  This is a bit
      untidy because we have to pass those rels down through a new PlannerInfo
      field, but it's necessary.  Per bug #3865 from Oleg Kharin.
      59fc64ac
    • Tom Lane's avatar
      Restructure the shutdown procedure for the archiver process to allow it to · e6a442c7
      Tom Lane authored
      finish archiving everything (when there's no error), and to eliminate various
      hazards as best we can.  This fixes a previous 8.3 patch that caused the
      postmaster to kill and then restart the archiver during shutdown (!?).
      
      The new behavior is that the archiver is allowed to run unmolested until
      the bgwriter has exited; then it is sent SIGUSR2 to tell it to do a final
      archiving cycle and quit.  We only SIGQUIT the archiver if we want a panic
      stop; this is important since SIGQUIT will also be sent to any active
      archive_command.  The postmaster also now doesn't SIGQUIT the stats collector
      until the bgwriter is done, since the bgwriter can send stats messages in 8.3.
      The postmaster will not exit until both the archiver and stats collector are
      gone; this provides some defense (not too bulletproof) against conflicting
      archiver or stats collector processes being started by a new postmaster
      instance.  We continue the prior practice that the archiver will check
      for postmaster death immediately before issuing any archive_command; that
      gives some additional protection against conflicting archivers.
      
      Also, modify the archiver process to notice SIGTERM and refuse to issue any
      more archive commands if it gets it.  The postmaster doesn't ever send it
      SIGTERM; we assume that any such signal came from init and is a notice of
      impending whole-system shutdown.  In this situation it seems imprudent to try
      to start new archive commands --- if they aren't extremely quick they're
      likely to get SIGKILL'd by init.
      
      All per discussion.
      e6a442c7
  5. 10 Jan, 2008 2 commits
  6. 09 Jan, 2008 7 commits
    • Tom Lane's avatar
      Remove incorrect (and ill-advised anyway) pfree's in pg_convert_from and · a9742f12
      Tom Lane authored
      pg_convert_to.  Per bug #3866 from Andrew Gilligan.
      a9742f12
    • Tom Lane's avatar
      Fix CREATE INDEX CONCURRENTLY to not deadlock against an automatic or manual · ceb93600
      Tom Lane authored
      VACUUM that is blocked waiting to get lock on the table being indexed.
      Per report and fix suggestion from Greg Stark.
      ceb93600
    • Tom Lane's avatar
      Fix some planner issues found while investigating Kevin Grittner's report · 6a652252
      Tom Lane authored
      of poorer planning in 8.3 than 8.2:
      
      1. After pushing a constant across an outer join --- ie, given
      "a LEFT JOIN b ON (a.x = b.y) WHERE a.x = 42", we can deduce that b.y is
      sort of equal to 42, in the sense that we needn't fetch any b rows where
      it isn't 42 --- loop to see if any additional deductions can be made.
      Previous releases did that by recursing, but I had mistakenly thought that
      this was no longer necessary given the EquivalenceClass machinery.
      
      2. Allow pushing constants across outer join conditions even if the
      condition is outerjoin_delayed due to a lower outer join.  This is safe
      as long as the condition is strict and we re-test it at the upper join.
      
      3. Keep the outer-join clause even if we successfully push a constant
      across it.  This is *necessary* in the outerjoin_delayed case, but
      even in the simple case, it seems better to do this to ensure that the
      join search order heuristics will consider the join as reasonable to
      make.  Mark such a clause as having selectivity 1.0, though, since it's
      not going to eliminate very many rows after application of the constant
      condition.
      
      4. Tweak have_relevant_eclass_joinclause to report that two relations
      are joinable when they have vars that are equated to the same constant.
      We won't actually generate any joinclause from such an EquivalenceClass,
      but again it seems that in such a case it's a good idea to consider
      the join as worth costing out.
      
      5. Fix a bug in select_mergejoin_clauses that was exposed by these
      changes: we have to reject candidate mergejoin clauses if either side was
      equated to a constant, because we can't construct a canonical pathkey list
      for such a clause.  This is an implementation restriction that might be
      worth fixing someday, but it doesn't seem critical to get it done for 8.3.
      6a652252
    • Magnus Hagander's avatar
      Don't enforce 32-bit time_t for FRONTEND apps. Fixes standalone · 8d546c71
      Magnus Hagander authored
      builds of libpq in both 32 and 64-bit. Per gripe from Hiroshi Saito.
      8d546c71
    • Neil Conway's avatar
      Fix an omission in the outfuncs.c support for Agg nodes: the grpColIdx · bbee1c5d
      Neil Conway authored
      and grpOperators fields were not emitted by _outAgg().
      bbee1c5d
    • Alvaro Herrera's avatar
      Add index entry. · ccd3e321
      Alvaro Herrera authored
      ccd3e321
    • Bruce Momjian's avatar
      3048964e
  7. 08 Jan, 2008 4 commits
  8. 07 Jan, 2008 2 commits
  9. 06 Jan, 2008 1 commit
  10. 05 Jan, 2008 1 commit
  11. 04 Jan, 2008 1 commit
  12. 03 Jan, 2008 4 commits
    • Tom Lane's avatar
      Stamp release 8.3RC1. · 2bf121e4
      Tom Lane authored
      Security: CVE-2007-4769, CVE-2007-4772, CVE-2007-6067, CVE-2007-6600, CVE-2007-6601
      2bf121e4
    • Tom Lane's avatar
      Update release notes for security releases. · 019fac77
      Tom Lane authored
      Security: CVE-2007-4769, CVE-2007-4772, CVE-2007-6067, CVE-2007-6600, CVE-2007-6601
      019fac77
    • Tom Lane's avatar
      The original patch to disallow non-passworded connections to non-superusers · 919c9f6c
      Tom Lane authored
      failed to cover all the ways in which a connection can be initiated in dblink.
      Plug the remaining holes.  Also, disallow transient connections in functions
      for which that feature makes no sense (because they are only sensible as
      part of a sequence of operations on the same connection).  Joe Conway
      
      Security: CVE-2007-6601
      919c9f6c
    • Tom Lane's avatar
      Make standard maintenance operations (including VACUUM, ANALYZE, REINDEX, · eedb068c
      Tom Lane authored
      and CLUSTER) execute as the table owner rather than the calling user, using
      the same privilege-switching mechanism already used for SECURITY DEFINER
      functions.  The purpose of this change is to ensure that user-defined
      functions used in index definitions cannot acquire the privileges of a
      superuser account that is performing routine maintenance.  While a function
      used in an index is supposed to be IMMUTABLE and thus not able to do anything
      very interesting, there are several easy ways around that restriction; and
      even if we could plug them all, there would remain a risk of reading sensitive
      information and broadcasting it through a covert channel such as CPU usage.
      
      To prevent bypassing this security measure, execution of SET SESSION
      AUTHORIZATION and SET ROLE is now forbidden within a SECURITY DEFINER context.
      
      Thanks to Itagaki Takahiro for reporting this vulnerability.
      
      Security: CVE-2007-6600
      eedb068c