Skip to content

P
Postgres FD Implementation
Switch branch/tag
  1. 02 Jun, 2019 3 commits
  3. 01 Jun, 2019 1 commit
  5. 31 May, 2019 9 commits
  7. 30 May, 2019 3 commits
  9. 29 May, 2019 3 commits
  11. 28 May, 2019 7 commits
  13. 27 May, 2019 1 commit
  15. 26 May, 2019 4 commits
  17. 25 May, 2019 1 commit
  19. 24 May, 2019 3 commits
  21. 23 May, 2019 5 commits
    • Andres Freund's avatar
      tableam: Rename wrapper functions to match callback names. · 73b8c3bd
      Andres Freund authored 
      Some of the wrapper functions didn't match the callback names. Many of
them due to staying "consistent" with historic naming of the wrapped
functionality. We decided that for most cases it's more important to
be for tableam to be consistent going forward, than with the past.

The one exception is beginscan/endscan/...  because it'd have looked
odd to have systable_beginscan/endscan/... with a different naming
scheme, and changing the systable_* APIs would have caused way too
much churn (including breaking a lot of external users).

Author: Ashwin Agrawal, with some small additions by Andres Freund
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/CALfoeiugyrXZfX7n0ORCa4L-m834dzmaE8eFdbNR6PMpetU4Ww@mail.gmail.com
      73b8c3bd
    • Michael Paquier's avatar
      Fix table dump in pg_dump[all] with backends older than 9.5 · 54487d15
      Michael Paquier authored 
      The access method name "amname" can be dumped as of 3b925e90, but
queries for backends older than 9.5 forgot to map it to a dummy NULL
value, causing the column to not be mapped to a number.  As a result,
pg_dump was throwing some spurious errors in its stderr output coming
from libpq:
pg_dump: column number -1 is out of range 0..36

Fix this issue by adding a mapping of "amname" to NULL to all the older
queries.

Discussion: https://postgr.es/m/20190522083038.GA16837@paquier.xyz
Author: Michael Paquier
Reviewed-by: Dmitry Dolgov, Andres Freund, Tom Lane
      54487d15
    • Andres Freund's avatar
      pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir. · f916221d
      Andres Freund authored 
      On master (after 700538) the old version's installed psql was used -
even when the old version might not actually be installed / might be
installed into a temporary directory. As commonly the case when just
executing make check for pg_upgrade, as $oldbindir is just the current
version's $bindir.

In the back branches, with --install specified, psql from the new
version's temporary installation was used, without --install (e.g for
NO_TEMP_INSTALL, cf 47b3c266), the new version's installed psql was
used (which might or might not exist).

Author: Andres Freund
Discussion: https://postgr.es/m/20190522175150.c26f4jkqytahajdg@alap3.anarazel.de
      f916221d
    • Andrew Gierth's avatar
      Fix array size allocation for HashAggregate hash keys. · 44e95b57
      Andrew Gierth authored 
      When there were duplicate columns in the hash key list, the array
sizes could be miscomputed, resulting in access off the end of the
array. Adjust the computation to ensure the array is always large
enough.

(I considered whether the duplicates could be removed in planning, but
I can't rule out the possibility that duplicate columns might have
different hash functions assigned. Simpler to just make sure it works
at execution time regardless.)

Bug apparently introduced in fc4b3dea as part of narrowing down the
tuples stored in the hashtable. Reported by Colm McHugh of Salesforce,
though I didn't use their patch. Backpatch back to version 10 where
the bug was introduced.

Discussion: https://postgr.es/m/CAFeeJoKKu0u+A_A9R9316djW-YW3-+Gtgvy3ju655qRHR3jtdA@mail.gmail.com
      44e95b57
    • Michael Paquier's avatar
      Fix ordering of GRANT commands in pg_dumpall for tablespaces · 156c0c2d
      Michael Paquier authored 
      This uses a method similar to 68a7c24f and now b8c6014a (applied for
database creation), which guarantees that GRANT commands using the WITH
GRANT OPTION are dumped in a way so as cascading dependencies are
respected.  Note that tablespaces do not have support for initial
privileges via pg_init_privs, so the same method needs to be applied
again.  It would be nice to merge all the logic generating ACL queries
in dumps under the same banner, but this requires extending the support
of pg_init_privs to objects that cannot use it yet, so this is left as
future work.

Discussion: https://postgr.es/m/20190522071555.GB1278@paquier.xyz
Author: Michael Paquier
Reviewed-by: Nathan Bossart
Backpatch-through: 9.6
      156c0c2d