1. 01 Mar, 2006 3 commits
    • Neil Conway's avatar
      Attached is a patch that replaces a bunch of places where StringInfos · 0d9742f9
      Neil Conway authored
      are unnecessarily allocated on the heap rather than the stack. If the
      StringInfo doesn't outlive the stack frame in which it is created,
      there is no need to allocate it on the heap via makeStringInfo() --
      stack allocation is faster.  While it's not a big deal unless the
      code is in a critical path, I don't see a reason not to save a few
      cycles -- using stack allocation is not less readable.
      
      I also cleaned up a bit of code along the way: moved variable
      declarations into a more tightly-enclosing scope where possible,
      fixed some pointless copying of strings in dblink, etc.
      0d9742f9
    • Neil Conway's avatar
      This patch makes the error message strings throughout the backend · 8e5a10d4
      Neil Conway authored
      more compliant with the error message style guide. In particular,
      errdetail should begin with a capital letter and end with a period,
      whereas errmsg should not. I also fixed a few related issues in
      passing, such as fixing the repeated misspelling of "lexeme" in
      contrib/tsearch2 (per Tom's suggestion).
      8e5a10d4
    • Bruce Momjian's avatar
      87fa10a4
  2. 28 Feb, 2006 11 commits
  3. 27 Feb, 2006 3 commits
  4. 26 Feb, 2006 7 commits
  5. 25 Feb, 2006 4 commits
  6. 24 Feb, 2006 5 commits
  7. 23 Feb, 2006 1 commit
  8. 21 Feb, 2006 3 commits
    • Neil Conway's avatar
      Cleanup the usage of ScanDirection: use the symbolic names for the · 737651f6
      Neil Conway authored
      possible ScanDirection alternatives rather than magic numbers
      (-1, 0, 1).  Also, use the ScanDirection macros in a few places
      rather than directly checking whether `dir == ForwardScanDirection'
      and the like. Per patch from James William Pye. His patch also
      changed ScanDirection to be a "char" rather than an enum, which
      I haven't applied.
      737651f6
    • Tom Lane's avatar
      Fix old pg_dump oversight: default values for domains really need to be dumped · 3666260f
      Tom Lane authored
      by decompiling the typdefaultbin expression, not just printing the typdefault
      text which may be out-of-date or assume the wrong schema search path.  (It's
      the same hazard as for adbin vs adsrc in column defaults.)  The catalogs.sgml
      spec for pg_type implies that the correct procedure is to look to
      typdefaultbin first and consider typdefault only if typdefaultbin is NULL.
      I made dumping of both domains and base types do that, even though in the
      current backend code typdefaultbin is always correct for domains and
      typdefault for base types --- might as well try to future-proof it a little.
      Per bug report from Alexander Galler.
      3666260f
    • Tom Lane's avatar
      Adjust probe for getaddrinfo to cope with macro-ized definitions, such · af49a163
      Tom Lane authored
      as Tru64's.  Per previous discussion.
      af49a163
  9. 20 Feb, 2006 2 commits
  10. 19 Feb, 2006 1 commit