1. 18 Jan, 2014 4 commits
    • Tom Lane's avatar
      Make various variables const (read-only). · 0d79c0a8
      Tom Lane authored
      These changes should generally improve correctness/maintainability.
      A nice side benefit is that several kilobytes move from initialized
      data to text segment, allowing them to be shared across processes and
      probably reducing copy-on-write overhead while forking a new backend.
      Unfortunately this doesn't seem to help libpq in the same way (at least
      not when it's compiled with -fpic on x86_64), but we can hope the linker
      at least collects all nominally-const data together even if it's not
      actually part of the text segment.
      
      Also, make pg_encname_tbl[] static in encnames.c, since there seems
      no very good reason for any other code to use it; per a suggestion
      from Wim Lewis, who independently submitted a patch that was mostly
      a subset of this one.
      
      Oskari Saarenmaa, with some editorialization by me
      0d79c0a8
    • Andrew Dunstan's avatar
      Export a few more symbols required for test_shm_mq module. · 7d7eee8b
      Andrew Dunstan authored
      Patch from Amit Kapila.
      7d7eee8b
    • Peter Eisentraut's avatar
      Fix client-only installation · ad6bf029
      Peter Eisentraut authored
      The psql Makefile was not creating $(datadir) before installing
      psqlrc.sample there.
      
      In most cases, the directory would be created in some other way, but for
      the documented from-source client-only installation procedure, it could
      fail.
      Reported-by: default avatarMike Blackwell <mike.blackwell@rrd.com>
      ad6bf029
    • Tom Lane's avatar
      Minor code beautification in contrib/sslinfo. · af9e3d65
      Tom Lane authored
      Static-ify some functions that didn't need to be exported, and improve
      a couple of comments.
      
      Gurjeet Singh
      af9e3d65
  2. 17 Jan, 2014 8 commits
  3. 16 Jan, 2014 7 commits
    • Bruce Momjian's avatar
      7e1955b8
    • Heikki Linnakangas's avatar
      Fix Hot Standby feedback sending when streaming busily. · a472ae1e
      Heikki Linnakangas authored
      Commit 6f60fdd7 accidentally removed a
      call to XLogWalRcvSendHSFeedback() after flushing received WAL to disk.
      The consequence is that when walsender is busy streaming WAL, it doesn't
      send HS feedback messages. One is sent if nothing is received from the
      master for 100ms, but if there's a steady stream of WAL, it never happens.
      
      Backpatch to 9.3.
      
      Andres Freund and Amit Kapila
      a472ae1e
    • Alvaro Herrera's avatar
      Split ecpg_execute() in constituent parts · 61bee9f7
      Alvaro Herrera authored
      Split the rather long ecpg_execute() function into ecpg_build_params(),
      ecpg_autostart_transaction(), a smaller ecpg_execute() and
      ecpg_process_output().  There is no user-visible change here, only code
      reorganization to support future patches.
      
      Author: Zoltán Böszörményi
      
      Reviewed by Antonin Houska.  Larger, older versions of this patch were
      reviewed by Noah Misch and Michael Meskes.
      61bee9f7
    • Tom Lane's avatar
      Add display of oprcode (the underlying function's name) to psql's \do+. · 515d2c59
      Tom Lane authored
      The + modifier of \do didn't use to do anything, but now it adds an oprcode
      column.  This is useful both as an additional form of documentation of what
      the operator does, and to save a step when finding out properties of the
      underlying function.
      
      Marko Tiikkaja, reviewed by Rushabh Lathia, adjusted a bit by me
      515d2c59
    • Alvaro Herrera's avatar
      Split ECPGdo() in constituent parts · 32913013
      Alvaro Herrera authored
      This splits ECPGdo() into ecpg_prologue(), ecpg_do() and
      ecpg_epilogue(), and renames free_params() into ecpg_free_params() and
      exports it.  This makes it possible for future code to use these
      routines for their own purposes.
      
      There is no user-visible functionality change here, only code
      reorganization.
      
      Zoltán Böszörményi
      
      Reviewed by Antonin Houska.  Larger, older versions of this patch were
      reviewed by Noah Misch and Michael Meskes.
      32913013
    • Heikki Linnakangas's avatar
      Suppress Coverity complaints in readfuncs.c. · 8ba288da
      Heikki Linnakangas authored
      Coverity is complaining that the value returned by pg_strtok in
      READ_LOCATION_FIELD and READ_BITMAPSET_FIELD macros is not used. In commit
      39bfc94c, we did this to the other macros
      to placate compilers that complained when the variable was completely
      unused, this extends that to the last remaining macros.
      8ba288da
    • Peter Eisentraut's avatar
      Fix whitespace · a687ec7d
      Peter Eisentraut authored
      a687ec7d
  4. 15 Jan, 2014 7 commits
  5. 14 Jan, 2014 7 commits
    • Tom Lane's avatar
      Fix multiple bugs in index page locking during hot-standby WAL replay. · 061b079f
      Tom Lane authored
      In ordinary operation, VACUUM must be careful to take a cleanup lock on
      each leaf page of a btree index; this ensures that no indexscans could
      still be "in flight" to heap tuples due to be deleted.  (Because of
      possible index-tuple motion due to concurrent page splits, it's not enough
      to lock only the pages we're deleting index tuples from.)  In Hot Standby,
      the WAL replay process must likewise lock every leaf page.  There were
      several bugs in the code for that:
      
      * The replay scan might come across unused, all-zero pages in the index.
      While btree_xlog_vacuum itself did the right thing (ie, nothing) with
      such pages, xlogutils.c supposed that such pages must be corrupt and
      would throw an error.  This accounts for various reports of replication
      failures with "PANIC: WAL contains references to invalid pages".  To
      fix, add a ReadBufferMode value that instructs XLogReadBufferExtended
      not to complain when we're doing this.
      
      * btree_xlog_vacuum performed the extra locking if standbyState ==
      STANDBY_SNAPSHOT_READY, but that's not the correct test: we won't open up
      for hot standby queries until the database has reached consistency, and
      we don't want to do the extra locking till then either, for fear of reading
      corrupted pages (which bufmgr.c would complain about).  Fix by exporting a
      new function from xlog.c that will report whether we're actually in hot
      standby replay mode.
      
      * To ensure full coverage of the index in the replay scan, btvacuumscan
      would emit a dummy WAL record for the last page of the index, if no
      vacuuming work had been done on that page.  However, if the last page
      of the index is all-zero, that would result in corruption of said page,
      since the functions called on it weren't prepared to handle that case.
      There's no need to lock any such pages, so change the logic to target
      the last normal leaf page instead.
      
      The first two of these bugs were diagnosed by Andres Freund, the other one
      by me.  Fixes based on ideas from Heikki Linnakangas and myself.
      
      This has been wrong since Hot Standby was introduced, so back-patch to 9.0.
      061b079f
    • Robert Haas's avatar
      Documentation for test_shm_mq. · 16cad3e8
      Robert Haas authored
      Commit 4db3744f added this contrib
      module but neglected to document it.  Oops.
      16cad3e8
    • Robert Haas's avatar
      Mention that VACUUM FREEZE also effectively zeroes the table freeze age. · b6827094
      Robert Haas authored
      Maciek Sakrejda, reviewed by Amit Kapila
      b6827094
    • Robert Haas's avatar
      Fix typo in comment. · 246a9a8d
      Robert Haas authored
      Etsuro Fujita
      246a9a8d
    • Robert Haas's avatar
      Test code for shared memory message queue facility. · 4db3744f
      Robert Haas authored
      This code is intended as a demonstration of how the dynamic shared
      memory and dynamic background worker facilities can be used to establish
      a group of coooperating processes which can coordinate their activities
      using the shared memory message queue facility.  By itself, the code
      does nothing particularly interesting: it simply allows messages to
      be passed through a loop of workers and back to the original process.
      But it's a useful unit test, in addition to its demonstration value.
      4db3744f
    • Robert Haas's avatar
      Single-reader, single-writer, lightweight shared message queue. · ec9037df
      Robert Haas authored
      This code provides infrastructure for user backends to communicate
      relatively easily with background workers.  The message queue is
      structured as a ring buffer and allows messages of arbitary length
      to be sent and received.
      
      Patch by me.  Review by KaiGai Kohei and Andres Freund.
      ec9037df
    • Robert Haas's avatar
      Simple table of contents for a shared memory segment. · 6ddd5137
      Robert Haas authored
      This interface is intended to make it simple to divide a dynamic shared
      memory segment into different regions with distinct purposes.  It
      therefore serves much the same purpose that ShmemIndex accomplishes for
      the main shared memory segment, but it is intended to be more
      lightweight.
      
      Patch by me.  Review by Andres Freund.
      6ddd5137
  6. 13 Jan, 2014 7 commits