- 26 Dec, 2006 6 commits
-
-
Tom Lane authored
involving HashAggregate over SubqueryScan (this is the known case, there may well be more). The bug is only latent in releases before 8.2 since they didn't try to access tupletable slots' descriptors during ExecDropTupleTable. The least bogus fix seems to be to make subqueries share the parent query's memory context, so that tupdescs they create will have the same lifespan as those of the parent query. There are comments in the code envisioning going even further by not having a separate child EState at all, but that will require rethinking executor access to range tables, which I don't want to tackle right now. Per bug report from Jean-Pierre Pelletier.
-
Tom Lane authored
ps_TupFromTlist in plan nodes that make use of it. This was being done correctly in join nodes and Result nodes but not in any relation-scan nodes. Bug would lead to bogus results if a set-returning function appeared in the targetlist of a subquery that could be rescanned after partial execution, for example a subquery within EXISTS(). Bug has been around forever :-( ... surprising it wasn't reported before.
-
Tom Lane authored
were marked canSetTag. While it's certainly correct to return the result of the last one that is marked canSetTag, it's less clear what to do when none of them are. Since plpgsql will complain if zero is returned, the 8.2.0 behavior isn't good. I've fixed it to restore the prior behavior of returning the physically last query's result code when there are no canSetTag queries.
-
Tom Lane authored
-
Teodor Sigaev authored
-
Tatsuo Ishii authored
pgbench calls random() later, so it should have called srandom(). On most platforms except Windows srandom() is actually identical to srand(), so the bug only bites Windows users. per bug report from Akio Ishida.
-
- 24 Dec, 2006 4 commits
-
-
Tom Lane authored
operations during recent code refactoring). Per bug #2840 from Ned Crigler.
-
Tom Lane authored
Use a TRY block instead of (inadequate) ad-hoc coding to ensure that libxml is cleaned up after a failure. Report the intended SQLCODE instead of defaulting to XX000. Avoid risking use of a dangling pointer by keeping the persistent error buffer in TopMemoryContext. Be less trusting that error messages don't contain %. This patch doesn't do anything about changing the way the messages are put together --- this is just about mechanism.
-
Tom Lane authored
bletcherous and unsafe manipulation of global encoding setting. Clean up libxml reporting mechanism a bit (it still looks like a dangling-pointer crash waiting to happen, though, not to mention being far less than sane from a localization standpoint).
-
Tom Lane authored
the XmlExpr code in various lists, use a representation that has some hope of reverse-listing correctly (though it's still a de-escaping function shy of correctness), generally try to make it look more like Postgres coding conventions.
-
- 23 Dec, 2006 6 commits
-
-
Tom Lane authored
-
Bruce Momjian authored
-
Bruce Momjian authored
and UPDATE are clearly covered by the term.
-
Bruce Momjian authored
rather than being disallowed.
-
Bruce Momjian authored
require at least two characters for uniqueness. This now matches the behavior of other boolean strings we support, per report from Gurjeet Singh.
-
Tom Lane authored
cases. Operator classes now exist within "operator families". While most families are equivalent to a single class, related classes can be grouped into one family to represent the fact that they are semantically compatible. Cross-type operators are now naturally adjunct parts of a family, without having to wedge them into a particular opclass as we had done originally. This commit restructures the catalogs and cleans up enough of the fallout so that everything still works at least as well as before, but most of the work needed to actually improve the planner's behavior will come later. Also, there are not yet CREATE/DROP/ALTER OPERATOR FAMILY commands; the only way to create a new family right now is to allow CREATE OPERATOR CLASS to make one by default. I owe some more documentation work, too. But that can all be done in smaller pieces once this infrastructure is in place.
-
- 22 Dec, 2006 2 commits
-
-
Bruce Momjian authored
work effectively with open source communities.
-
Bruce Momjian authored
added.
-
- 21 Dec, 2006 4 commits
-
-
Peter Eisentraut authored
-
Peter Eisentraut authored
-
Teodor Sigaev authored
-
Peter Eisentraut authored
-
- 20 Dec, 2006 1 commit
-
-
Bruce Momjian authored
-
- 19 Dec, 2006 3 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
< o Improve xid wraparound detection by recording per-table rather < than per-database
-
Andrew Dunstan authored
Interpret a dbName param to PQsetdbLogin as a conninfo string if it contains an = sign. Tom Lane and Andrew Dunstan.
-
- 18 Dec, 2006 2 commits
-
-
Tom Lane authored
operator strategy numbers, ie, GiST and GIN. This is almost cosmetic enough to not need a catversion bump, but since the opr_sanity regression test has to change in sync with the catalog entry, I figured I'd better do one.
-
Andrew Dunstan authored
-
- 17 Dec, 2006 2 commits
-
-
Bruce Momjian authored
< While PostgreSQL clients runs fine limited-resource environments, the > While PostgreSQL clients runs fine in limited-resource environments, the
-
Bruce Momjian authored
< * Make CLUSTER preserve recently-dead tuples per MVCC requirements > o Make CLUSTER preserve recently-dead tuples per MVCC requirements
-
- 16 Dec, 2006 1 commit
-
-
Andrew Dunstan authored
-
- 15 Dec, 2006 9 commits
-
-
Tom Lane authored
are all in new-in-8.2 logic associated with indexability of ScalarArrayOpExpr (IN-clauses) or amortization of indexscan costs across repeated indexscans on the inside of a nestloop. In particular: Fix some logic errors in the estimation for multiple scans induced by a ScalarArrayOpExpr indexqual. Include a small cost component in bitmap index scans to reflect the costs of manipulating the bitmap itself; this is mainly to prevent a bitmap scan from appearing to have the same cost as a plain indexscan for fetching a single tuple. Also add a per-index-scan-startup CPU cost component; while prior releases were clearly too pessimistic about the cost of repeated indexscans, the original 8.2 coding allowed the cost of an indexscan to effectively go to zero if repeated often enough, which is overly optimistic. Pay some attention to index correlation when estimating costs for a nestloop inner indexscan: this is significant when the plan fetches multiple heap tuples per iteration, since high correlation means those tuples are probably on the same or adjacent heap pages.
-
Tom Lane authored
was removed in an unexplainable moment of brain fade.
-
Bruce Momjian authored
properly. Remove SGML docs about openjade performance patch, and instead add comment in style sheet where indenting code is commented out. Backpatch to 8.2.X.
-
Bruce Momjian authored
> > * Embedded server (not wanted) > > While PostgreSQL clients runs fine limited-resource environments, the > server requires multiple processes and a stable pool of resources to > run reliabily and efficiently. Stripping down the PostgreSQL server > to run in the same process address space as the client application > would add too much complexity and failure cases.
-
Bruce Momjian authored
< * Consider changing documentation from SGML to XML > * Consider changing documentation format from SGML to XML < http://archives.postgresql.org/pgsql-docs/2006-12/msg00033.php > http://archives.postgresql.org/pgsql-docs/2006-12/msg00152.php
-
Bruce Momjian authored
> > * Consider changing documentation from SGML to XML > > http://archives.postgresql.org/pgsql-docs/2006-12/msg00033.php >
-
Bruce Momjian authored
time.
-
Bruce Momjian authored
-
Bruce Momjian authored
correct, add comments about other multiple runs in the Makefile. Backpatch to 8.2.X.
-