Commit ff16b40f authored by Heikki Linnakangas's avatar Heikki Linnakangas

Report WAL flush, not insert, position in replication IDENTIFY_SYSTEM

When beginning streaming replication, the client usually issues the
IDENTIFY_SYSTEM command, which used to return the current WAL insert
position. That's not suitable for the intended purpose of that field,
however. pg_receivexlog uses it to start replication from the reported
point, but if it hasn't been flushed to disk yet, it will fail. Change
IDENTIFY_SYSTEM to report the flush position instead.

Backpatch to 9.1 and above. 9.0 doesn't report any WAL position.
parent 5ee5bc38
...@@ -1371,7 +1371,7 @@ The commands accepted in walsender mode are: ...@@ -1371,7 +1371,7 @@ The commands accepted in walsender mode are:
</term> </term>
<listitem> <listitem>
<para> <para>
Current xlog write location. Useful to get a known location in the Current xlog flush location. Useful to get a known location in the
transaction log where streaming can start. transaction log where streaming can start.
</para> </para>
</listitem> </listitem>
......
...@@ -316,7 +316,7 @@ IdentifySystem(void) ...@@ -316,7 +316,7 @@ IdentifySystem(void)
logptr = GetStandbyFlushRecPtr(); logptr = GetStandbyFlushRecPtr();
} }
else else
logptr = GetInsertRecPtr(); logptr = GetFlushRecPtr();
snprintf(tli, sizeof(tli), "%u", ThisTimeLineID); snprintf(tli, sizeof(tli), "%u", ThisTimeLineID);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment