Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
fa42b200
Commit
fa42b200
authored
Mar 02, 2017
by
Robert Haas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update comments overlooked by
2f5c9d9c
.
Tomas Vondra
parent
7f311213
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
9 deletions
+7
-9
src/backend/catalog/index.c
src/backend/catalog/index.c
+5
-5
src/backend/utils/cache/syscache.c
src/backend/utils/cache/syscache.c
+2
-4
No files found.
src/backend/catalog/index.c
View file @
fa42b200
...
...
@@ -1858,8 +1858,8 @@ index_update_stats(Relation rel,
* 1. In bootstrap mode, we have no choice --- UPDATE wouldn't work.
*
* 2. We could be reindexing pg_class itself, in which case we can't move
* its pg_class row because Catalog
UpdateIndexes might not know about all
* the indexes yet (see reindex_relation).
* its pg_class row because Catalog
TupleInsert/CatalogTupleUpdate might
*
not know about all
the indexes yet (see reindex_relation).
*
* 3. Because we execute CREATE INDEX with just share lock on the parent
* rel (to allow concurrent index creations), an ordinary update could
...
...
@@ -3542,9 +3542,9 @@ reindex_relation(Oid relid, int flags, int options)
* that the updates do not try to insert index entries into indexes we
* have not processed yet. (When we are trying to recover from corrupted
* indexes, that could easily cause a crash.) We can accomplish this
* because Catalog
UpdateIndexes will use the relcache's index list to know
*
which indexes to update. We just force the index list to be only the
* stuff we've processed.
* because Catalog
TupleInsert/CatalogTupleUpdate will use the relcache's
*
index list to know which indexes to update. We just force the index
*
list to be only the
stuff we've processed.
*
* It is okay to not insert entries into the indexes we have not processed
* yet because all of this is transaction-safe. If we fail partway
...
...
src/backend/utils/cache/syscache.c
View file @
fa42b200
...
...
@@ -100,10 +100,8 @@
adding/deleting caches only requires a recompile.)
Finally, any place your relation gets heap_insert() or
heap_update() calls, make sure there is a CatalogUpdateIndexes() or
similar call. The heap_* calls do not update indexes.
bjm 1999/11/22
heap_update() calls, use CatalogTupleInsert() or CatalogTupleUpdate()
instead, which also update indexes. The heap_* calls do not do that.
*---------------------------------------------------------------------------
*/
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment