Preliminary work for pgindent run.

Update typedefs.list from current buildfarm results.  Adjust pgindent's
typedef blacklist to block some more unfortunate typedef names that have
snuck in since last time.  Manually tweak a few places where I didn't
like the initial results of pgindent'ing.

contrib/pg_trgm/trgm_op.c

@@ -48,13 +48,13 @@ typedef struct
 
 /* Trigram bound type */
 typedef uint8 TrgmBound;
-#define TRGM_BOUND_LEFT				(0x01) /* trigram is left bound of word */
-#define TRGM_BOUND_RIGHT			(0x02) /* trigram is right bound of word */
+#define TRGM_BOUND_LEFT				0x01 /* trigram is left bound of word */
+#define TRGM_BOUND_RIGHT			0x02 /* trigram is right bound of word */
 
 /* Word similarity flags */
-#define WORD_SIMILARITY_CHECK_ONLY	(0x01) /* if set then only check existence
-											* of similar search pattern in text */
-#define WORD_SIMILARITY_STRICT		(0x02) /* force bounds of extent to match
+#define WORD_SIMILARITY_CHECK_ONLY	0x01 /* only check existence of similar
+										  * search pattern in text */
+#define WORD_SIMILARITY_STRICT		0x02 /* force bounds of extent to match
 										  * word bounds */
 
 /*

src/backend/libpq/be-secure-common.c

@@ -114,8 +114,8 @@ run_ssl_passphrase_command(const char *prompt, bool is_server_start, char *buf,
 
 	/* strip trailing newline */
 	len = strlen(buf);
-	if (buf[len - 1] == '\n')
-		buf[len-- -1] = '\0';
+	if (len > 0 && buf[len - 1] == '\n')
+		buf[--len] = '\0';
 
 error:
 	pfree(command.data);

src/include/storage/reinit.h

@@ -19,8 +19,8 @@
 
 
 extern void ResetUnloggedRelations(int op);
-extern bool parse_filename_for_nontemp_relation(
-	const char *name, int *oidchars, ForkNumber *fork);
+extern bool parse_filename_for_nontemp_relation(const char *name,
+												int *oidchars, ForkNumber *fork);
 
 #define UNLOGGED_RELATION_CLEANUP		0x0001
 #define UNLOGGED_RELATION_INIT			0x0002

src/port/pg_crc32c_armv8.c

@@ -29,17 +29,20 @@ pg_comp_crc32c_armv8(pg_crc32c crc, const void *data, size_t len)
 	 * significantly faster. Process leading bytes so that the loop below
 	 * starts with a pointer aligned to eight bytes.
 	 */
-	if (!PointerIsAligned(p, uint16) && p + 1 <= pend)
+	if (!PointerIsAligned(p, uint16) &&
+		p + 1 <= pend)
 	{
 		crc = __crc32cb(crc, *p);
 		p += 1;
 	}
-	if (!PointerIsAligned(p, uint32) && p + 2 <= pend)
+	if (!PointerIsAligned(p, uint32) &&
+		p + 2 <= pend)
 	{
 		crc = __crc32ch(crc, *(uint16 *) p);
 		p += 2;
 	}
-	if (!PointerIsAligned(p, uint64) && p + 4 <= pend)
+	if (!PointerIsAligned(p, uint64) &&
+		p + 4 <= pend)
 	{
 		crc = __crc32cw(crc, *(uint32 *) p);
 		p += 4;

src/tools/pgindent/pgindent

@@ -59,8 +59,10 @@ $excludes ||= "$code_base/src/tools/pgindent/exclude_file_patterns"
 # easier to configure.  Note that the typedefs need trailing newlines.
 my @whitelist = ("bool\n");
 
-my %blacklist = map { +"$_\n" => 1 } qw( FD_SET date interval timestamp ANY
-  abs allocfunc iterator other pointer printfunc reference string type );
+my %blacklist = map { +"$_\n" => 1 } qw(
+  ANY FD_SET U abs allocfunc boolean date digit ilist interval iterator other
+  pointer printfunc reference string timestamp type wrap
+);
 
 # globals
 my @files;