Commit ef777cb0 authored by Tomas Vondra's avatar Tomas Vondra

Remove unused variable in statext_mcv_serialize()

The itemlen variable used to be referenced in multiple places, but since
reworking the serialization code it's used only in one assert. Fixed by
removing the variable and calling the macro from the assert directly.

Backpatch to 12, where this code was introduced.

Reported-by: Jeff Janes
Discussion: https://postgr.es/m/CAMkU=1zc_ovH9NZd_9ovuiEWkF9yX06URUDdXCmgDydf-bqB5A@mail.gmail.com
parent 02e95a50
...@@ -911,10 +911,9 @@ statext_mcv_serialize(MCVList *mcvlist, VacAttrStats **stats) ...@@ -911,10 +911,9 @@ statext_mcv_serialize(MCVList *mcvlist, VacAttrStats **stats)
for (i = 0; i < mcvlist->nitems; i++) for (i = 0; i < mcvlist->nitems; i++)
{ {
MCVItem *mcvitem = &mcvlist->items[i]; MCVItem *mcvitem = &mcvlist->items[i];
int itemlen = ITEM_SIZE(dim);
/* don't write beyond the allocated space */ /* don't write beyond the allocated space */
Assert(ptr <= (endptr - itemlen)); Assert(ptr <= (endptr - ITEM_SIZE(dim)));
/* copy NULL and frequency flags into the serialized MCV */ /* copy NULL and frequency flags into the serialized MCV */
memcpy(ptr, mcvitem->isnull, sizeof(bool) * ndims); memcpy(ptr, mcvitem->isnull, sizeof(bool) * ndims);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment