Commit dcddc3f8 authored by Michael Paquier's avatar Michael Paquier

Revert "Prevent running pg_basebackup as root"

This reverts commit 7bae0ad9, as this is not ideal with the tar format,
and we may want to explore more options like what is done by tar with
some equivalents of --owner and --group, but for pg_basebackup.

Per complaints from Magnus Hagander and Stephen Frost.

Discussion: https://postgr.es/m/20200205172259.GW3195@tamriel.snowman.net
parent 414c2fd1
...@@ -2090,22 +2090,6 @@ main(int argc, char **argv) ...@@ -2090,22 +2090,6 @@ main(int argc, char **argv)
} }
} }
/*
* Don't allow pg_basebackup to be run as root, to avoid creating files in
* the data directory with ownership rights incompatible with the
* postmaster.
*/
#ifndef WIN32
if (geteuid() == 0) /* 0 is root's uid */
{
pg_log_error("cannot be run as root");
fprintf(stderr,
_("Please log in (using, e.g., \"su\") as the (unprivileged) user that will\n"
"own the server process.\n"));
exit(1);
}
#endif
atexit(cleanup_directories_atexit); atexit(cleanup_directories_atexit);
while ((c = getopt_long(argc, argv, "CD:F:r:RS:T:X:l:nNzZ:d:c:h:p:U:s:wWkvP", while ((c = getopt_long(argc, argv, "CD:F:r:RS:T:X:l:nNzZ:d:c:h:p:U:s:wWkvP",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment