Commit d38e8d30 authored by Tom Lane's avatar Tom Lane

Fix file descriptor leak after failure of a \setshell command in pgbench.

If the called command fails to return data, runShellCommand forgot to
pclose() the pipe before returning.  This is fairly harmless in the current
code, because pgbench would then abandon further processing of that client
thread; so no more than nclients descriptors could be leaked this way.  But
it's not hard to imagine future improvements whereby that wouldn't be true.
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.
parent c8315930
...@@ -958,6 +958,7 @@ runShellCommand(CState *st, char *variable, char **argv, int argc) ...@@ -958,6 +958,7 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
{ {
if (!timer_exceeded) if (!timer_exceeded)
fprintf(stderr, "%s: cannot read the result\n", argv[0]); fprintf(stderr, "%s: cannot read the result\n", argv[0]);
(void) pclose(fp);
return false; return false;
} }
if (pclose(fp) < 0) if (pclose(fp) < 0)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment