Skip to content

P
Postgres FD Implementation
Commit d00fbdc4 authored by Robert Haas's avatar Robert Haas
Browse files
Options

Fix use-after-ReleaseSysCache problem in ATExecAlterColumnType. 

Introduced by commit bbe0a81d.

Per buildfarm member prion.
parent bbe0a81d
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
src/backend/commands/tablecmds.c
View file @ d00fbdc4
...@@ -11953,8 +11953,6 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel, ...@@ -11953,8 +11953,6 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
attTup->attalign = tform->typalign; attTup->attalign = tform->typalign;
attTup->attstorage = tform->typstorage; attTup->attstorage = tform->typstorage;
ReleaseSysCache(typeTuple);
/* Setup attribute compression */ /* Setup attribute compression */
if (rel->rd_rel->relkind == RELKIND_RELATION || if (rel->rd_rel->relkind == RELKIND_RELATION ||
rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE) rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE)
...@@ -11972,6 +11970,8 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel, ...@@ -11972,6 +11970,8 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
else else
attTup->attcompression = InvalidCompressionMethod; attTup->attcompression = InvalidCompressionMethod;
ReleaseSysCache(typeTuple);
CatalogTupleUpdate(attrelation, &heapTup->t_self, heapTup); CatalogTupleUpdate(attrelation, &heapTup->t_self, heapTup);
table_close(attrelation, RowExclusiveLock); table_close(attrelation, RowExclusiveLock);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment