Commit c545e952 authored by Tom Lane's avatar Tom Lane

Don't prematurely cram a value into a short int.

Since a4d75c86, some buildfarm members have been warning that
		Assert(attnum <= MaxAttrNumber);
is useless if attnum is an AttrNumber.  I'm not certain how plausible
it is that the value coming out of the bitmap could actually exceed
MaxAttrNumber, but we seem to have thought that that was possible back
in 7300a699.  Revert the intermediate variable to int so that we have
the same overflow protection as before.
parent 3b0c647b
......@@ -978,7 +978,7 @@ build_attnums_array(Bitmapset *attrs, int nexprs, int *numattrs)
j = -1;
while ((j = bms_next_member(attrs, j)) >= 0)
{
AttrNumber attnum = (j - nexprs);
int attnum = (j - nexprs);
/*
* Make sure the bitmap contains only user-defined attributes. As
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment