pg_regress: Replace exit_nicely() with exit() plus atexit() hook

src/interfaces/ecpg/test/pg_regress_ecpg.c

@@ -34,13 +34,13 @@ ecpg_filter(const char *sourcefile, const char *outfile)
 	if (!s)
 	{
 		fprintf(stderr, "Could not open file %s for reading\n", sourcefile);
-		exit_nicely(2);
+		exit(2);
 	}
 	t = fopen(outfile, "w");
 	if (!t)
 	{
 		fprintf(stderr, "Could not open file %s for writing\n", outfile);
-		exit_nicely(2);
+		exit(2);
 	}
 
 	while (fgets(linebuf, LINEBUFSIZE, s))
@@ -148,7 +148,7 @@ ecpg_start_test(const char *testname,
 	{
 		fprintf(stderr, _("could not start process for test %s\n"),
 				testname);
-		exit_nicely(2);
+		exit(2);
 	}
 
 	free(outfile_stdout);

src/test/regress/pg_regress.h

@@ -56,6 +56,5 @@ int regression_main(int argc, char *argv[],
 				init_function ifunc, test_function tfunc);
 void		add_stringlist_item(_stringlist ** listhead, const char *str);
 PID_TYPE	spawn_process(const char *cmdline);
-void		exit_nicely(int code);
 void		replace_string(char *string, char *replace, char *replacement);
 bool		file_exists(const char *file);

src/test/regress/pg_regress_main.c

@@ -77,7 +77,7 @@ psql_start_test(const char *testname,
 	{
 		fprintf(stderr, _("could not start process for test %s\n"),
 				testname);
-		exit_nicely(2);
+		exit(2);
 	}
 
 	return pid;