Commit b1d79127 authored by Peter Geoghegan's avatar Peter Geoghegan

Correct obsolete UNION hash aggs comment.

Oversight in commit 1f39bce0, which added disk-based hash aggregation.

Backpatch: 13-, where disk-based hash aggregation was introduced.
parent f36e8207
...@@ -944,11 +944,10 @@ make_union_unique(SetOperationStmt *op, Path *path, List *tlist, ...@@ -944,11 +944,10 @@ make_union_unique(SetOperationStmt *op, Path *path, List *tlist,
/* /*
* XXX for the moment, take the number of distinct groups as equal to the * XXX for the moment, take the number of distinct groups as equal to the
* total input size, ie, the worst case. This is too conservative, but we * total input size, ie, the worst case. This is too conservative, but
* don't want to risk having the hashtable overrun memory; also, it's not * it's not clear how to get a decent estimate of the true size. One
* clear how to get a decent estimate of the true size. One should note * should note as well the propensity of novices to write UNION rather
* as well the propensity of novices to write UNION rather than UNION ALL * than UNION ALL even when they don't expect any duplicates...
* even when they don't expect any duplicates...
*/ */
dNumGroups = path->rows; dNumGroups = path->rows;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment