Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
ad10853b
Commit
ad10853b
authored
Jan 29, 2012
by
Tom Lane
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Assorted comment fixes, mostly just typos, but some obsolete statements.
YAMAMOTO Takashi
parent
dd243b3e
Changes
11
Hide whitespace changes
Inline
Side-by-side
Showing
11 changed files
with
24 additions
and
20 deletions
+24
-20
src/backend/access/gist/gist.c
src/backend/access/gist/gist.c
+1
-1
src/backend/access/gist/gistproc.c
src/backend/access/gist/gistproc.c
+2
-1
src/backend/access/gist/gistsplit.c
src/backend/access/gist/gistsplit.c
+7
-7
src/backend/access/gist/gistutil.c
src/backend/access/gist/gistutil.c
+3
-3
src/backend/access/gist/gistvacuum.c
src/backend/access/gist/gistvacuum.c
+1
-1
src/backend/access/transam/clog.c
src/backend/access/transam/clog.c
+4
-3
src/backend/access/transam/slru.c
src/backend/access/transam/slru.c
+2
-0
src/backend/executor/nodeWindowAgg.c
src/backend/executor/nodeWindowAgg.c
+1
-1
src/backend/storage/ipc/procarray.c
src/backend/storage/ipc/procarray.c
+1
-1
src/backend/utils/hash/hashfn.c
src/backend/utils/hash/hashfn.c
+1
-1
src/include/access/gist.h
src/include/access/gist.h
+1
-1
No files found.
src/backend/access/gist/gist.c
View file @
ad10853b
...
@@ -253,7 +253,7 @@ gistplacetopage(Relation rel, Size freespace, GISTSTATE *giststate,
...
@@ -253,7 +253,7 @@ gistplacetopage(Relation rel, Size freespace, GISTSTATE *giststate,
}
}
/*
/*
* Now that we know whic
k
blocks the new pages go to, set up downlink
* Now that we know whic
h
blocks the new pages go to, set up downlink
* tuples to point to them.
* tuples to point to them.
*/
*/
for
(
ptr
=
dist
;
ptr
;
ptr
=
ptr
->
next
)
for
(
ptr
=
dist
;
ptr
;
ptr
=
ptr
->
next
)
...
...
src/backend/access/gist/gistproc.c
View file @
ad10853b
/*-------------------------------------------------------------------------
/*-------------------------------------------------------------------------
*
*
* gistproc.c
* gistproc.c
* Support procedures for GiSTs over 2-D objects (boxes, polygons, circles).
* Support procedures for GiSTs over 2-D objects (boxes, polygons, circles,
* points).
*
*
* This gives R-tree behavior, with Guttman's poly-time split algorithm.
* This gives R-tree behavior, with Guttman's poly-time split algorithm.
*
*
...
...
src/backend/access/gist/gistsplit.c
View file @
ad10853b
...
@@ -29,7 +29,7 @@ typedef struct
...
@@ -29,7 +29,7 @@ typedef struct
/*
/*
* Forms unions of subkeys after page split, but
* Forms unions of subkeys after page split, but
* uses only tuples
aren't in groups of equ
alent tuples
* uses only tuples
that aren't in groups of equiv
alent tuples
*/
*/
static
void
static
void
gistunionsubkeyvec
(
GISTSTATE
*
giststate
,
IndexTuple
*
itvec
,
gistunionsubkeyvec
(
GISTSTATE
*
giststate
,
IndexTuple
*
itvec
,
...
@@ -200,8 +200,8 @@ do { \
...
@@ -200,8 +200,8 @@ do { \
/*
/*
* adjust left and right unions according to splits by previous
* adjust left and right unions according to splits by previous
* split by first
s
columns. This function is called only in case
* split by first columns. This function is called only in case
* when pickSplit doesn't support subsp
p
lit.
* when pickSplit doesn't support subsplit.
*/
*/
static
void
static
void
...
@@ -503,8 +503,8 @@ gistSplitHalf(GIST_SPLITVEC *v, int len)
...
@@ -503,8 +503,8 @@ gistSplitHalf(GIST_SPLITVEC *v, int len)
}
}
/*
/*
* tr
ys to split page by attno key, in a
case of null
* tr
ies to split page by attno key, in
case of null
* values move
its
to separate page.
* values move
those
to separate page.
*/
*/
void
void
gistSplitByKey
(
Relation
r
,
Page
page
,
IndexTuple
*
itup
,
int
len
,
GISTSTATE
*
giststate
,
gistSplitByKey
(
Relation
r
,
Page
page
,
IndexTuple
*
itup
,
int
len
,
GISTSTATE
*
giststate
,
...
@@ -531,7 +531,7 @@ gistSplitByKey(Relation r, Page page, IndexTuple *itup, int len, GISTSTATE *gist
...
@@ -531,7 +531,7 @@ gistSplitByKey(Relation r, Page page, IndexTuple *itup, int len, GISTSTATE *gist
{
{
/*
/*
* Corner case: All keys in attno column are null, we should try to
* Corner case: All keys in attno column are null, we should try to
* split by keys in next column. I
t
all keys in all columns are NULL
* split by keys in next column. I
f
all keys in all columns are NULL
* just split page half by half
* just split page half by half
*/
*/
v
->
spl_risnull
[
attno
]
=
v
->
spl_lisnull
[
attno
]
=
TRUE
;
v
->
spl_risnull
[
attno
]
=
v
->
spl_lisnull
[
attno
]
=
TRUE
;
...
@@ -582,7 +582,7 @@ gistSplitByKey(Relation r, Page page, IndexTuple *itup, int len, GISTSTATE *gist
...
@@ -582,7 +582,7 @@ gistSplitByKey(Relation r, Page page, IndexTuple *itup, int len, GISTSTATE *gist
{
{
/*
/*
* simple case: left and right keys for attno column are
* simple case: left and right keys for attno column are
* equ
i
al
* equal
*/
*/
gistSplitByKey
(
r
,
page
,
itup
,
len
,
giststate
,
v
,
entryvec
,
attno
+
1
);
gistSplitByKey
(
r
,
page
,
itup
,
len
,
giststate
,
v
,
entryvec
,
attno
+
1
);
}
}
...
...
src/backend/access/gist/gistutil.c
View file @
ad10853b
...
@@ -22,7 +22,7 @@
...
@@ -22,7 +22,7 @@
#include "utils/builtins.h"
#include "utils/builtins.h"
/*
/*
* static *S used for tem
r
orary storage (saves stack and palloc() call)
* static *S used for tem
p
orary storage (saves stack and palloc() call)
*/
*/
static
Datum
attrS
[
INDEX_MAX_KEYS
];
static
Datum
attrS
[
INDEX_MAX_KEYS
];
...
@@ -148,8 +148,8 @@ gistfillitupvec(IndexTuple *vec, int veclen, int *memlen)
...
@@ -148,8 +148,8 @@ gistfillitupvec(IndexTuple *vec, int veclen, int *memlen)
}
}
/*
/*
* Make unions of keys in IndexTuple vector
, return FALSE if itvec contains
* Make unions of keys in IndexTuple vector
.
*
invalid tuple.
Resulting Datums aren't compressed.
* Resulting Datums aren't compressed.
*/
*/
void
void
...
...
src/backend/access/gist/gistvacuum.c
View file @
ad10853b
...
@@ -131,7 +131,7 @@ pushStackIfSplited(Page page, GistBDItem *stack)
...
@@ -131,7 +131,7 @@ pushStackIfSplited(Page page, GistBDItem *stack)
/*
/*
* Bulk deletion of all index entries pointing to a set of heap tuples and
* Bulk deletion of all index entries pointing to a set of heap tuples and
* check invalid tuples
after crash recovery
.
* check invalid tuples
left after upgrade
.
* The set of target tuples is specified via a callback routine that tells
* The set of target tuples is specified via a callback routine that tells
* whether any given heap tuple (identified by ItemPointer) is being deleted.
* whether any given heap tuple (identified by ItemPointer) is being deleted.
*
*
...
...
src/backend/access/transam/clog.c
View file @
ad10853b
...
@@ -44,9 +44,10 @@
...
@@ -44,9 +44,10 @@
*
*
* Note: because TransactionIds are 32 bits and wrap around at 0xFFFFFFFF,
* Note: because TransactionIds are 32 bits and wrap around at 0xFFFFFFFF,
* CLOG page numbering also wraps around at 0xFFFFFFFF/CLOG_XACTS_PER_PAGE,
* CLOG page numbering also wraps around at 0xFFFFFFFF/CLOG_XACTS_PER_PAGE,
* and CLOG segment numbering at 0xFFFFFFFF/CLOG_XACTS_PER_SEGMENT. We need
* and CLOG segment numbering at
* take no explicit notice of that fact in this module, except when comparing
* 0xFFFFFFFF/CLOG_XACTS_PER_PAGE/SLRU_PAGES_PER_SEGMENT. We need take no
* segment and page numbers in TruncateCLOG (see CLOGPagePrecedes).
* explicit notice of that fact in this module, except when comparing segment
* and page numbers in TruncateCLOG (see CLOGPagePrecedes).
*/
*/
/* We need two bits per xact, so four xacts fit in a byte */
/* We need two bits per xact, so four xacts fit in a byte */
...
...
src/backend/access/transam/slru.c
View file @
ad10853b
...
@@ -280,6 +280,8 @@ SimpleLruZeroPage(SlruCtl ctl, int pageno)
...
@@ -280,6 +280,8 @@ SimpleLruZeroPage(SlruCtl ctl, int pageno)
* in a page from disk into an existing buffer. (Such an old page cannot
* in a page from disk into an existing buffer. (Such an old page cannot
* have any interesting LSNs, since we'd have flushed them before writing
* have any interesting LSNs, since we'd have flushed them before writing
* the page in the first place.)
* the page in the first place.)
*
* This assumes that InvalidXLogRecPtr is bitwise-all-0.
*/
*/
static
void
static
void
SimpleLruZeroLSNs
(
SlruCtl
ctl
,
int
slotno
)
SimpleLruZeroLSNs
(
SlruCtl
ctl
,
int
slotno
)
...
...
src/backend/executor/nodeWindowAgg.c
View file @
ad10853b
...
@@ -1668,7 +1668,7 @@ ExecEndWindowAgg(WindowAggState *node)
...
@@ -1668,7 +1668,7 @@ ExecEndWindowAgg(WindowAggState *node)
}
}
/* -----------------
/* -----------------
* ExecRe
s
canWindowAgg
* ExecRe
S
canWindowAgg
* -----------------
* -----------------
*/
*/
void
void
...
...
src/backend/storage/ipc/procarray.c
View file @
ad10853b
...
@@ -1214,7 +1214,7 @@ GetMaxSnapshotSubxidCount(void)
...
@@ -1214,7 +1214,7 @@ GetMaxSnapshotSubxidCount(void)
*
*
* We also update the following backend-global variables:
* We also update the following backend-global variables:
* TransactionXmin: the oldest xmin of any snapshot in use in the
* TransactionXmin: the oldest xmin of any snapshot in use in the
* current transaction (this is the same as MyP
roc
->xmin).
* current transaction (this is the same as MyP
gXact
->xmin).
* RecentXmin: the xmin computed for the most recent snapshot. XIDs
* RecentXmin: the xmin computed for the most recent snapshot. XIDs
* older than this are known not running any more.
* older than this are known not running any more.
* RecentGlobalXmin: the global xmin (oldest TransactionXmin across all
* RecentGlobalXmin: the global xmin (oldest TransactionXmin across all
...
...
src/backend/utils/hash/hashfn.c
View file @
ad10853b
...
@@ -25,7 +25,7 @@
...
@@ -25,7 +25,7 @@
/*
/*
* string_hash: hash function for keys that are
null
-terminated strings.
* string_hash: hash function for keys that are
NUL
-terminated strings.
*
*
* NOTE: this is the default hash function if none is specified.
* NOTE: this is the default hash function if none is specified.
*/
*/
...
...
src/include/access/gist.h
View file @
ad10853b
...
@@ -89,7 +89,7 @@ typedef GISTPageOpaqueData *GISTPageOpaque;
...
@@ -89,7 +89,7 @@ typedef GISTPageOpaqueData *GISTPageOpaque;
* that corresponding spl_(r|l)datum already defined and
* that corresponding spl_(r|l)datum already defined and
* PickSplit should use that value. PickSplit should always set
* PickSplit should use that value. PickSplit should always set
* spl_(r|l)datum_exists to false: GiST will check value to
* spl_(r|l)datum_exists to false: GiST will check value to
* control supportng this feature by PickSplit...
* control support
i
ng this feature by PickSplit...
*/
*/
typedef
struct
GIST_SPLITVEC
typedef
struct
GIST_SPLITVEC
{
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment