Fix memory leak in tar file padding

Spotted by Coverity, patch by Michael Paquier

Fix memory leak in tar file padding
Spotted by Coverity, patch by Michael Paquier
a775406e · Magnus Hagander · d4b5d4ca · a775406e
Commit a775406e authored Oct 30, 2016 by Magnus Hagander
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

src/bin/pg_basebackup/walmethods.c src/bin/pg_basebackup/walmethods.c +5 -0

No files found.
--- a/src/bin/pg_basebackup/walmethods.c
+++ b/src/bin/pg_basebackup/walmethods.c
@@ -442,9 +442,14 @@ tar_write_padding_data(TarMethodFile * f, size_t bytes)
 		ssize_t		r = tar_write(f, zerobuf, bytestowrite);

 		if (r < 0)
+		{
+			pg_free(zerobuf);
 			return false;
+		}
 		bytesleft -= r;
 	}
+
+	pg_free(zerobuf);
 	return true;
 }