Commit a65e17bd authored by Tom Lane's avatar Tom Lane

Reduce chattiness of genbki.pl and Gen_fmgrtab.pl.

Make these scripts emit just one log message when they run, not one
per output file.  The latter is way too verbose in the wake of
commit 372728b0.  The specific wording used is what already existed
in the MSVC scripts.

John Naylor

Discussion: https://postgr.es/m/11103.1523208822@sss.pgh.pa.us
parent 2cdf359f
...@@ -340,7 +340,6 @@ sub RenameTempFile ...@@ -340,7 +340,6 @@ sub RenameTempFile
my $final_name = shift; my $final_name = shift;
my $extension = shift; my $extension = shift;
my $temp_name = $final_name . $extension; my $temp_name = $final_name . $extension;
print "Writing $final_name\n";
rename($temp_name, $final_name) || die "rename: $temp_name: $!"; rename($temp_name, $final_name) || die "rename: $temp_name: $!";
} }
......
...@@ -217,6 +217,7 @@ my %lookup_kind = ( ...@@ -217,6 +217,7 @@ my %lookup_kind = (
# Generate postgres.bki, postgres.description, postgres.shdescription, # Generate postgres.bki, postgres.description, postgres.shdescription,
# and pg_*_d.h headers. # and pg_*_d.h headers.
print "Generating BKI files and symbol definition headers...\n";
# version marker for .bki file # version marker for .bki file
print $bki "# PostgreSQL $major_version\n"; print $bki "# PostgreSQL $major_version\n";
......
...@@ -84,6 +84,8 @@ my $FirstBootstrapObjectId = Catalog::FindDefinedSymbol( ...@@ -84,6 +84,8 @@ my $FirstBootstrapObjectId = Catalog::FindDefinedSymbol(
my $INTERNALlanguageId = Catalog::FindDefinedSymbolFromData( my $INTERNALlanguageId = Catalog::FindDefinedSymbolFromData(
$catalog_data{pg_language}, 'INTERNALlanguageId'); $catalog_data{pg_language}, 'INTERNALlanguageId');
print "Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h...\n";
# Collect certain fields from pg_proc.dat. # Collect certain fields from pg_proc.dat.
my @fmgr = (); my @fmgr = ();
......
...@@ -275,7 +275,6 @@ s{PG_VERSION_STR "[^"]+"}{PG_VERSION_STR "PostgreSQL $self->{strver}$extraver, c ...@@ -275,7 +275,6 @@ s{PG_VERSION_STR "[^"]+"}{PG_VERSION_STR "PostgreSQL $self->{strver}$extraver, c
'fmgrtab.c', '../../../src/include/access/transam.h') 'fmgrtab.c', '../../../src/include/access/transam.h')
) )
{ {
print "Generating fmgrtab.c, fmgroids.h, fmgrprotos.h...\n";
system( system(
"perl -I ../catalog Gen_fmgrtab.pl -I../../../src/include/ $pg_language_dat $pg_proc_dat"); "perl -I ../catalog Gen_fmgrtab.pl -I../../../src/include/ $pg_language_dat $pg_proc_dat");
} }
...@@ -479,7 +478,6 @@ EOF ...@@ -479,7 +478,6 @@ EOF
'src/backend/catalog/postgres.bki', 'src/backend/catalog/postgres.bki',
"src/include/catalog/$bki")) "src/include/catalog/$bki"))
{ {
print "Generating BKI files and symbol definition headers...\n";
chdir('src/backend/catalog'); chdir('src/backend/catalog');
my $bki_srcs = join(' ../../../src/include/catalog/', @bki_srcs); my $bki_srcs = join(' ../../../src/include/catalog/', @bki_srcs);
system("perl genbki.pl --set-version=$self->{majorver} $bki_srcs"); system("perl genbki.pl --set-version=$self->{majorver} $bki_srcs");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment