Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
93507e67
Commit
93507e67
authored
Jan 21, 2019
by
Andres Freund
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adjust some more comments for WITH OIDS removal.
I missed these in
578b2297
. Author: Andres Freund
parent
8eb4a931
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
11 deletions
+8
-11
src/backend/access/heap/heapam.c
src/backend/access/heap/heapam.c
+8
-11
No files found.
src/backend/access/heap/heapam.c
View file @
93507e67
...
...
@@ -2451,11 +2451,10 @@ ReleaseBulkInsertStatePin(BulkInsertState bistate)
* The BulkInsertState object (if any; bistate can be NULL for default
* behavior) is also just passed through to RelationGetBufferForTuple.
*
* The return value is the OID assigned to the tuple (either here or by the
* caller), or InvalidOid if no OID. The header fields of *tup are updated
* to match the stored tuple; in particular tup->t_self receives the actual
* TID where the tuple was stored. But note that any toasting of fields
* within the tuple data is NOT reflected into *tup.
* On return the header fields of *tup are updated to match the stored tuple;
* in particular tup->t_self receives the actual TID where the tuple was
* stored. But note that any toasting of fields within the tuple data is NOT
* reflected into *tup.
*/
void
heap_insert
(
Relation
relation
,
HeapTuple
tup
,
CommandId
cid
,
...
...
@@ -2468,8 +2467,7 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid,
bool
all_visible_cleared
=
false
;
/*
* Fill in tuple header fields, assign an OID, and toast the tuple if
* necessary.
* Fill in tuple header fields and toast the tuple if necessary.
*
* Note: below this point, heaptup is the data we actually intend to store
* into the relation; tup is the caller's original untoasted data.
...
...
@@ -2635,10 +2633,9 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid,
/*
* Subroutine for heap_insert(). Prepares a tuple for insertion. This sets the
* tuple header fields, assigns an OID, and toasts the tuple if necessary.
* Returns a toasted version of the tuple if it was toasted, or the original
* tuple if not. Note that in any case, the header fields are also set in
* the original tuple.
* tuple header fields and toasts the tuple if necessary. Returns a toasted
* version of the tuple if it was toasted, or the original tuple if not. Note
* that in any case, the header fields are also set in the original tuple.
*/
static
HeapTuple
heap_prepare_insert
(
Relation
relation
,
HeapTuple
tup
,
TransactionId
xid
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment