Commit 8ea91ba1 authored by Neil Conway's avatar Neil Conway

Minor code clarity improvement: AFAICS, estate.eval_econtext must be

non-NULL during the guts of plpgsql_exec_trigger() and
plpgsql_exec_function(). Therefore, we can remove the NULL check,
per discussion on -patches.
parent ce8fd39e
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
* procedural language * procedural language
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.159 2006/01/03 22:48:10 tgl Exp $ * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.160 2006/01/10 18:50:43 neilc Exp $
* *
* This software is copyrighted by Jan Wieck - Hamburg. * This software is copyrighted by Jan Wieck - Hamburg.
* *
...@@ -414,8 +414,7 @@ plpgsql_exec_function(PLpgSQL_function *func, FunctionCallInfo fcinfo) ...@@ -414,8 +414,7 @@ plpgsql_exec_function(PLpgSQL_function *func, FunctionCallInfo fcinfo)
} }
/* Clean up any leftover temporary memory */ /* Clean up any leftover temporary memory */
if (estate.eval_econtext != NULL) FreeExprContext(estate.eval_econtext);
FreeExprContext(estate.eval_econtext);
estate.eval_econtext = NULL; estate.eval_econtext = NULL;
exec_eval_cleanup(&estate); exec_eval_cleanup(&estate);
...@@ -646,8 +645,7 @@ plpgsql_exec_trigger(PLpgSQL_function *func, ...@@ -646,8 +645,7 @@ plpgsql_exec_trigger(PLpgSQL_function *func,
} }
/* Clean up any leftover temporary memory */ /* Clean up any leftover temporary memory */
if (estate.eval_econtext != NULL) FreeExprContext(estate.eval_econtext);
FreeExprContext(estate.eval_econtext);
estate.eval_econtext = NULL; estate.eval_econtext = NULL;
exec_eval_cleanup(&estate); exec_eval_cleanup(&estate);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment