Commit 8bdd6f56 authored by Andrew Dunstan's avatar Andrew Dunstan

Use a more portable way to get the version string in PostgresNode

Older versions of perl on Windows don't like the list form of pipe open,
and perlcritic doesn't like the string form of open, so we avoid both
with a simpler formulation using qx{}.

Per complaint from Amit Kapila.
parent 413c1ef9
......@@ -1248,10 +1248,8 @@ sub _set_pg_version
local %ENV = $self->_get_env();
# We only want the version field
open my $fh, "-|", $pg_config, "--version"
or BAIL_OUT("$pg_config failed: $!");
my $version_line = <$fh>;
close $fh or die;
my $version_line = qx{$pg_config --version};
BAIL_OUT("$pg_config failed: $!") if $?;
$self->{_pg_version} = PostgresVersion->new($version_line);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment