Commit 8a934d67 authored by Andres Freund's avatar Andres Freund

Use isinf builtin for clang, for performance.

When compiling with clang glibc's definition of isinf() ends up
leading to and external libc function call. That's because there was a
bug in the builtin in an old gcc version, and clang claims
compatibility with an older version.  That causes clang to be
measurably slower for floating point heavy workloads than gcc.

To fix simply redirect isinf when using clang and clang confirms it
has __builtin_isinf().
parent 266b6acb
...@@ -343,7 +343,20 @@ extern int getpeereid(int sock, uid_t *uid, gid_t *gid); ...@@ -343,7 +343,20 @@ extern int getpeereid(int sock, uid_t *uid, gid_t *gid);
#ifndef HAVE_ISINF #ifndef HAVE_ISINF
extern int isinf(double x); extern int isinf(double x);
#endif #else
/*
* Glibc doesn't use the builtin for clang due to a *gcc* bug in a version
* newer than the gcc compatibility clang claims to have. This would cause a
* *lot* of superflous function calls, therefore revert when using clang.
*/
#ifdef __clang__
/* needs to be separate to not confuse other compilers */
#if __has_builtin(__builtin_isinf)
#undef isinf
#define isinf __builtin_isinf
#endif /* __has_builtin(isinf) */
#endif /* __clang__ */
#endif /* !HAVE_ISINF */
#ifndef HAVE_MKDTEMP #ifndef HAVE_MKDTEMP
extern char *mkdtemp(char *path); extern char *mkdtemp(char *path);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment