Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
887248e9
Commit
887248e9
authored
5 years ago
by
Peter Eisentraut
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Message style fixes
parent
467c1d91
Changes
11
Hide whitespace changes
Inline
Side-by-side
Showing
11 changed files
with
23 additions
and
21 deletions
+23
-21
contrib/test_decoding/expected/slot.out
contrib/test_decoding/expected/slot.out
+1
-1
src/backend/access/transam/xlog.c
src/backend/access/transam/xlog.c
+1
-1
src/backend/access/transam/xlogfuncs.c
src/backend/access/transam/xlogfuncs.c
+1
-1
src/backend/catalog/pg_aggregate.c
src/backend/catalog/pg_aggregate.c
+2
-2
src/backend/libpq/auth.c
src/backend/libpq/auth.c
+1
-1
src/backend/replication/basebackup.c
src/backend/replication/basebackup.c
+5
-3
src/backend/replication/slotfuncs.c
src/backend/replication/slotfuncs.c
+1
-1
src/backend/storage/file/fd.c
src/backend/storage/file/fd.c
+2
-2
src/backend/utils/adt/ri_triggers.c
src/backend/utils/adt/ri_triggers.c
+1
-1
src/backend/utils/misc/guc.c
src/backend/utils/misc/guc.c
+3
-3
src/test/regress/expected/foreign_key.out
src/test/regress/expected/foreign_key.out
+5
-5
No files found.
contrib/test_decoding/expected/slot.out
View file @
887248e9
...
...
@@ -141,7 +141,7 @@ SELECT slot_name FROM pg_create_physical_replication_slot('regression_slot3');
(1 row)
SELECT pg_replication_slot_advance('regression_slot3', '0/0'); -- invalid LSN
ERROR: invalid target
wal lsn
ERROR: invalid target
WAL LSN
SELECT pg_replication_slot_advance('regression_slot3', '0/1'); -- error
ERROR: cannot advance replication slot that has not previously reserved WAL
SELECT pg_drop_replication_slot('regression_slot3');
...
...
This diff is collapsed.
Click to expand it.
src/backend/access/transam/xlog.c
View file @
887248e9
...
...
@@ -11297,7 +11297,7 @@ read_backup_label(XLogRecPtr *checkPointLoc, bool *backupEndRequired,
ereport
(
FATAL
,
(
errcode
(
ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE
),
errmsg
(
"invalid data in file
\"
%s
\"
"
,
BACKUP_LABEL_FILE
),
errdetail
(
"Timeline ID parsed is %u, but expected %u"
,
errdetail
(
"Timeline ID parsed is %u, but expected %u
.
"
,
tli_from_file
,
tli_from_walseg
)));
ereport
(
DEBUG1
,
...
...
This diff is collapsed.
Click to expand it.
src/backend/access/transam/xlogfuncs.c
View file @
887248e9
...
...
@@ -726,7 +726,7 @@ pg_promote(PG_FUNCTION_ARGS)
if
(
wait_seconds
<=
0
)
ereport
(
ERROR
,
(
errcode
(
ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE
),
errmsg
(
"
\"
wait_seconds
\"
cannot be negative or equal
zero"
)));
errmsg
(
"
\"
wait_seconds
\"
must not be negative or
zero"
)));
/* create the promote signal file */
promote_file
=
AllocateFile
(
PROMOTE_SIGNAL_FILE
,
"w"
);
...
...
This diff is collapsed.
Click to expand it.
src/backend/catalog/pg_aggregate.c
View file @
887248e9
...
...
@@ -116,7 +116,7 @@ AggregateCreate(const char *aggName,
elog
(
ERROR
,
"aggregate must have a transition function"
);
if
(
numDirectArgs
<
0
||
numDirectArgs
>
numArgs
)
elog
(
ERROR
,
"incorrect number of direct args for aggregate"
);
elog
(
ERROR
,
"incorrect number of direct arg
ument
s for aggregate"
);
/*
* Aggregates can have at most FUNC_MAX_ARGS-1 args, else the transfn
...
...
@@ -711,7 +711,7 @@ AggregateCreate(const char *aggName,
if
(
numDirectArgs
!=
oldagg
->
aggnumdirectargs
)
ereport
(
ERROR
,
(
errcode
(
ERRCODE_INVALID_FUNCTION_DEFINITION
),
errmsg
(
"cannot change number of direct args of an aggregate function"
)));
errmsg
(
"cannot change number of direct arg
ument
s of an aggregate function"
)));
replaces
[
Anum_pg_aggregate_aggfnoid
-
1
]
=
false
;
replaces
[
Anum_pg_aggregate_aggkind
-
1
]
=
false
;
...
...
This diff is collapsed.
Click to expand it.
src/backend/libpq/auth.c
View file @
887248e9
...
...
@@ -2859,7 +2859,7 @@ CheckCertAuth(Port *port)
if
(
port
->
hba
->
clientcert
==
clientCertFull
&&
port
->
hba
->
auth_method
!=
uaCert
)
{
ereport
(
LOG
,
(
errmsg
(
"certificate validation (clientcert=verify-full) failed for user
\"
%s
\"
:
cn
mismatch"
,
(
errmsg
(
"certificate validation (clientcert=verify-full) failed for user
\"
%s
\"
:
CN
mismatch"
,
port
->
user_name
)));
}
}
...
...
This diff is collapsed.
Click to expand it.
src/backend/replication/basebackup.c
View file @
887248e9
...
...
@@ -1442,7 +1442,7 @@ sendFile(const char *readfilename, const char *tarfilename, struct stat *statbuf
if
(
verify_checksum
&&
(
cnt
%
BLCKSZ
!=
0
))
{
ereport
(
WARNING
,
(
errmsg
(
"c
an
not verify checksum in file
\"
%s
\"
, block "
(
errmsg
(
"c
ould
not verify checksum in file
\"
%s
\"
, block "
"%d: read buffer size %d and page size %d "
"differ"
,
readfilename
,
blkno
,
(
int
)
cnt
,
BLCKSZ
)));
...
...
@@ -1599,8 +1599,10 @@ sendFile(const char *readfilename, const char *tarfilename, struct stat *statbuf
if
(
checksum_failures
>
1
)
{
ereport
(
WARNING
,
(
errmsg
(
"file
\"
%s
\"
has a total of %d checksum verification "
"failures"
,
readfilename
,
checksum_failures
)));
(
errmsg_plural
(
"file
\"
%s
\"
has a total of %d checksum verification failure"
,
"file
\"
%s
\"
has a total of %d checksum verification failures"
,
checksum_failures
,
readfilename
,
checksum_failures
)));
pgstat_report_checksum_failures_in_db
(
dboid
,
checksum_failures
);
}
...
...
This diff is collapsed.
Click to expand it.
src/backend/replication/slotfuncs.c
View file @
887248e9
...
...
@@ -523,7 +523,7 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS)
if
(
XLogRecPtrIsInvalid
(
moveto
))
ereport
(
ERROR
,
(
errmsg
(
"invalid target
wal lsn
"
)));
(
errmsg
(
"invalid target
WAL LSN
"
)));
/* Build a tuple descriptor for our result type */
if
(
get_call_result_type
(
fcinfo
,
NULL
,
&
tupdesc
)
!=
TYPEFUNC_COMPOSITE
)
...
...
This diff is collapsed.
Click to expand it.
src/backend/storage/file/fd.c
View file @
887248e9
...
...
@@ -1686,7 +1686,7 @@ PathNameDeleteTemporaryFile(const char *path, bool error_on_failure)
if
(
errno
!=
ENOENT
)
ereport
(
error_on_failure
?
ERROR
:
LOG
,
(
errcode_for_file_access
(),
errmsg
(
"c
an
not unlink temporary file
\"
%s
\"
: %m"
,
errmsg
(
"c
ould
not unlink temporary file
\"
%s
\"
: %m"
,
path
)));
return
false
;
}
...
...
@@ -3322,7 +3322,7 @@ unlink_if_exists_fname(const char *fname, bool isdir, int elevel)
if
(
rmdir
(
fname
)
!=
0
&&
errno
!=
ENOENT
)
ereport
(
elevel
,
(
errcode_for_file_access
(),
errmsg
(
"could not r
mdir
directory
\"
%s
\"
: %m"
,
fname
)));
errmsg
(
"could not r
emove
directory
\"
%s
\"
: %m"
,
fname
)));
}
else
{
...
...
This diff is collapsed.
Click to expand it.
src/backend/utils/adt/ri_triggers.c
View file @
887248e9
...
...
@@ -2456,7 +2456,7 @@ ri_ReportViolation(const RI_ConstraintInfo *riinfo,
errmsg
(
"removing partition
\"
%s
\"
violates foreign key constraint
\"
%s
\"
"
,
RelationGetRelationName
(
pk_rel
),
NameStr
(
riinfo
->
conname
)),
errdetail
(
"Key (%s)=(%s) still referenced from table
\"
%s
\"
."
,
errdetail
(
"Key (%s)=(%s)
is
still referenced from table
\"
%s
\"
."
,
key_names
.
data
,
key_values
.
data
,
RelationGetRelationName
(
fk_rel
))));
else
if
(
onfk
)
...
...
This diff is collapsed.
Click to expand it.
src/backend/utils/misc/guc.c
View file @
887248e9
...
...
@@ -1042,7 +1042,7 @@ static struct config_bool ConfigureNamesBool[] =
},
{
{
"enable_partition_pruning"
,
PGC_USERSET
,
QUERY_TUNING_METHOD
,
gettext_noop
(
"Enable plan-time and run-time partition pruning."
),
gettext_noop
(
"Enable
s
plan-time and run-time partition pruning."
),
gettext_noop
(
"Allows the query planner and executor to compare partition "
"bounds to conditions in the query to determine which "
"partitions must be scanned."
),
...
...
@@ -3493,7 +3493,7 @@ static struct config_string ConfigureNamesString[] =
{
{
"recovery_target_timeline"
,
PGC_POSTMASTER
,
WAL_RECOVERY_TARGET
,
gettext_noop
(
"Specifies the timeline to recover
y
into."
),
gettext_noop
(
"Specifies the timeline to recover into."
),
NULL
},
&
recovery_target_timeline_string
,
...
...
@@ -3503,7 +3503,7 @@ static struct config_string ConfigureNamesString[] =
{
{
"recovery_target"
,
PGC_POSTMASTER
,
WAL_RECOVERY_TARGET
,
gettext_noop
(
"Set to
'immediate'
to end recovery as soon as a consistent state is reached."
),
gettext_noop
(
"Set to
\"
immediate
\"
to end recovery as soon as a consistent state is reached."
),
NULL
},
&
recovery_target_string
,
...
...
This diff is collapsed.
Click to expand it.
src/test/regress/expected/foreign_key.out
View file @
887248e9
...
...
@@ -2167,19 +2167,19 @@ INSERT into dropfk VALUES (1), (1000), (1500), (2000);
-- these should all fail
ALTER TABLE droppk DETACH PARTITION droppk_d;
ERROR: removing partition "droppk_d" violates foreign key constraint "dropfk_a_fkey5"
DETAIL: Key (a)=(2000) still referenced from table "dropfk".
DETAIL: Key (a)=(2000)
is
still referenced from table "dropfk".
ALTER TABLE droppk2 DETACH PARTITION droppk2_d;
ERROR: removing partition "droppk2_d" violates foreign key constraint "dropfk_a_fkey4"
DETAIL: Key (a)=(1500) still referenced from table "dropfk".
DETAIL: Key (a)=(1500)
is
still referenced from table "dropfk".
ALTER TABLE droppk DETACH PARTITION droppk1;
ERROR: removing partition "droppk1" violates foreign key constraint "dropfk_a_fkey1"
DETAIL: Key (a)=(1) still referenced from table "dropfk".
DETAIL: Key (a)=(1)
is
still referenced from table "dropfk".
ALTER TABLE droppk DETACH PARTITION droppk2;
ERROR: removing partition "droppk2" violates foreign key constraint "dropfk_a_fkey2"
DETAIL: Key (a)=(1000) still referenced from table "dropfk".
DETAIL: Key (a)=(1000)
is
still referenced from table "dropfk".
ALTER TABLE droppk2 DETACH PARTITION droppk21;
ERROR: removing partition "droppk21" violates foreign key constraint "dropfk_a_fkey3"
DETAIL: Key (a)=(1000) still referenced from table "dropfk".
DETAIL: Key (a)=(1000)
is
still referenced from table "dropfk".
-- dropping partitions is disallowed
DROP TABLE droppk_d;
ERROR: cannot drop table droppk_d because other objects depend on it
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment