Commit 87cec51d authored by Andres Freund's avatar Andres Freund

Don't delay replication for less than recovery_min_apply_delay's resolution.

Recovery delays are implemented by waiting on a latch, and latches take
milliseconds as a parameter. The required amount of waiting was computed
using microsecond resolution though and the wait loop's abort condition
was checking the delay in microseconds as well.  This could lead to
short spurts of busy looping when the overall wait time was below a
millisecond, but above 0 microseconds.

Instead just formulate the wait loop's abort condition in millisecond
granularity as well. Given that that's recovery_min_apply_delay
resolution, it seems harmless to not wait for less than a millisecond.

Backpatch to 9.4 where recovery_min_apply_delay was introduced.

Discussion: 20150323141819.GH26995@alap3.anarazel.de
parent a1105c3d
...@@ -5572,7 +5572,8 @@ recoveryApplyDelay(XLogReaderState *record) ...@@ -5572,7 +5572,8 @@ recoveryApplyDelay(XLogReaderState *record)
TimestampDifference(GetCurrentTimestamp(), recoveryDelayUntilTime, TimestampDifference(GetCurrentTimestamp(), recoveryDelayUntilTime,
&secs, &microsecs); &secs, &microsecs);
if (secs <= 0 && microsecs <= 0) /* NB: We're ignoring waits below min_apply_delay's resolution. */
if (secs <= 0 && microsecs / 1000 <= 0)
break; break;
elog(DEBUG2, "recovery apply delay %ld seconds, %d milliseconds", elog(DEBUG2, "recovery apply delay %ld seconds, %d milliseconds",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment