Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
8759b79d
Commit
8759b79d
authored
Mar 20, 2008
by
Alvaro Herrera
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a couple of missing FreeQueryDesc calls. Noticed while testing a
framework to keep track of snapshots in use.
parent
4e228447
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
3 deletions
+7
-3
src/backend/commands/portalcmds.c
src/backend/commands/portalcmds.c
+3
-1
src/backend/executor/spi.c
src/backend/executor/spi.c
+4
-2
No files found.
src/backend/commands/portalcmds.c
View file @
8759b79d
...
...
@@ -14,7 +14,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/portalcmds.c,v 1.
69 2008/01/01 19:45:49 momjian
Exp $
* $PostgreSQL: pgsql/src/backend/commands/portalcmds.c,v 1.
70 2008/03/20 20:05:56 alvherre
Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -262,6 +262,7 @@ PortalCleanup(Portal portal)
CurrentResourceOwner
=
portal
->
resowner
;
/* we do not need AfterTriggerEndQuery() here */
ExecutorEnd
(
queryDesc
);
FreeQueryDesc
(
queryDesc
);
}
PG_CATCH
();
{
...
...
@@ -362,6 +363,7 @@ PersistHoldablePortal(Portal portal)
portal
->
queryDesc
=
NULL
;
/* prevent double shutdown */
/* we do not need AfterTriggerEndQuery() here */
ExecutorEnd
(
queryDesc
);
FreeQueryDesc
(
queryDesc
);
/*
* Set the position in the result set: ideally, this could be
...
...
src/backend/executor/spi.c
View file @
8759b79d
...
...
@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.18
8 2008/02/12 04:09:44 tgl
Exp $
* $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.18
9 2008/03/20 20:05:56 alvherre
Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -1541,7 +1541,6 @@ _SPI_execute_plan(SPIPlanPtr plan, Datum *Values, const char *Nulls,
{
Node
*
stmt
=
(
Node
*
)
lfirst
(
lc2
);
bool
canSetTag
;
QueryDesc
*
qdesc
;
DestReceiver
*
dest
;
_SPI_current
->
processed
=
0
;
...
...
@@ -1617,6 +1616,8 @@ _SPI_execute_plan(SPIPlanPtr plan, Datum *Values, const char *Nulls,
if
(
IsA
(
stmt
,
PlannedStmt
)
&&
((
PlannedStmt
*
)
stmt
)
->
utilityStmt
==
NULL
)
{
QueryDesc
*
qdesc
;
qdesc
=
CreateQueryDesc
((
PlannedStmt
*
)
stmt
,
ActiveSnapshot
,
crosscheck_snapshot
,
...
...
@@ -1790,6 +1791,7 @@ _SPI_pquery(QueryDesc *queryDesc, bool fire_triggers, long tcount)
AfterTriggerEndQuery
(
queryDesc
->
estate
);
ExecutorEnd
(
queryDesc
);
/* FreeQueryDesc is done by the caller */
#ifdef SPI_EXECUTOR_STATS
if
(
ShowExecutorStats
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment