Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
7a8e9f29
Commit
7a8e9f29
authored
Jul 16, 2013
by
Noah Misch
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Comment on why planagg.c punts "MIN(x ORDER BY y)".
parent
4a87f308
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
16 additions
and
2 deletions
+16
-2
src/backend/optimizer/plan/planagg.c
src/backend/optimizer/plan/planagg.c
+16
-2
No files found.
src/backend/optimizer/plan/planagg.c
View file @
7a8e9f29
...
...
@@ -314,15 +314,29 @@ find_minmax_aggs_walker(Node *node, List **context)
ListCell
*
l
;
Assert
(
aggref
->
agglevelsup
==
0
);
if
(
list_length
(
aggref
->
args
)
!=
1
||
aggref
->
aggorder
!=
NIL
)
if
(
list_length
(
aggref
->
args
)
!=
1
)
return
true
;
/* it couldn't be MIN/MAX */
/*
* ORDER BY is usually irrelevant for MIN/MAX, but it can change the
* outcome if the aggsortop's operator class recognizes non-identical
* values as equal. For example, 4.0 and 4.00 are equal according to
* numeric_ops, yet distinguishable. If MIN() receives more than one
* value equal to 4.0 and no value less than 4.0, it is unspecified
* which of those equal values MIN() returns. An ORDER BY expression
* that differs for each of those equal values of the argument
* expression makes the result predictable once again. This is a
* niche requirement, and we do not implement it with subquery paths.
*/
if
(
aggref
->
aggorder
!=
NIL
)
return
true
;
/* note: we do not care if DISTINCT is mentioned ... */
curTarget
=
(
TargetEntry
*
)
linitial
(
aggref
->
args
);
aggsortop
=
fetch_agg_sort_op
(
aggref
->
aggfnoid
);
if
(
!
OidIsValid
(
aggsortop
))
return
true
;
/* not a MIN/MAX aggregate */
curTarget
=
(
TargetEntry
*
)
linitial
(
aggref
->
args
);
if
(
contain_mutable_functions
((
Node
*
)
curTarget
->
expr
))
return
true
;
/* not potentially indexable */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment