Commit 7a3543c2 authored by Michael Paquier's avatar Michael Paquier

Fix some comments referring to past features

Timestamp can only be an int64 since b9d092c9, and support for WITH OIDS
has been removed as of 578b2297.

Author: Justin Pryzby
Discussion: https://postgr.es/m/20200612023709.GC14879@telsasoft.com
parent 3baa7e38
...@@ -786,9 +786,7 @@ TupleDescInitEntryCollation(TupleDesc desc, ...@@ -786,9 +786,7 @@ TupleDescInitEntryCollation(TupleDesc desc,
* *
* Given a relation schema (list of ColumnDef nodes), build a TupleDesc. * Given a relation schema (list of ColumnDef nodes), build a TupleDesc.
* *
* Note: the default assumption is no OIDs; caller may modify the returned * Note: tdtypeid will need to be filled in later on.
* TupleDesc if it wants OIDs. Also, tdtypeid will need to be filled in
* later on.
*/ */
TupleDesc TupleDesc
BuildDescForRelation(List *schema) BuildDescForRelation(List *schema)
......
...@@ -4829,12 +4829,11 @@ ATRewriteTables(AlterTableStmt *parsetree, List **wqueue, LOCKMODE lockmode, ...@@ -4829,12 +4829,11 @@ ATRewriteTables(AlterTableStmt *parsetree, List **wqueue, LOCKMODE lockmode,
continue; continue;
/* /*
* If we change column data types or add/remove OIDs, the operation * If we change column data types, the operation has to be propagated
* has to be propagated to tables that use this table's rowtype as a * to tables that use this table's rowtype as a column type.
* column type. tab->newvals will also be non-NULL in the case where * tab->newvals will also be non-NULL in the case where we're adding a
* we're adding a column with a default. We choose to forbid that * column with a default. We choose to forbid that case as well,
* case as well, since composite types might eventually support * since composite types might eventually support defaults.
* defaults.
* *
* (Eventually we'll probably need to check for composite type * (Eventually we'll probably need to check for composite type
* dependencies even when we're just scanning the table without a * dependencies even when we're just scanning the table without a
...@@ -4853,8 +4852,7 @@ ATRewriteTables(AlterTableStmt *parsetree, List **wqueue, LOCKMODE lockmode, ...@@ -4853,8 +4852,7 @@ ATRewriteTables(AlterTableStmt *parsetree, List **wqueue, LOCKMODE lockmode,
/* /*
* We only need to rewrite the table if at least one column needs to * We only need to rewrite the table if at least one column needs to
* be recomputed, we are adding/removing the OID column, or we are * be recomputed, or we are changing its persistence.
* changing its persistence.
* *
* There are two reasons for requiring a rewrite when changing * There are two reasons for requiring a rewrite when changing
* persistence: on one hand, we need to ensure that the buffers * persistence: on one hand, we need to ensure that the buffers
......
...@@ -4018,8 +4018,8 @@ estimate_multivariate_ndistinct(PlannerInfo *root, RelOptInfo *rel, ...@@ -4018,8 +4018,8 @@ estimate_multivariate_ndistinct(PlannerInfo *root, RelOptInfo *rel,
* to be treated separately. * to be treated separately.
* *
* The several datatypes representing absolute times are all converted * The several datatypes representing absolute times are all converted
* to Timestamp, which is actually a double, and then we just use that * to Timestamp, which is actually an int64, and then we promote that to
* double value. Note this will give correct results even for the "special" * a double. Note this will give correct results even for the "special"
* values of Timestamp, since those are chosen to compare correctly; * values of Timestamp, since those are chosen to compare correctly;
* see timestamp_cmp. * see timestamp_cmp.
* *
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment