Commit 77b4bd3b authored by Tom Lane's avatar Tom Lane

Update some obsolete comments --- code is using t_self now, not t_ctid.

parent dfdf07aa
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.252 2005/08/01 20:31:07 tgl Exp $ * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.253 2005/08/18 21:34:20 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -1371,7 +1371,6 @@ ExecInsert(TupleTableSlot *slot, ...@@ -1371,7 +1371,6 @@ ExecInsert(TupleTableSlot *slot,
HeapTuple tuple; HeapTuple tuple;
ResultRelInfo *resultRelInfo; ResultRelInfo *resultRelInfo;
Relation resultRelationDesc; Relation resultRelationDesc;
int numIndices;
Oid newId; Oid newId;
/* /*
...@@ -1418,6 +1417,9 @@ ExecInsert(TupleTableSlot *slot, ...@@ -1418,6 +1417,9 @@ ExecInsert(TupleTableSlot *slot,
/* /*
* insert the tuple * insert the tuple
*
* Note: heap_insert returns the tid (location) of the new tuple
* in the t_self field.
*/ */
newId = heap_insert(resultRelationDesc, tuple, newId = heap_insert(resultRelationDesc, tuple,
estate->es_snapshot->curcid, estate->es_snapshot->curcid,
...@@ -1429,14 +1431,9 @@ ExecInsert(TupleTableSlot *slot, ...@@ -1429,14 +1431,9 @@ ExecInsert(TupleTableSlot *slot,
setLastTid(&(tuple->t_self)); setLastTid(&(tuple->t_self));
/* /*
* process indices * insert index entries for tuple
*
* Note: heap_insert adds a new tuple to a relation. As a side effect,
* the tupleid of the new tuple is placed in the new tuple's t_ctid
* field.
*/ */
numIndices = resultRelInfo->ri_NumIndices; if (resultRelInfo->ri_NumIndices > 0)
if (numIndices > 0)
ExecInsertIndexTuples(slot, &(tuple->t_self), estate, false); ExecInsertIndexTuples(slot, &(tuple->t_self), estate, false);
/* AFTER ROW INSERT Triggers */ /* AFTER ROW INSERT Triggers */
...@@ -1563,7 +1560,6 @@ ExecUpdate(TupleTableSlot *slot, ...@@ -1563,7 +1560,6 @@ ExecUpdate(TupleTableSlot *slot,
Relation resultRelationDesc; Relation resultRelationDesc;
ItemPointerData ctid; ItemPointerData ctid;
HTSU_Result result; HTSU_Result result;
int numIndices;
/* /*
* abort the operation if not running transactions * abort the operation if not running transactions
...@@ -1676,23 +1672,18 @@ lreplace:; ...@@ -1676,23 +1672,18 @@ lreplace:;
/* /*
* Note: instead of having to update the old index tuples associated * Note: instead of having to update the old index tuples associated
* with the heap tuple, all we do is form and insert new index tuples. * with the heap tuple, all we do is form and insert new index tuples.
* This is because UPDATEs are actually DELETEs and INSERTs and index * This is because UPDATEs are actually DELETEs and INSERTs, and index
* tuple deletion is done automagically by the vacuum daemon. All we * tuple deletion is done automagically by the vacuum daemon. All we
* do is insert new index tuples. -cim 9/27/89 * do is insert new index tuples. -cim 9/27/89
*/ */
/* /*
* process indices * insert index entries for tuple
* *
* heap_update updates a tuple in the base relation by invalidating it * Note: heap_update returns the tid (location) of the new tuple
* and then inserting a new tuple to the relation. As a side effect, * in the t_self field.
* the tupleid of the new tuple is placed in the new tuple's t_ctid
* field. So we now insert index tuples using the new tupleid stored
* there.
*/ */
if (resultRelInfo->ri_NumIndices > 0)
numIndices = resultRelInfo->ri_NumIndices;
if (numIndices > 0)
ExecInsertIndexTuples(slot, &(tuple->t_self), estate, false); ExecInsertIndexTuples(slot, &(tuple->t_self), estate, false);
/* AFTER ROW UPDATE Triggers */ /* AFTER ROW UPDATE Triggers */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment