Commit 7567d949 authored by Bruce Momjian's avatar Bruce Momjian

pg_upgrade: adjust logging to use QUERY_ALLOC lengths

Allows the logging to print the entire text of failed queries, rather
than a truncated version.
parent 02587dcd
......@@ -104,22 +104,22 @@ cluster_conn_opts(ClusterInfo *cluster)
PGresult *
executeQueryOrDie(PGconn *conn, const char *fmt,...)
{
static char command[8192];
static char query[QUERY_ALLOC];
va_list args;
PGresult *result;
ExecStatusType status;
va_start(args, fmt);
vsnprintf(command, sizeof(command), fmt, args);
vsnprintf(query, sizeof(query), fmt, args);
va_end(args);
pg_log(PG_VERBOSE, "executing: %s\n", command);
result = PQexec(conn, command);
pg_log(PG_VERBOSE, "executing: %s\n", query);
result = PQexec(conn, query);
status = PQresultStatus(result);
if ((status != PGRES_TUPLES_OK) && (status != PGRES_COMMAND_OK))
{
pg_log(PG_REPORT, "SQL command failed\n%s\n%s\n", command,
pg_log(PG_REPORT, "SQL command failed\n%s\n%s\n", query,
PQerrorMessage(conn));
PQclear(result);
PQfinish(conn);
......
......@@ -86,7 +86,7 @@ __attribute__((format(PG_PRINTF_ATTRIBUTE, 2, 0)))
void
pg_log_v(eLogType type, const char *fmt, va_list ap)
{
char message[MAX_STRING];
char message[QUERY_ALLOC];
vsnprintf(message, sizeof(message), fmt, ap);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment