Commit 6f69b963 authored by Stephen Frost's avatar Stephen Frost

Wording quibbles regarding initdb username

Use disallowed instead of reserved, cannot instead of can not, and
double quotes instead of single quotes.

Also add a test to cover the bug which started this discussion.

Per discussion with Tom.
parent 7df974ee
......@@ -3564,7 +3564,7 @@ main(int argc, char *argv[])
if (strncmp(username, "pg_", 3) == 0)
{
fprintf(stderr, _("%s: superuser name \"%s\" is reserved; role names can not begin with 'pg_'\n"), progname, username);
fprintf(stderr, _("%s: superuser name \"%s\" is disallowed; role names cannot begin with \"pg_\"\n"), progname, username);
exit(1);
}
......
......@@ -6,7 +6,7 @@ use strict;
use warnings;
use PostgresNode;
use TestLib;
use Test::More tests => 14;
use Test::More tests => 15;
my $tempdir = TestLib::tempdir;
my $xlogdir = "$tempdir/pgxlog";
......@@ -29,6 +29,10 @@ command_fails(
[ 'initdb', '-X', 'pgxlog', $datadir ],
'relative xlog directory not allowed');
command_fails(
[ 'initdb', '-U', 'pg_test', $datadir ],
'role names cannot being with "pg_"');
mkdir $datadir;
command_ok([ 'initdb', '-N', '-T', 'german', '-X', $xlogdir, $datadir ],
'successful creation');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment