Commit 6c2744f1 authored by Heikki Linnakangas's avatar Heikki Linnakangas

Use memmove() instead of memcpy() for copying overlapping regions.

In commit d2495f27, I fixed this bug in
to_tsquery(), but missed the fact that plainto_tsquery() has the same bug.
parent dfb1e9bd
...@@ -396,6 +396,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS) ...@@ -396,6 +396,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)
if (query->size == 0) if (query->size == 0)
PG_RETURN_TSQUERY(query); PG_RETURN_TSQUERY(query);
/* clean out any stopword placeholders from the tree */
res = clean_fakeval(GETQUERY(query), &len); res = clean_fakeval(GETQUERY(query), &len);
if (!res) if (!res)
{ {
...@@ -405,6 +406,10 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS) ...@@ -405,6 +406,10 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)
} }
memcpy((void *) GETQUERY(query), (void *) res, len * sizeof(QueryItem)); memcpy((void *) GETQUERY(query), (void *) res, len * sizeof(QueryItem));
/*
* Removing the stopword placeholders might've resulted in fewer
* QueryItems. If so, move the operands up accordingly.
*/
if (len != query->size) if (len != query->size)
{ {
char *oldoperand = GETOPERAND(query); char *oldoperand = GETOPERAND(query);
...@@ -413,7 +418,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS) ...@@ -413,7 +418,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS)
Assert(len < query->size); Assert(len < query->size);
query->size = len; query->size = len;
memcpy((void *) GETOPERAND(query), oldoperand, lenoperand); memmove((void *) GETOPERAND(query), oldoperand, lenoperand);
SET_VARSIZE(query, COMPUTESIZE(len, lenoperand)); SET_VARSIZE(query, COMPUTESIZE(len, lenoperand));
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment