Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
68b1a487
Commit
68b1a487
authored
Nov 23, 2020
by
Heikki Linnakangas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix a few comments that referred to copy.c.
Missed these in the previous commit.
parent
c532d15d
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
7 additions
and
7 deletions
+7
-7
src/backend/libpq/pqcomm.c
src/backend/libpq/pqcomm.c
+1
-1
src/include/commands/trigger.h
src/include/commands/trigger.h
+3
-3
src/include/nodes/execnodes.h
src/include/nodes/execnodes.h
+1
-1
src/test/regress/expected/triggers.out
src/test/regress/expected/triggers.out
+1
-1
src/test/regress/sql/triggers.sql
src/test/regress/sql/triggers.sql
+1
-1
No files found.
src/backend/libpq/pqcomm.c
View file @
68b1a487
...
...
@@ -1626,7 +1626,7 @@ socket_endcopyout(bool errorAbort)
return
;
if
(
errorAbort
)
pq_putbytes
(
"
\n\n\\
.
\n
"
,
5
);
/* in non-error case, copy.c will have emitted the terminator line */
/* in non-error case, copy
to
.c will have emitted the terminator line */
DoingCopyOut
=
false
;
}
...
...
src/include/commands/trigger.h
View file @
68b1a487
...
...
@@ -44,7 +44,7 @@ typedef struct TriggerData
/*
* The state for capturing old and new tuples into transition tables for a
* single ModifyTable node (or other operation source, e.g. copy.c).
* single ModifyTable node (or other operation source, e.g. copy
from
.c).
*
* This is per-caller to avoid conflicts in setting
* tcs_original_insert_tuple. Note, however, that the pointed-to
...
...
@@ -69,8 +69,8 @@ typedef struct TransitionCaptureState
* For INSERT and COPY, it would be wasteful to convert tuples from child
* format to parent format after they have already been converted in the
* opposite direction during routing. In that case we bypass conversion
* and allow the inserting code (copy
.c and nodeModifyTable.c) to provide
* a slot containing the original tuple directly.
* and allow the inserting code (copy
from.c and nodeModifyTable.c) to
*
provide
a slot containing the original tuple directly.
*/
TupleTableSlot
*
tcs_original_insert_tuple
;
...
...
src/include/nodes/execnodes.h
View file @
68b1a487
...
...
@@ -498,7 +498,7 @@ typedef struct ResultRelInfo
*/
TupleConversionMap
*
ri_ChildToRootMap
;
/* for use by copy.c when performing multi-inserts */
/* for use by copy
from
.c when performing multi-inserts */
struct
CopyMultiInsertBuffer
*
ri_CopyMultiInsertBuffer
;
}
ResultRelInfo
;
...
...
src/test/regress/expected/triggers.out
View file @
68b1a487
...
...
@@ -2904,7 +2904,7 @@ NOTICE: trigger = child3_delete_trig, old table = (CCC,42,foo)
copy parent (a, b) from stdin;
NOTICE: trigger = parent_insert_trig, new table = (AAA,42), (BBB,42), (CCC,42)
-- same behavior for copy if there is an index (interesting because rows are
-- captured by a different code path in copy.c if there are indexes)
-- captured by a different code path in copy
from
.c if there are indexes)
create index on parent(b);
copy parent (a, b) from stdin;
NOTICE: trigger = parent_insert_trig, new table = (DDD,42)
...
...
src/test/regress/sql/triggers.sql
View file @
68b1a487
...
...
@@ -2112,7 +2112,7 @@ CCC 42
\
.
-- same behavior for copy if there is an index (interesting because rows are
-- captured by a different code path in copy.c if there are indexes)
-- captured by a different code path in copy
from
.c if there are indexes)
create
index
on
parent
(
b
);
copy
parent
(
a
,
b
)
from
stdin
;
DDD
42
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment